Re: [PATCH 16/41] drm/stm: Use .dumb_map_offset and .dumb_destroy defaults

From: Philippe CORNU <philippe.cornu@st.com>
To: "Noralf Trønnes" <noralf@tronnes.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Cc: "narmstrong@baylibre.com" <narmstrong@baylibre.com>,
	"liviu.dudau@arm.com" <liviu.dudau@arm.com>,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	"laurent.pinchart@ideasonboard.com"
	<laurent.pinchart@ideasonboard.com>,
	"daniel.vetter@intel.com" <daniel.vetter@intel.com>,
	"marex@denx.de" <marex@denx.de>,
	"boris.brezillon@free-electrons.com"
	<boris.brezillon@free-electrons.com>,
	"abrodkin@synopsys.com" <abrodkin@synopsys.com>,
	"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
	"z.liuxinliang@hisilicon.com" <z.liuxinliang@hisilicon.com>,
	"kong.kongxinwei@hisilicon.com" <kong.kongxinwei@hisilicon.com>,
	"tomi.valkeinen@ti.com" <tomi.valkeinen@ti.com>,
	"bskeggs@redhat.com" <bskeggs@redhat.com>,
	"airlied@redhat.com" <airlied@redhat.com>,
	"puck.chen@hisilicon.com" <puck.chen@hisilicon.com>,
	"jsarha@ti.com" <jsarha@ti.com>,
	"alexander.deucher@amd.com" <alexander.deucher@a>
Subject: Re: [PATCH 16/41] drm/stm: Use .dumb_map_offset and .dumb_destroy defaults
Date: Tue, 25 Jul 2017 08:43:24 +0000	[thread overview]
Message-ID: <dc0a52c1-e9d0-6155-1f3c-e5c8c802f28d@st.com> (raw)
In-Reply-To: <1500837417-40580-17-git-send-email-noralf@tronnes.org>

On 07/23/2017 09:16 PM, Noralf Trønnes wrote:
> This driver can use the drm_driver.dumb_destroy and
> drm_driver.dumb_map_offset defaults, so no need to set them.
> 
> Cc: Yannick Fertre <yannick.fertre@st.com>
> Cc: Philippe Cornu <philippe.cornu@st.com>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> ---
>   drivers/gpu/drm/stm/drv.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/stm/drv.c b/drivers/gpu/drm/stm/drv.c
> index 095971f..b333b37 100644
> --- a/drivers/gpu/drm/stm/drv.c
> +++ b/drivers/gpu/drm/stm/drv.c
> @@ -60,8 +60,6 @@ static struct drm_driver drv_driver = {
>   	.patchlevel = 0,
>   	.fops = &drv_driver_fops,
>   	.dumb_create = drm_gem_cma_dumb_create,
> -	.dumb_map_offset = drm_gem_cma_dumb_map_offset,
> -	.dumb_destroy = drm_gem_dumb_destroy,
>   	.prime_handle_to_fd = drm_gem_prime_handle_to_fd,
>   	.prime_fd_to_handle = drm_gem_prime_fd_to_handle,
>   	.gem_free_object_unlocked = drm_gem_cma_free_object,
> 

Tested-by: Philippe Cornu <philippe.cornu@st.com>
Acked-by: Philippe Cornu <philippe.cornu@st.com>

Many thanks for the cleanup.

Philippe :-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel