dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: "Noralf Trønnes" <noralf@tronnes.org>, dri-devel@lists.freedesktop.org
Cc: narmstrong@baylibre.com, liviu.dudau@arm.com,
	linux@armlinux.org.uk, thierry.reding@gmail.com,
	laurent.pinchart@ideasonboard.com, daniel.vetter@intel.com,
	marex@denx.de, boris.brezillon@free-electrons.com,
	abrodkin@synopsys.com, z.liuxinliang@hisilicon.com,
	kong.kongxinwei@hisilicon.com, tomi.valkeinen@ti.com,
	bskeggs@redhat.com, airlied@redhat.com, puck.chen@hisilicon.com,
	zourongrong@gmail.com, jsarha@ti.com, vincent.abriou@st.com,
	alison.wang@freescale.com, sw0312.kim@samsung.com,
	philippe.cornu@st.com, yannick.fertre@st.com,
	kyungmin.park@samsung.com, alexander.deucher@amd.com,
	maxime.ripard@free-electrons.com, shawnguo@kernel.org,
	christian.koenig@amd.com, kraxel@redhat.com
Subject: Re: [PATCH 02/41] drm/dumb-buffers: Add defaults for .dumb_map_offset and .dumb_destroy
Date: Mon, 24 Jul 2017 09:33:39 -0700	[thread overview]
Message-ID: <87pocpbxr0.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1500837417-40580-3-git-send-email-noralf@tronnes.org>


[-- Attachment #1.1: Type: text/plain, Size: 1445 bytes --]

Noralf Trønnes <noralf@tronnes.org> writes:

> Almost everyone did end up using GEM as bo, so this adds defaults
> for the drm_driver.dumb_destroy and drm_driver.dumb_map_offset
> callbacks.
>
> Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
> ---
>  drivers/gpu/drm/drm_dumb_buffers.c | 26 ++++++++++++++++++--------
>  1 file changed, 18 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dumb_buffers.c b/drivers/gpu/drm/drm_dumb_buffers.c
> index 10307cc..cd68ab4 100644
> --- a/drivers/gpu/drm/drm_dumb_buffers.c
> +++ b/drivers/gpu/drm/drm_dumb_buffers.c
> @@ -24,6 +24,7 @@
>   */
>  
>  #include <drm/drmP.h>
> +#include <drm/drm_gem.h>
>  
>  #include "drm_crtc_internal.h"
>  
> @@ -42,9 +43,10 @@
>   * create dumb buffers suitable for scanout, which can then be used to create
>   * KMS frame buffers.
>   *
> - * To support dumb objects drivers must implement the &drm_driver.dumb_create,
> - * &drm_driver.dumb_destroy and &drm_driver.dumb_map_offset operations. See
> - * there for further details.
> + * To support dumb objects drivers must implement the &drm_driver.dumb_create
> + * operation. &drm_driver.dumb_destroy defaults to drm_gem_dumb_destroy() if
> + * not set and &drm_driver.dumb_map_offset operations to

s/operations/default/ I think

Other than that, patch 1-2 are:

Reviewed-by: Eric Anholt <eric@anholt.net>

Thanks for working on these cleanups!

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-07-24 16:33 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-23 19:16 [PATCH 00/41] drm/dumb-buffers: Add defaults for .dumb_map_offset and .dumb_destroy Noralf Trønnes
2017-07-23 19:16 ` [PATCH 01/41] drm/gem: Add drm_gem_dumb_map_offset() Noralf Trønnes
2017-07-24  7:46   ` Philipp Zabel
2017-07-24 22:50   ` Laurent Pinchart
2017-07-26 12:05   ` Emil Velikov
2017-07-26 18:41     ` Noralf Trønnes
2017-07-27  0:13       ` Emil Velikov
2017-07-27 15:57         ` Noralf Trønnes
2017-07-27 10:01       ` Laurent Pinchart
2017-07-26 14:19   ` Sean Paul
2017-07-23 19:16 ` [PATCH 02/41] drm/dumb-buffers: Add defaults for .dumb_map_offset and .dumb_destroy Noralf Trønnes
2017-07-24 16:33   ` Eric Anholt [this message]
2017-07-26 14:24   ` Sean Paul
2017-07-23 19:16 ` [PATCH 03/41] drm/arc: Use .dumb_map_offset and .dumb_destroy defaults Noralf Trønnes
2017-07-24  6:51   ` Alexey Brodkin
2017-07-23 19:16 ` [PATCH 04/41] drm/arm: hdlcd: " Noralf Trønnes
2017-07-24 12:10   ` Brian Starkey
2017-07-23 19:16 ` [PATCH 05/41] drm/arm: mali-dp: " Noralf Trønnes
2017-07-24 12:11   ` Brian Starkey
2017-07-23 19:16 ` [PATCH 06/41] drm/atmel-hlcdc: " Noralf Trønnes
2017-07-27 19:21   ` Boris Brezillon
2017-07-23 19:16 ` [PATCH 07/41] drm/fsl-dcu: " Noralf Trønnes
2017-07-29 17:24   ` Stefan Agner
2017-08-04 13:15     ` Noralf Trønnes
2017-07-23 19:16 ` [PATCH 08/41] drm/kirin: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 09/41] drm/imx: " Noralf Trønnes
2017-07-24  7:46   ` Philipp Zabel
2017-07-24 19:37     ` Noralf Trønnes
2017-07-23 19:16 ` [PATCH 10/41] drm/meson: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 11/41] drm/mxsfb: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 12/41] drm/pl111: " Noralf Trønnes
2017-07-24 16:34   ` Eric Anholt
2017-07-23 19:16 ` [PATCH 13/41] drm/rcar-du: " Noralf Trønnes
2017-07-24 22:51   ` Laurent Pinchart
2017-07-23 19:16 ` [PATCH 14/41] drm/shmobile: " Noralf Trønnes
2017-07-24 22:51   ` Laurent Pinchart
2017-07-23 19:16 ` [PATCH 15/41] drm/sti: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 16/41] drm/stm: " Noralf Trønnes
2017-07-25  8:43   ` Philippe CORNU
2017-07-23 19:16 ` [PATCH 17/41] drm/sun4i: " Noralf Trønnes
2017-07-27  6:34   ` Maxime Ripard
2017-07-23 19:16 ` [PATCH 18/41] drm/tilcdc: " Noralf Trønnes
2017-07-27 12:18   ` Jyri Sarha
2017-07-23 19:16 ` [PATCH 19/41] drm/vc4: " Noralf Trønnes
2017-07-24 16:33   ` Eric Anholt
2017-07-23 19:16 ` [PATCH 20/41] drm/zte: " Noralf Trønnes
2017-07-25 14:15   ` Shawn Guo
2017-07-23 19:16 ` [PATCH 21/41] drm/tinydrm: " Noralf Trønnes
2017-07-26 14:25   ` Sean Paul
2017-07-23 19:16 ` [PATCH 22/41] drm/mediatek: " Noralf Trønnes
2017-07-24  7:38   ` Philipp Zabel
2017-07-23 19:16 ` [PATCH 23/41] drm/gma500: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 24/41] drm/rockchip: " Noralf Trønnes
2017-07-26 14:19   ` Sean Paul
2017-07-23 19:16 ` [PATCH 25/41] drm/tegra: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 26/41] drm/cirrus: Use the drm_driver.dumb_destroy default Noralf Trønnes
2017-07-23 19:16 ` [PATCH 27/41] drm/udl: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 28/41] drm/qxl: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 29/41] drm/amdgpu: " Noralf Trønnes
2017-07-24 15:18   ` Deucher, Alexander
2017-07-23 19:16 ` [PATCH 30/41] drm/omapdrm: " Noralf Trønnes
2017-07-24 22:51   ` Laurent Pinchart
2017-07-23 19:16 ` [PATCH 31/41] drm/ast: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 32/41] drm/nouveau: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 33/41] drm/i915: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 34/41] drm/msm: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 35/41] drm/exynos: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 36/41] drm/hisilicon: hibmc: " Noralf Trønnes
2017-07-26 14:25   ` Sean Paul
2017-07-23 19:16 ` [PATCH 37/41] drm/mgag200: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 38/41] drm/radeon: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 39/41] drm/bochs: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 40/41] drm/armada: " Noralf Trønnes
2017-07-23 19:16 ` [PATCH 41/41] drm/virtio: " Noralf Trønnes
2017-07-24 19:39 ` [PATCH 00/41] drm/dumb-buffers: Add defaults for .dumb_map_offset and .dumb_destroy Noralf Trønnes
2017-07-25  6:57   ` Daniel Vetter
2017-07-25  8:44 ` Philippe CORNU
2017-07-29 12:09 ` Noralf Trønnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pocpbxr0.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=abrodkin@synopsys.com \
    --cc=airlied@redhat.com \
    --cc=alexander.deucher@amd.com \
    --cc=alison.wang@freescale.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=bskeggs@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=kong.kongxinwei@hisilicon.com \
    --cc=kraxel@redhat.com \
    --cc=kyungmin.park@samsung.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux@armlinux.org.uk \
    --cc=liviu.dudau@arm.com \
    --cc=marex@denx.de \
    --cc=maxime.ripard@free-electrons.com \
    --cc=narmstrong@baylibre.com \
    --cc=noralf@tronnes.org \
    --cc=philippe.cornu@st.com \
    --cc=puck.chen@hisilicon.com \
    --cc=shawnguo@kernel.org \
    --cc=sw0312.kim@samsung.com \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=vincent.abriou@st.com \
    --cc=yannick.fertre@st.com \
    --cc=z.liuxinliang@hisilicon.com \
    --cc=zourongrong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox