From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 4/5] drm/omap: Stop using drm_framebuffer_unregister_private
Date: Thu, 12 Jan 2017 11:56:12 +0200 [thread overview]
Message-ID: <3163577.EXmDDZ9C8j@avalon> (raw)
In-Reply-To: <1482835765-12044-4-git-send-email-daniel.vetter@ffwll.ch>
Hi Daniel,
Thank you for the patch.
On Tuesday 27 Dec 2016 11:49:24 Daniel Vetter wrote:
> This is the deprecated function for when you embedded the framebuffer
> somewhere else (which breaks refcounting). But omapdrm is using
> drm_framebuffer_remove and a free-standing fb, so this is rendundant.
>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/omapdrm/omap_fbdev.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> b/drivers/gpu/drm/omapdrm/omap_fbdev.c index aed99a0fc44b..2a839956dae6
> 100644
> --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c
> +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c
> @@ -225,10 +225,8 @@ static int omap_fbdev_create(struct drm_fb_helper
> *helper,
>
> drm_fb_helper_release_fbi(helper);
>
> - if (fb) {
> - drm_framebuffer_unregister_private(fb);
> + if (fb)
> drm_framebuffer_remove(fb);
> - }
> }
>
> return ret;
> @@ -314,10 +312,8 @@ void omap_fbdev_free(struct drm_device *dev)
> omap_gem_put_paddr(fbdev->bo);
>
> /* this will free the backing object */
> - if (fbdev->fb) {
> - drm_framebuffer_unregister_private(fbdev->fb);
> + if (fbdev->fb)
> drm_framebuffer_remove(fbdev->fb);
> - }
>
> kfree(fbdev);
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-01-12 9:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 10:49 [PATCH 1/5] drm/msm: Stop using drm_framebuffer_unregister_private Daniel Vetter
2016-12-27 10:49 ` [PATCH 2/5] drm/cma-helper: " Daniel Vetter
2017-01-12 10:00 ` Laurent Pinchart
2016-12-27 10:49 ` [PATCH 3/5] drm/exynos: " Daniel Vetter
2017-01-12 8:21 ` Inki Dae
2016-12-27 10:49 ` [PATCH 4/5] drm/omap: " Daniel Vetter
2017-01-12 9:56 ` Laurent Pinchart [this message]
2016-12-27 10:49 ` [PATCH 5/5] drm/tegra: " Daniel Vetter
2017-01-12 10:15 ` Archit Taneja
2017-01-12 14:37 ` Thierry Reding
2017-01-12 9:48 ` [PATCH 1/5] drm/msm: " Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3163577.EXmDDZ9C8j@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox