dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Inki Dae <inki.dae@samsung.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
	DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 3/5] drm/exynos: Stop using drm_framebuffer_unregister_private
Date: Thu, 12 Jan 2017 17:21:52 +0900	[thread overview]
Message-ID: <58773CA0.9030302@samsung.com> (raw)
In-Reply-To: <1482835765-12044-3-git-send-email-daniel.vetter@ffwll.ch>

Applied.

Thanks.

2016년 12월 27일 19:49에 Daniel Vetter 이(가) 쓴 글:
> This is the deprecated function for when you embedded the framebuffer
> somewhere else (which breaks refcounting). But exynos is using
> drm_framebuffer_remove and a free-standing fb, so this is rendundant.
> 
> Cc: Inki Dae <inki.dae@samsung.com>
> Cc: Joonyoung Shim <jy0922.shim@samsung.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> index d8808158d418..a7884bea42eb 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
> @@ -270,10 +270,8 @@ static void exynos_drm_fbdev_destroy(struct drm_device *dev,
>  	/* release drm framebuffer and real buffer */
>  	if (fb_helper->fb && fb_helper->fb->funcs) {
>  		fb = fb_helper->fb;
> -		if (fb) {
> -			drm_framebuffer_unregister_private(fb);
> +		if (fb)
>  			drm_framebuffer_remove(fb);
> -		}
>  	}
>  
>  	drm_fb_helper_unregister_fbi(fb_helper);
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-01-12  8:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-27 10:49 [PATCH 1/5] drm/msm: Stop using drm_framebuffer_unregister_private Daniel Vetter
2016-12-27 10:49 ` [PATCH 2/5] drm/cma-helper: " Daniel Vetter
2017-01-12 10:00   ` Laurent Pinchart
2016-12-27 10:49 ` [PATCH 3/5] drm/exynos: " Daniel Vetter
2017-01-12  8:21   ` Inki Dae [this message]
2016-12-27 10:49 ` [PATCH 4/5] drm/omap: " Daniel Vetter
2017-01-12  9:56   ` Laurent Pinchart
2016-12-27 10:49 ` [PATCH 5/5] drm/tegra: " Daniel Vetter
2017-01-12 10:15   ` Archit Taneja
2017-01-12 14:37   ` Thierry Reding
2017-01-12  9:48 ` [PATCH 1/5] drm/msm: " Archit Taneja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58773CA0.9030302@samsung.com \
    --to=inki.dae@samsung.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox