Re: [PATCH 5/5] drm/tegra: Stop using drm_framebuffer_unregister_private

[Archit Taneja <architt@codeaurora.org>]

On 12/27/2016 04:19 PM, Daniel Vetter wrote:
> This is the deprecated function for when you embedded the framebuffer
> somewhere else (which breaks refcounting). But tegra is using
> drm_framebuffer_remove and a free-standing fb, so this is rendundant.

s/rendundant/redundant

>
> One caveat here is that the failur path in the init code still

s/failur/failure

> manually cleaned up the fb. I presume that was an oversigth and

s/oversigth/oversight

> changed it over to drm_framebuffer_remove too.

Reviewed-by: Archit Taneja <architt@codeaurora.org>

>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/tegra/fb.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
> index 8df7783cecc2..f896e2ff7d47 100644
> --- a/drivers/gpu/drm/tegra/fb.c
> +++ b/drivers/gpu/drm/tegra/fb.c
> @@ -271,8 +271,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
>  	return 0;
>
>  destroy:
> -	drm_framebuffer_unregister_private(fb);
> -	tegra_fb_destroy(fb);
> +	drm_framebuffer_remove(fb);
>  release:
>  	drm_fb_helper_release_fbi(helper);
>  	return err;
> @@ -342,10 +341,8 @@ static void tegra_fbdev_exit(struct tegra_fbdev *fbdev)
>  	drm_fb_helper_unregister_fbi(&fbdev->base);
>  	drm_fb_helper_release_fbi(&fbdev->base);
>
> -	if (fbdev->fb) {
> -		drm_framebuffer_unregister_private(&fbdev->fb->base);
> +	if (fbdev->fb)
>  		drm_framebuffer_remove(&fbdev->fb->base);
> -	}
>
>  	drm_fb_helper_fini(&fbdev->base);
>  	tegra_fbdev_free(fbdev);
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel