Re: [PATCH v2 12/12] drm/i915/psr: Do not disable Panel Replay in case VRR is enabled

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

On 5/20/2025 10:23 PM, Jouni Högander wrote:
> This patch is allowing Panel Replay with VRR. All VRR modes are supposed to


I think you missed to remove `patch` from the commit message.


Regards,

Ankit

> work with Panel Replay.
>
> Bspec: 68920, 68925
> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_psr.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 38535e0d2496..db7111374293 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1579,6 +1579,12 @@ static bool _psr_compute_config(struct intel_dp *intel_dp,
>   	if (!CAN_PSR(intel_dp))
>   		return false;
>   
> +	/*
> +	 * Currently PSR doesn't work reliably with VRR enabled.
> +	 */
> +	if (crtc_state->vrr.enable)
> +		return false;
> +
>   	entry_setup_frames = intel_psr_entry_setup_frames(intel_dp, adjusted_mode);
>   
>   	if (entry_setup_frames >= 0) {
> @@ -1696,12 +1702,6 @@ void intel_psr_compute_config(struct intel_dp *intel_dp,
>   		return;
>   	}
>   
> -	/*
> -	 * Currently PSR/PR doesn't work reliably with VRR enabled.
> -	 */
> -	if (crtc_state->vrr.enable)
> -		return;
> -
>   	crtc_state->has_panel_replay = _panel_replay_compute_config(intel_dp,
>   								    crtc_state,
>   								    conn_state);