* Re: [PATCH 0/4] Fix acpi_bus_get_device() check [not found] ` <5109E11A.5030400@jp.fujitsu.com> @ 2013-01-31 3:19 ` Yasuaki Ishimatsu 2013-01-31 3:27 ` [RESEND PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c Yasuaki Ishimatsu 0 siblings, 1 reply; 7+ messages in thread From: Yasuaki Ishimatsu @ 2013-01-31 3:19 UTC (permalink / raw) To: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg, Yinghai Lu, Toshi Kani, daniel.vetter, airlied, dri-devel acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_FAILURE() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> --- drivers/gpu/drm/i915/intel_opregion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-pm/drivers/gpu/drm/i915/intel_opregion.c =================================================================== --- linux-pm.orig/drivers/gpu/drm/i915/intel_opregion.c 2013-01-31 11:39:37.075849905 +0900 +++ linux-pm/drivers/gpu/drm/i915/intel_opregion.c 2013-01-31 11:52:18.796850274 +0900 @@ -347,7 +347,7 @@ static void intel_didl_outputs(struct dr int i = 0; handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev); - if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) + if (!handle || acpi_bus_get_device(handle, &acpi_dev)) return; if (acpi_is_video_device(acpi_dev)) ^ permalink raw reply [flat|nested] 7+ messages in thread
* [RESEND PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c 2013-01-31 3:19 ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu @ 2013-01-31 3:27 ` Yasuaki Ishimatsu 2013-01-31 10:03 ` Daniel Vetter 0 siblings, 1 reply; 7+ messages in thread From: Yasuaki Ishimatsu @ 2013-01-31 3:27 UTC (permalink / raw) To: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg, Yinghai Lu, Toshi Kani, daniel.vetter, airlied, dri-devel I forgot to change subject. So I resend a patch. --- acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_FAILURE() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> --- drivers/gpu/drm/i915/intel_opregion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-pm/drivers/gpu/drm/i915/intel_opregion.c =================================================================== --- linux-pm.orig/drivers/gpu/drm/i915/intel_opregion.c 2013-01-31 11:39:37.075849905 +0900 +++ linux-pm/drivers/gpu/drm/i915/intel_opregion.c 2013-01-31 11:52:18.796850274 +0900 @@ -347,7 +347,7 @@ static void intel_didl_outputs(struct dr int i = 0; handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev); - if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) + if (!handle || acpi_bus_get_device(handle, &acpi_dev)) return; if (acpi_is_video_device(acpi_dev)) ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c 2013-01-31 3:27 ` [RESEND PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c Yasuaki Ishimatsu @ 2013-01-31 10:03 ` Daniel Vetter 2013-02-01 0:50 ` [UPDATE][PATCH " Yasuaki Ishimatsu 0 siblings, 1 reply; 7+ messages in thread From: Daniel Vetter @ 2013-01-31 10:03 UTC (permalink / raw) To: Yasuaki Ishimatsu Cc: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg, Yinghai Lu, Toshi Kani, daniel.vetter, airlied, dri-devel On Thu, Jan 31, 2013 at 12:27:26PM +0900, Yasuaki Ishimatsu wrote: > I forgot to change subject. So I resend a patch. > > --- > acpi_bus_get_device() returns int not acpi_status. > > The patch change not to apply ACPI_FAILURE() to the return value of > acpi_bus_get_device(). > > Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> I've tried to apply this to drm-intel-next-queued, but git am didn't really like your patch - it failed to apply. Can you please rebase to the drm-intel-next-queued branch from git://people.freedesktop.org/~danvet/drm-intel and please resubmit the patch, preferrably formatted with git format-patch? Thanks, Daniel > --- > drivers/gpu/drm/i915/intel_opregion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-pm/drivers/gpu/drm/i915/intel_opregion.c > =================================================================== > --- linux-pm.orig/drivers/gpu/drm/i915/intel_opregion.c 2013-01-31 11:39:37.075849905 +0900 > +++ linux-pm/drivers/gpu/drm/i915/intel_opregion.c 2013-01-31 11:52:18.796850274 +0900 > @@ -347,7 +347,7 @@ static void intel_didl_outputs(struct dr > int i = 0; > handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev); > - if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) > + if (!handle || acpi_bus_get_device(handle, &acpi_dev)) > return; > if (acpi_is_video_device(acpi_dev)) > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 7+ messages in thread
* [UPDATE][PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c 2013-01-31 10:03 ` Daniel Vetter @ 2013-02-01 0:50 ` Yasuaki Ishimatsu 2013-02-01 0:53 ` Yasuaki Ishimatsu 0 siblings, 1 reply; 7+ messages in thread From: Yasuaki Ishimatsu @ 2013-02-01 0:50 UTC (permalink / raw) To: daniel Cc: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg, Yinghai Lu, Toshi Kani, dri-devel 2013/01/31 19:03, Daniel Vetter wrote: > On Thu, Jan 31, 2013 at 12:27:26PM +0900, Yasuaki Ishimatsu wrote: >> I forgot to change subject. So I resend a patch. >> >> --- >> acpi_bus_get_device() returns int not acpi_status. >> >> The patch change not to apply ACPI_FAILURE() to the return value of >> acpi_bus_get_device(). >> >> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> > > I've tried to apply this to drm-intel-next-queued, but git am didn't > really like your patch - it failed to apply. Can you please rebase to the > drm-intel-next-queued branch from > > git://people.freedesktop.org/~danvet/drm-intel > > and please resubmit the patch, preferrably formatted with git > format-patch? My mailer added a space in the patch. I updated the patch. How abot it? --- acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_FAILURE() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> --- drivers/gpu/drm/i915/intel_opregion.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c index 7741c22..4d33874 100644 --- a/drivers/gpu/drm/i915/intel_opregion.c +++ b/drivers/gpu/drm/i915/intel_opregion.c @@ -347,7 +347,7 @@ static void intel_didl_outputs(struct drm_device *dev) int i = 0; handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev); - if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) + if (!handle || acpi_bus_get_device(handle, &acpi_dev)) return; if (acpi_is_video_device(acpi_dev)) ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [UPDATE][PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c 2013-02-01 0:50 ` [UPDATE][PATCH " Yasuaki Ishimatsu @ 2013-02-01 0:53 ` Yasuaki Ishimatsu 2013-02-01 1:14 ` Yasuaki Ishimatsu 0 siblings, 1 reply; 7+ messages in thread From: Yasuaki Ishimatsu @ 2013-02-01 0:53 UTC (permalink / raw) To: daniel Cc: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg, Yinghai Lu, Toshi Kani, dri-devel 2013/02/01 9:50, Yasuaki Ishimatsu wrote: > 2013/01/31 19:03, Daniel Vetter wrote: >> On Thu, Jan 31, 2013 at 12:27:26PM +0900, Yasuaki Ishimatsu wrote: >>> I forgot to change subject. So I resend a patch. >>> >>> --- >>> acpi_bus_get_device() returns int not acpi_status. >>> >>> The patch change not to apply ACPI_FAILURE() to the return value of >>> acpi_bus_get_device(). >>> >>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> >> >> I've tried to apply this to drm-intel-next-queued, but git am didn't >> really like your patch - it failed to apply. Can you please rebase to the >> drm-intel-next-queued branch from >> >> git://people.freedesktop.org/~danvet/drm-intel >> >> and please resubmit the patch, preferrably formatted with git >> format-patch? > > My mailer added a space in the patch. I updated the patch. > How abot it? > > --- > acpi_bus_get_device() returns int not acpi_status. > > The patch change not to apply ACPI_FAILURE() to the return value of > acpi_bus_get_device(). > > Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> > --- > drivers/gpu/drm/i915/intel_opregion.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c > index 7741c22..4d33874 100644 > --- a/drivers/gpu/drm/i915/intel_opregion.c > +++ b/drivers/gpu/drm/i915/intel_opregion.c > @@ -347,7 +347,7 @@ static void intel_didl_outputs(struct drm_device *dev) > int i = 0; > > handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev); > - if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) > + if (!handle || acpi_bus_get_device(handle, &acpi_dev)) > return; > > if (acpi_is_video_device(acpi_dev)) > Oops. My mailer added a space again... I'll check my mailer again. Thanks, Yasuaki Ishimatsu > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [UPDATE][PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c 2013-02-01 0:53 ` Yasuaki Ishimatsu @ 2013-02-01 1:14 ` Yasuaki Ishimatsu 2013-02-01 10:03 ` Daniel Vetter 0 siblings, 1 reply; 7+ messages in thread From: Yasuaki Ishimatsu @ 2013-02-01 1:14 UTC (permalink / raw) To: daniel Cc: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg, Yinghai Lu, Toshi Kani, dri-devel [-- Attachment #1: Type: text/plain, Size: 2509 bytes --] 2013/02/01 9:53, Yasuaki Ishimatsu wrote: > 2013/02/01 9:50, Yasuaki Ishimatsu wrote: >> 2013/01/31 19:03, Daniel Vetter wrote: >>> On Thu, Jan 31, 2013 at 12:27:26PM +0900, Yasuaki Ishimatsu wrote: >>>> I forgot to change subject. So I resend a patch. >>>> >>>> --- >>>> acpi_bus_get_device() returns int not acpi_status. >>>> >>>> The patch change not to apply ACPI_FAILURE() to the return value of >>>> acpi_bus_get_device(). >>>> >>>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> >>> >>> I've tried to apply this to drm-intel-next-queued, but git am didn't >>> really like your patch - it failed to apply. Can you please rebase to the >>> drm-intel-next-queued branch from >>> >>> git://people.freedesktop.org/~danvet/drm-intel >>> >>> and please resubmit the patch, preferrably formatted with git >>> format-patch? >> >> My mailer added a space in the patch. I updated the patch. >> How abot it? >> >> --- >> acpi_bus_get_device() returns int not acpi_status. >> >> The patch change not to apply ACPI_FAILURE() to the return value of >> acpi_bus_get_device(). >> >> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> >> --- >> drivers/gpu/drm/i915/intel_opregion.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c >> index 7741c22..4d33874 100644 >> --- a/drivers/gpu/drm/i915/intel_opregion.c >> +++ b/drivers/gpu/drm/i915/intel_opregion.c >> @@ -347,7 +347,7 @@ static void intel_didl_outputs(struct drm_device *dev) >> int i = 0; >> >> handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev); >> - if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) >> + if (!handle || acpi_bus_get_device(handle, &acpi_dev)) >> return; >> >> if (acpi_is_video_device(acpi_dev)) >> > > Oops. My mailer added a space again... > I'll check my mailer again. I do not understand why space was added to the patch. So I attached the patch. Please check it. Thanks, Yasuaki Ishimatsu > > Thanks, > Yasuaki Ishimatsu > >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [-- Attachment #2: 0001-RESEND-PATCH-4-4-GPU-i915-Fix-acpi_bus_get_device-ch.patch --] [-- Type: text/x-patch, Size: 841 bytes --] acpi_bus_get_device() returns int not acpi_status. The patch change not to apply ACPI_FAILURE() to the return value of acpi_bus_get_device(). Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> --- drivers/gpu/drm/i915/intel_opregion.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c index 7741c22..4d33874 100644 --- a/drivers/gpu/drm/i915/intel_opregion.c +++ b/drivers/gpu/drm/i915/intel_opregion.c @@ -347,7 +347,7 @@ static void intel_didl_outputs(struct drm_device *dev) int i = 0; handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev); - if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) + if (!handle || acpi_bus_get_device(handle, &acpi_dev)) return; if (acpi_is_video_device(acpi_dev)) ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [UPDATE][PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c 2013-02-01 1:14 ` Yasuaki Ishimatsu @ 2013-02-01 10:03 ` Daniel Vetter 0 siblings, 0 replies; 7+ messages in thread From: Daniel Vetter @ 2013-02-01 10:03 UTC (permalink / raw) To: Yasuaki Ishimatsu Cc: daniel, Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg, Yinghai Lu, Toshi Kani, dri-devel On Fri, Feb 01, 2013 at 10:14:20AM +0900, Yasuaki Ishimatsu wrote: > 2013/02/01 9:53, Yasuaki Ishimatsu wrote: > >2013/02/01 9:50, Yasuaki Ishimatsu wrote: > >>2013/01/31 19:03, Daniel Vetter wrote: > >>>On Thu, Jan 31, 2013 at 12:27:26PM +0900, Yasuaki Ishimatsu wrote: > >>>>I forgot to change subject. So I resend a patch. > >>>> > >>>>--- > >>>>acpi_bus_get_device() returns int not acpi_status. > >>>> > >>>>The patch change not to apply ACPI_FAILURE() to the return value of > >>>>acpi_bus_get_device(). > >>>> > >>>>Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> > >>> > >>>I've tried to apply this to drm-intel-next-queued, but git am didn't > >>>really like your patch - it failed to apply. Can you please rebase to the > >>>drm-intel-next-queued branch from > >>> > >>>git://people.freedesktop.org/~danvet/drm-intel > >>> > >>>and please resubmit the patch, preferrably formatted with git > >>>format-patch? > >> > >>My mailer added a space in the patch. I updated the patch. > >>How abot it? > >> > >>--- > >>acpi_bus_get_device() returns int not acpi_status. > >> > >>The patch change not to apply ACPI_FAILURE() to the return value of > >>acpi_bus_get_device(). > >> > >>Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> > >>--- > >> drivers/gpu/drm/i915/intel_opregion.c | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >>diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c > >>index 7741c22..4d33874 100644 > >>--- a/drivers/gpu/drm/i915/intel_opregion.c > >>+++ b/drivers/gpu/drm/i915/intel_opregion.c > >>@@ -347,7 +347,7 @@ static void intel_didl_outputs(struct drm_device *dev) > >> int i = 0; > >> > >> handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev); > >>- if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) > >>+ if (!handle || acpi_bus_get_device(handle, &acpi_dev)) > >> return; > >> > >> if (acpi_is_video_device(acpi_dev)) > >> > > > >Oops. My mailer added a space again... > >I'll check my mailer again. > > I do not understand why space was added to the patch. > So I attached the patch. Please check it. Yeah, worked this time. Queued for -next, thanks for the patch. -Daniel > > Thanks, > Yasuaki Ishimatsu > > > > >Thanks, > >Yasuaki Ishimatsu > > > >>-- > >>To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > >>the body of a message to majordomo@vger.kernel.org > >>More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > > >-- > >To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > >the body of a message to majordomo@vger.kernel.org > >More majordomo info at http://vger.kernel.org/majordomo-info.html > > acpi_bus_get_device() returns int not acpi_status. > > The patch change not to apply ACPI_FAILURE() to the return value of > acpi_bus_get_device(). > > Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> > --- > drivers/gpu/drm/i915/intel_opregion.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c > index 7741c22..4d33874 100644 > --- a/drivers/gpu/drm/i915/intel_opregion.c > +++ b/drivers/gpu/drm/i915/intel_opregion.c > @@ -347,7 +347,7 @@ static void intel_didl_outputs(struct drm_device *dev) > int i = 0; > > handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev); > - if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) > + if (!handle || acpi_bus_get_device(handle, &acpi_dev)) > return; > > if (acpi_is_video_device(acpi_dev)) > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-02-01 10:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1451967.YMyGeCCNtu@vostro.rjw.lan>
[not found] ` <6099377.PFvsxPeyib@vostro.rjw.lan>
[not found] ` <5109E11A.5030400@jp.fujitsu.com>
2013-01-31 3:19 ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
2013-01-31 3:27 ` [RESEND PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c Yasuaki Ishimatsu
2013-01-31 10:03 ` Daniel Vetter
2013-02-01 0:50 ` [UPDATE][PATCH " Yasuaki Ishimatsu
2013-02-01 0:53 ` Yasuaki Ishimatsu
2013-02-01 1:14 ` Yasuaki Ishimatsu
2013-02-01 10:03 ` Daniel Vetter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).