[PATCH] drm/panel: hx83121a: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T

[PATCH] drm/panel: hx83121a: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T

[Julian Braha]

Currently, DRM_PANEL_ILITEK_ILI9882T selects DRM_DISPLAY_DSC_HELPER
without ensuring DRM_DISPLAY_HELPER is also enabled, causing an unmet
dependency and build failure.

Other similar options select DRM_DISPLAY_HELPER, let's do the same here.

This unmet dependency bug was found by kconfirm, a static analysis tool
for Kconfig.

Fixes: defab7b01e08 ("drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER")
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/gpu/drm/panel/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 06bfcef35a72..103f1d09a989 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -375,6 +375,7 @@ config DRM_PANEL_ILITEK_ILI9882T
 	depends on OF
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_HELPER
 	select DRM_DISPLAY_DSC_HELPER
 	help
 	  Say Y if you want to enable support for panels based on the
-- 
2.54.0

Re: [PATCH] drm/panel: hx83121a: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit title and Fixes tag incorrectly refer to the Himax hx83121a panel, while the patch actually modifies the Ilitek ILI9882T panel.
--

--- Patch [1]: [PATCH] drm/panel: hx83121a: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T ---
commit e60d5f1c009ee5f39be0116d8f60dc041fbf06fb
Author: Julian Braha <julianbraha@gmail.com>

drm/panel: hx83121a: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T

This commit resolves an unmet dependency by selecting DRM_DISPLAY_HELPER
for the ILI9882T panel.

> drm/panel: hx83121a: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T

[Severity: Medium]
Is there a mismatch between the commit message and the actual code changes?

The subject line refers to the Himax hx83121a panel, while the patch actually
modifies the Kconfig entry for the Ilitek ILI9882T panel.

[ ... ]

> Fixes: defab7b01e08 ("drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER")

[Severity: Medium]
Does this Fixes tag point to the correct commit?

The tag references the hx83121a panel instead of the ILI9882T panel that is
being updated in the diff below.

> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -374,6 +374,7 @@ config DRM_PANEL_ILITEK_ILI9882T
>  	depends on OF
>  	depends on DRM_MIPI_DSI
>  	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_DISPLAY_HELPER
>  	select DRM_DISPLAY_DSC_HELPER
>  	help

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260712000823.2315810-1-julianbraha@gmail.com?part=1

Re: [PATCH] drm/panel: hx83121a: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T

[Julian Braha]

On 7/12/26 01:08, Julian Braha wrote:
> Currently, DRM_PANEL_ILITEK_ILI9882T selects DRM_DISPLAY_DSC_HELPER
> without ensuring DRM_DISPLAY_HELPER is also enabled, causing an unmet
> dependency and build failure.
> 
> Other similar options select DRM_DISPLAY_HELPER, let's do the same here.
> 
> This unmet dependency bug was found by kconfirm, a static analysis tool
> for Kconfig.
> 
> Fixes: defab7b01e08 ("drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER")
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
>  drivers/gpu/drm/panel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 06bfcef35a72..103f1d09a989 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -375,6 +375,7 @@ config DRM_PANEL_ILITEK_ILI9882T
>  	depends on OF
>  	depends on DRM_MIPI_DSI
>  	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_DISPLAY_HELPER
>  	select DRM_DISPLAY_DSC_HELPER
>  	help
>  	  Say Y if you want to enable support for panels based on the

Sorry all, made a silly mistake here and blamed the wrong commit (same
mistake in commit title).

Sent v2:
https://lore.kernel.org/all/20260712002632.2323484-1-julianbraha@gmail.com/

- Julian Braha