From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Gustavo Padovan <gustavo@padovan.org>, linux-samsung-soc@vger.kernel.org
Cc: "Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
dri-devel@lists.freedesktop.org,
"\"'대인기/Mobile S/W Platform Lab.(통신연)/E3(사원)/삼성전자'\""
<inki.dae@samsung.com>
Subject: Re: [PATCH 1/6] drm/exynos: remove leftover code using event_list
Date: Fri, 30 Jan 2015 11:21:54 +0900 [thread overview]
Message-ID: <54CAEAC2.50709@samsung.com> (raw)
In-Reply-To: <1422016980-23806-1-git-send-email-gustavo@padovan.org>
+Cc Inki,
Hi,
On 01/23/2015 09:42 PM, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> The drm_file event_list hasn't been used anymore by exynos, so we don't
> need any code to clean it.
>
No, it is used from drm core e.g. drm_irq.c file.
Thanks.
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> ---
> drivers/gpu/drm/exynos/exynos_drm_drv.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index 25ba362..b60fd9b 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -256,11 +256,6 @@ static void exynos_drm_postclose(struct drm_device *dev, struct drm_file *file)
> }
> }
>
> - /* Release all events handled by page flip handler but not freed. */
> - list_for_each_entry_safe(e, et, &file->event_list, link) {
> - list_del(&e->link);
> - e->destroy(e);
> - }
> spin_unlock_irqrestore(&dev->event_lock, flags);
>
> kfree(file->driver_priv);
>
next prev parent reply other threads:[~2015-01-30 2:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 12:42 [PATCH 1/6] drm/exynos: remove leftover code using event_list Gustavo Padovan
2015-01-23 12:42 ` [PATCH 2/6] drm/exynos: track vblank events on a per crtc basis Gustavo Padovan
2015-01-27 12:59 ` Daniel Stone
2015-01-27 13:02 ` Daniel Vetter
2015-01-29 17:10 ` [PATCH -v2] " Gustavo Padovan
2015-01-30 2:44 ` Joonyoung Shim
2015-01-30 14:30 ` Gustavo Padovan
2015-01-30 15:57 ` Daniel Stone
2015-01-30 16:08 ` Daniel Vetter
2015-01-30 17:17 ` Gustavo Padovan
2015-02-02 5:38 ` Joonyoung Shim
2015-01-23 12:42 ` [PATCH 3/6] drm/exynos: Remove exynos_plane_dpms() call with no effect Gustavo Padovan
2015-01-30 2:12 ` Joonyoung Shim
2015-01-30 14:36 ` Gustavo Padovan
2015-02-02 4:32 ` Joonyoung Shim
2015-01-23 12:42 ` [PATCH 4/6] drm/exynos: remove leftover functions declarations Gustavo Padovan
2015-01-30 2:48 ` Joonyoung Shim
2015-01-23 12:42 ` [PATCH 5/6] drm/exynos: remove struct *_win_data abstraction on planes Gustavo Padovan
2015-01-30 4:32 ` Joonyoung Shim
2015-01-30 14:42 ` Gustavo Padovan
2015-02-02 4:53 ` Joonyoung Shim
2015-01-23 12:43 ` [PATCH 6/6] drm/exynos: do not copy adjusted mode into mode during crtc mode_set Gustavo Padovan
2015-01-30 4:53 ` Joonyoung Shim
2015-01-30 14:44 ` Gustavo Padovan
2015-02-02 4:55 ` Joonyoung Shim
2015-02-03 14:16 ` Gustavo Padovan
2015-02-04 2:10 ` Joonyoung Shim
2015-01-30 2:21 ` Joonyoung Shim [this message]
2015-01-30 13:37 ` [PATCH 1/6] drm/exynos: remove leftover code using event_list Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CAEAC2.50709@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=gustavo@padovan.org \
--cc=inki.dae@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox