Re: [PATCH 3/6] drm/exynos: Remove exynos_plane_dpms() call with no effect

[Joonyoung Shim <jy0922.shim@samsung.com>]

On 01/30/2015 11:36 PM, Gustavo Padovan wrote:
> 2015-01-30 Joonyoung Shim <jy0922.shim@samsung.com>:
> 
>> +Cc Inki,
>>
>> Hi,
>>
>> On 01/23/2015 09:42 PM, Gustavo Padovan wrote:
>>> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>>
>>> exynos_plane_dpms(DRM_MODE_DPMS_ON) calls the win_enable()'s callback
>>> from the underlying layer. However neither one of these layers implement
>>> win_enable() - FIMD, Mixer and VIDI. Thus the call to exynos_plane_dpms()
>>> is pointless.
>>>

Yes, this can be useful in api aspect later.

>>
>> No, it needs for pair with DRM_MODE_DPMS_OFF case.
> 
> It is a stub call. exynos_plane_dpms(DRM_MODE_DPMS_ON) only calls
> exynos_crtc->ops->win_enable() however neither FIMD, VIDI or Mixer implements
> win_enable(). So it has no effect and we can remove this call safely.
> 

No, we can stop to set duplication by enabled flag of struct
exynos_drm_plane, that's why keep fair. Currently the plane is not
disabled actually when disable the plane after setplane without below
link patch.

http://www.spinics.net/lists/dri-devel/msg76143.html

Thanks.