* Re: [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE
[not found] ` <20210716061634.2446357-2-hch@lst.de>
@ 2021-07-16 7:14 ` Christian König
2021-07-20 13:50 ` Daniel Vetter
0 siblings, 1 reply; 5+ messages in thread
From: Christian König @ 2021-07-16 7:14 UTC (permalink / raw)
To: Christoph Hellwig, David Airlie, Daniel Vetter
Cc: kvm, amd-gfx, nouveau, dri-devel, Pan, Xinhui, Alex Williamson,
Thomas Zimmermann, Rodrigo Vivi, Alex Deucher, intel-gfx,
Ben Skeggs
Am 16.07.21 um 08:16 schrieb Christoph Hellwig:
> The define is entirely unused.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
I'm not an expert for this particular code, but at least of hand
everything you do here makes totally sense.
Whole series is Acked-by: Christian König <christian.koenig@amd.com>
Regards,
Christian.
> ---
> include/linux/vgaarb.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h
> index dc6ddce92066..26ec8a057d2a 100644
> --- a/include/linux/vgaarb.h
> +++ b/include/linux/vgaarb.h
> @@ -42,12 +42,6 @@
> #define VGA_RSRC_NORMAL_IO 0x04
> #define VGA_RSRC_NORMAL_MEM 0x08
>
> -/* Passing that instead of a pci_dev to use the system "default"
> - * device, that is the one used by vgacon. Archs will probably
> - * have to provide their own vga_default_device();
> - */
> -#define VGA_DEFAULT_DEVICE (NULL)
> -
> struct pci_dev;
>
> /* For use by clients */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: misc vgaarb cleanups
[not found] <20210716061634.2446357-1-hch@lst.de>
[not found] ` <20210716061634.2446357-2-hch@lst.de>
@ 2021-07-16 11:40 ` Rodrigo Vivi
1 sibling, 0 replies; 5+ messages in thread
From: Rodrigo Vivi @ 2021-07-16 11:40 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Thomas Zimmermann, kvm, David Airlie, nouveau, dri-devel,
Pan, Xinhui, Alex Williamson, Alex Deucher, amd-gfx, intel-gfx,
Christian König, Ben Skeggs
On Fri, Jul 16, 2021 at 08:16:27AM +0200, Christoph Hellwig wrote:
> Hi all,
>
> this series cleans up a bunch of lose ends in the vgaarb code.
>
> Diffstat:
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 11 +-
> drivers/gpu/drm/drm_irq.c | 4
> drivers/gpu/drm/i915/display/intel_vga.c | 9 +-
The parts touching i915 looks clean to me
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> drivers/gpu/drm/nouveau/nouveau_vga.c | 8 -
> drivers/gpu/drm/radeon/radeon_device.c | 11 +-
> drivers/gpu/vga/vgaarb.c | 67 +++++-----------
> drivers/vfio/pci/vfio_pci.c | 11 +-
> include/linux/vgaarb.h | 118 ++++++++++-------------------
> 8 files changed, 93 insertions(+), 146 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE
2021-07-16 7:14 ` [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE Christian König
@ 2021-07-20 13:50 ` Daniel Vetter
2021-07-20 14:12 ` Christian König
2021-07-21 8:30 ` Christian König
0 siblings, 2 replies; 5+ messages in thread
From: Daniel Vetter @ 2021-07-20 13:50 UTC (permalink / raw)
To: Christian König
Cc: Thomas Zimmermann, kvm, David Airlie, nouveau, dri-devel,
Pan, Xinhui, Alex Williamson, Rodrigo Vivi, Alex Deucher, amd-gfx,
intel-gfx, Christoph Hellwig, Ben Skeggs
On Fri, Jul 16, 2021 at 09:14:02AM +0200, Christian König wrote:
> Am 16.07.21 um 08:16 schrieb Christoph Hellwig:
> > The define is entirely unused.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> I'm not an expert for this particular code, but at least of hand everything
> you do here makes totally sense.
>
> Whole series is Acked-by: Christian König <christian.koenig@amd.com>
Care to also push this into drm-misc-next since you looked already?
-Daniel
>
> Regards,
> Christian.
>
> > ---
> > include/linux/vgaarb.h | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h
> > index dc6ddce92066..26ec8a057d2a 100644
> > --- a/include/linux/vgaarb.h
> > +++ b/include/linux/vgaarb.h
> > @@ -42,12 +42,6 @@
> > #define VGA_RSRC_NORMAL_IO 0x04
> > #define VGA_RSRC_NORMAL_MEM 0x08
> > -/* Passing that instead of a pci_dev to use the system "default"
> > - * device, that is the one used by vgacon. Archs will probably
> > - * have to provide their own vga_default_device();
> > - */
> > -#define VGA_DEFAULT_DEVICE (NULL)
> > -
> > struct pci_dev;
> > /* For use by clients */
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE
2021-07-20 13:50 ` Daniel Vetter
@ 2021-07-20 14:12 ` Christian König
2021-07-21 8:30 ` Christian König
1 sibling, 0 replies; 5+ messages in thread
From: Christian König @ 2021-07-20 14:12 UTC (permalink / raw)
To: Daniel Vetter
Cc: kvm, David Airlie, nouveau, dri-devel, Pan, Xinhui,
Alex Williamson, Thomas Zimmermann, Rodrigo Vivi, Alex Deucher,
amd-gfx, intel-gfx, Christoph Hellwig, Ben Skeggs
Am 20.07.21 um 15:50 schrieb Daniel Vetter:
> On Fri, Jul 16, 2021 at 09:14:02AM +0200, Christian König wrote:
>> Am 16.07.21 um 08:16 schrieb Christoph Hellwig:
>>> The define is entirely unused.
>>>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> I'm not an expert for this particular code, but at least of hand everything
>> you do here makes totally sense.
>>
>> Whole series is Acked-by: Christian König <christian.koenig@amd.com>
> Care to also push this into drm-misc-next since you looked already?
Sure, but Christoph doesn't has push access himself?
Christian.
> -Daniel
>
>> Regards,
>> Christian.
>>
>>> ---
>>> include/linux/vgaarb.h | 6 ------
>>> 1 file changed, 6 deletions(-)
>>>
>>> diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h
>>> index dc6ddce92066..26ec8a057d2a 100644
>>> --- a/include/linux/vgaarb.h
>>> +++ b/include/linux/vgaarb.h
>>> @@ -42,12 +42,6 @@
>>> #define VGA_RSRC_NORMAL_IO 0x04
>>> #define VGA_RSRC_NORMAL_MEM 0x08
>>> -/* Passing that instead of a pci_dev to use the system "default"
>>> - * device, that is the one used by vgacon. Archs will probably
>>> - * have to provide their own vga_default_device();
>>> - */
>>> -#define VGA_DEFAULT_DEVICE (NULL)
>>> -
>>> struct pci_dev;
>>> /* For use by clients */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE
2021-07-20 13:50 ` Daniel Vetter
2021-07-20 14:12 ` Christian König
@ 2021-07-21 8:30 ` Christian König
1 sibling, 0 replies; 5+ messages in thread
From: Christian König @ 2021-07-21 8:30 UTC (permalink / raw)
To: Daniel Vetter, Christian König
Cc: Pan, Xinhui, kvm, David Airlie, nouveau, intel-gfx, dri-devel,
Alex Williamson, Thomas Zimmermann, Rodrigo Vivi, Alex Deucher,
amd-gfx, Christoph Hellwig, Ben Skeggs
Am 20.07.21 um 15:50 schrieb Daniel Vetter:
> On Fri, Jul 16, 2021 at 09:14:02AM +0200, Christian König wrote:
>> Am 16.07.21 um 08:16 schrieb Christoph Hellwig:
>>> The define is entirely unused.
>>>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>> I'm not an expert for this particular code, but at least of hand everything
>> you do here makes totally sense.
>>
>> Whole series is Acked-by: Christian König <christian.koenig@amd.com>
> Care to also push this into drm-misc-next since you looked already?
Done.
Christian.
> -Daniel
>
>> Regards,
>> Christian.
>>
>>> ---
>>> include/linux/vgaarb.h | 6 ------
>>> 1 file changed, 6 deletions(-)
>>>
>>> diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h
>>> index dc6ddce92066..26ec8a057d2a 100644
>>> --- a/include/linux/vgaarb.h
>>> +++ b/include/linux/vgaarb.h
>>> @@ -42,12 +42,6 @@
>>> #define VGA_RSRC_NORMAL_IO 0x04
>>> #define VGA_RSRC_NORMAL_MEM 0x08
>>> -/* Passing that instead of a pci_dev to use the system "default"
>>> - * device, that is the one used by vgacon. Archs will probably
>>> - * have to provide their own vga_default_device();
>>> - */
>>> -#define VGA_DEFAULT_DEVICE (NULL)
>>> -
>>> struct pci_dev;
>>> /* For use by clients */
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-07-21 8:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210716061634.2446357-1-hch@lst.de>
[not found] ` <20210716061634.2446357-2-hch@lst.de>
2021-07-16 7:14 ` [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE Christian König
2021-07-20 13:50 ` Daniel Vetter
2021-07-20 14:12 ` Christian König
2021-07-21 8:30 ` Christian König
2021-07-16 11:40 ` misc vgaarb cleanups Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox