Re: [PATCH] drm: Set connector DPMS status to ON in drm_crtc_helper_set_config

Re: [PATCH] drm: Set connector DPMS status to ON in drm_crtc_helper_set_config

[Chris Wilson]

Daniel, this is patch you were looking for earlier wrt to screen blanking.

On Tue, 16 Nov 2010 11:10:46 +0800, keithp@keithp.com wrote:
> From: Keith Packard <keithp@keithp.com>
> 
> When setting a new crtc configuration, force the DPMS state of all
> connectors to ON. Otherwise, they'll be left at OFF and a future mode set
> that disables the specified connector will not turn the connector off.
> 
> Signed-off-by: Keith Packard <keithp@keithp.com>

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

> ---
>  drivers/gpu/drm/drm_crtc_helper.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
> index dcbeb98..7804c3d 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -471,6 +471,7 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set)
>  	int count = 0, ro, fail = 0;
>  	struct drm_crtc_helper_funcs *crtc_funcs;
>  	int ret = 0;
> +	int i;
>  
>  	DRM_DEBUG_KMS("\n");
>  
> @@ -666,6 +667,12 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set)
>  		if (ret != 0)
>  			goto fail;
>  	}
> +	DRM_DEBUG_KMS("Setting connector DPMS state to on\n");
> +	for (i = 0; i < set->num_connectors; i++) {
> +		DRM_DEBUG_KMS("\t[CONNECTOR:%d:%s] set DPMS on\n", set->connectors[i]->base.id,
> +			      drm_get_connector_name(set->connectors[i]));
> +		set->connectors[i]->dpms = DRM_MODE_DPMS_ON;
> +	}
>  
>  	kfree(save_connectors);
>  	kfree(save_encoders);
> -- 
> 1.7.2.3
> 

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: [PATCH] drm: Set connector DPMS status to ON in drm_crtc_helper_set_config

[Chris Wilson]

Ah, having seen the bounce when replying, I now know why Dave didn't see
these...

I've pushed the two patches to
git://people.freedesktop.org/~ickle/linux-2.6 for-airlied
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre