From: Eric Anholt <eric@anholt.net>
To: Daniel Stone <daniel@fooishbar.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 8/9] drm/vc4: Add support for async pageflips.
Date: Thu, 03 Dec 2015 17:42:41 -0800 [thread overview]
Message-ID: <87d1ungfam.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <CAPj87rN30D951JCi-JY9aONNmxFvo=gX2Sq1NohJg1jRs7AFhQ@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 693 bytes --]
Daniel Stone <daniel@fooishbar.org> writes:
> Hi,
>
> On 1 December 2015 at 20:35, Eric Anholt <eric@anholt.net> wrote:
>> An async pageflip stores the modeset to be done and executes it once
>> the BOs are ready to be displayed. This gets us about 3x performance
>> in full screen rendering with pageflipping.
>
> Looks good, but you're missing a preclose callback to reap dead events, a la:
> https://git.collabora.com/cgit/user/daniels/linux.git/commit/?h=wip/4.4.x/rockchip-drm-fixes&id=d14f21bcd7e7a1b9ca129c411a9da9c911037965
>
> (and parent commit to wire that through to core DRM preclose)
We've already got a preclose callback that reaps crtc->event -- see
vc4_cancel_page_flip().
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-12-04 1:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 20:35 [PATCH 1/9] drm: Create a driver hook for allocating GEM object structs Eric Anholt
2015-12-01 20:35 ` [PATCH 2/9] drm/vc4: Add a BO cache Eric Anholt
2015-12-01 20:35 ` [PATCH 3/9] drm/vc4: Add create and map BO ioctls Eric Anholt
2015-12-04 14:29 ` Emil Velikov
2015-12-08 1:16 ` Eric Anholt
2015-12-08 2:56 ` Michel Dänzer
2015-12-08 4:05 ` Eric Anholt
2015-12-01 20:35 ` [PATCH 4/9] drm/vc4: Add an API for creating GPU shaders in GEM BOs Eric Anholt
2015-12-02 11:35 ` Emil Velikov
2015-12-02 19:24 ` Eric Anholt
2015-12-01 20:35 ` [PATCH 5/9] drm/vc4: Fix a typo in a V3D debug register Eric Anholt
2015-12-01 20:35 ` [PATCH 6/9] drm/vc4: Bind and initialize the V3D engine Eric Anholt
2015-12-01 20:35 ` [PATCH 7/9] drm/vc4: Add support for drawing 3D frames Eric Anholt
2015-12-02 11:29 ` Emil Velikov
2015-12-02 19:27 ` Eric Anholt
2015-12-01 20:35 ` [PATCH 8/9] drm/vc4: Add support for async pageflips Eric Anholt
2015-12-02 14:05 ` Daniel Stone
2015-12-04 1:42 ` Eric Anholt [this message]
2015-12-07 10:13 ` Daniel Stone
2015-12-01 20:35 ` [PATCH 9/9] drm/vc4: Add an interface for capturing the GPU state after a hang Eric Anholt
2015-12-02 11:45 ` Emil Velikov
2015-12-02 19:35 ` Eric Anholt
2015-12-02 22:26 ` Daniel Vetter
2015-12-02 22:58 ` Daniel Stone
2015-12-03 11:55 ` Emil Velikov
2015-12-03 11:46 ` Emil Velikov
2015-12-02 8:58 ` [PATCH 1/9] drm: Create a driver hook for allocating GEM object structs Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1ungfam.fsf@eliezer.anholt.net \
--to=eric@anholt.net \
--cc=daniel@fooishbar.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox