* [PATCH] drm: logicvc: fix error code in logicvc_layer_init()
@ 2022-06-14 12:08 Dan Carpenter
2022-06-24 14:35 ` Paul Kocialkowski
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2022-06-14 12:08 UTC (permalink / raw)
To: Paul Kocialkowski; +Cc: David Airlie, dri-devel, kernel-janitors
Return -EINVAL if logicvc_layer_formats_lookup() fails. Don't return
success.
Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/gpu/drm/logicvc/logicvc_layer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
index bae1c7f99569..9c94b67afbed 100644
--- a/drivers/gpu/drm/logicvc/logicvc_layer.c
+++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
@@ -489,6 +489,7 @@ static int logicvc_layer_init(struct logicvc_drm *logicvc,
if (!formats) {
drm_err(drm_dev, "Failed to lookup formats for layer #%d\n",
index);
+ ret = -EINVAL;
goto error;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm: logicvc: fix error code in logicvc_layer_init()
2022-06-14 12:08 [PATCH] drm: logicvc: fix error code in logicvc_layer_init() Dan Carpenter
@ 2022-06-24 14:35 ` Paul Kocialkowski
2022-06-24 15:25 ` Paul Kocialkowski
0 siblings, 1 reply; 3+ messages in thread
From: Paul Kocialkowski @ 2022-06-24 14:35 UTC (permalink / raw)
To: Dan Carpenter; +Cc: David Airlie, dri-devel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1064 bytes --]
Hi,
On Tue 14 Jun 22, 15:08, Dan Carpenter wrote:
> Return -EINVAL if logicvc_layer_formats_lookup() fails. Don't return
> success.
>
> Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for the fix!
Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Paul
> ---
> drivers/gpu/drm/logicvc/logicvc_layer.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
> index bae1c7f99569..9c94b67afbed 100644
> --- a/drivers/gpu/drm/logicvc/logicvc_layer.c
> +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
> @@ -489,6 +489,7 @@ static int logicvc_layer_init(struct logicvc_drm *logicvc,
> if (!formats) {
> drm_err(drm_dev, "Failed to lookup formats for layer #%d\n",
> index);
> + ret = -EINVAL;
> goto error;
> }
>
> --
> 2.35.1
>
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: logicvc: fix error code in logicvc_layer_init()
2022-06-24 14:35 ` Paul Kocialkowski
@ 2022-06-24 15:25 ` Paul Kocialkowski
0 siblings, 0 replies; 3+ messages in thread
From: Paul Kocialkowski @ 2022-06-24 15:25 UTC (permalink / raw)
To: Dan Carpenter; +Cc: David Airlie, dri-devel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]
Hi,
On Fri 24 Jun 22, 16:35, Paul Kocialkowski wrote:
> Hi,
>
> On Tue 14 Jun 22, 15:08, Dan Carpenter wrote:
> > Return -EINVAL if logicvc_layer_formats_lookup() fails. Don't return
> > success.
> >
> > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thanks for the fix!
>
> Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Pushed to drm-misc-next, thanks!
Paul
> > ---
> > drivers/gpu/drm/logicvc/logicvc_layer.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
> > index bae1c7f99569..9c94b67afbed 100644
> > --- a/drivers/gpu/drm/logicvc/logicvc_layer.c
> > +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
> > @@ -489,6 +489,7 @@ static int logicvc_layer_init(struct logicvc_drm *logicvc,
> > if (!formats) {
> > drm_err(drm_dev, "Failed to lookup formats for layer #%d\n",
> > index);
> > + ret = -EINVAL;
> > goto error;
> > }
> >
> > --
> > 2.35.1
> >
>
> --
> Paul Kocialkowski, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-24 15:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-14 12:08 [PATCH] drm: logicvc: fix error code in logicvc_layer_init() Dan Carpenter
2022-06-24 14:35 ` Paul Kocialkowski
2022-06-24 15:25 ` Paul Kocialkowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).