* Re: [PATCH libdrm] drm: fix return value [not found] <20180116025401.18906-1-david1.zhou@amd.com> @ 2018-01-16 8:49 ` Michel Dänzer 2018-01-16 8:56 ` Christian König 0 siblings, 1 reply; 11+ messages in thread From: Michel Dänzer @ 2018-01-16 8:49 UTC (permalink / raw) To: Chunming Zhou; +Cc: dri-devel, Seth.Zhu Moving from the amd-gfx list to dri-devel, since this isn't amdgpu specific. On 2018-01-16 03:54 AM, Chunming Zhou wrote: > otherwise -ETIME is missed. > > Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423 > Signed-off-by: Chunming Zhou <david1.zhou@amd.com> > --- > xf86drm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xf86drm.c b/xf86drm.c > index 8a327170..3881bd9f 100644 > --- a/xf86drm.c > +++ b/xf86drm.c > @@ -4241,7 +4241,7 @@ int drmSyncobjWait(int fd, uint32_t *handles, unsigned num_handles, > > ret = drmIoctl(fd, DRM_IOCTL_SYNCOBJ_WAIT, &args); > if (ret < 0) > - return ret; > + return -errno; > > if (first_signaled) > *first_signaled = args.first_signaled; > -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH libdrm] drm: fix return value 2018-01-16 8:49 ` [PATCH libdrm] drm: fix return value Michel Dänzer @ 2018-01-16 8:56 ` Christian König 2018-01-16 14:01 ` Zhou, David(ChunMing) 0 siblings, 1 reply; 11+ messages in thread From: Christian König @ 2018-01-16 8:56 UTC (permalink / raw) To: Michel Dänzer, Chunming Zhou; +Cc: Seth.Zhu, dri-devel Apart from that a good catch and Reviewed-by: Christian König <christian.koenig@amd.com>. Regards, Christian. Am 16.01.2018 um 09:49 schrieb Michel Dänzer: > Moving from the amd-gfx list to dri-devel, since this isn't amdgpu specific. > > > On 2018-01-16 03:54 AM, Chunming Zhou wrote: >> otherwise -ETIME is missed. >> >> Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423 >> Signed-off-by: Chunming Zhou <david1.zhou@amd.com> >> --- >> xf86drm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xf86drm.c b/xf86drm.c >> index 8a327170..3881bd9f 100644 >> --- a/xf86drm.c >> +++ b/xf86drm.c >> @@ -4241,7 +4241,7 @@ int drmSyncobjWait(int fd, uint32_t *handles, unsigned num_handles, >> >> ret = drmIoctl(fd, DRM_IOCTL_SYNCOBJ_WAIT, &args); >> if (ret < 0) >> - return ret; >> + return -errno; >> >> if (first_signaled) >> *first_signaled = args.first_signaled; >> > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH libdrm] drm: fix return value 2018-01-16 8:56 ` Christian König @ 2018-01-16 14:01 ` Zhou, David(ChunMing) 2018-01-17 8:21 ` Daniel Vetter 0 siblings, 1 reply; 11+ messages in thread From: Zhou, David(ChunMing) @ 2018-01-16 14:01 UTC (permalink / raw) To: Koenig, Christian Cc: Michel D鋘zer, dri-devel@lists.freedesktop.org, Zhu, Seth [-- Attachment #1.1: Type: text/plain, Size: 1261 bytes --] Can your guys help me push it and last vamgr patches to upstream? My new count request for libdrm still is under pending. Thanks, David Zhou 发自坚果 Pro Christian K鰊ig <ckoenig.leichtzumerken@gmail.com> 于 2018年1月16日 下午4:56写道： Apart from that a good catch and Reviewed-by: Christian König <christian.koenig@amd.com>. Regards, Christian. Am 16.01.2018 um 09:49 schrieb Michel Dänzer: > Moving from the amd-gfx list to dri-devel, since this isn't amdgpu specific. > > > On 2018-01-16 03:54 AM, Chunming Zhou wrote: >> otherwise -ETIME is missed. >> >> Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423 >> Signed-off-by: Chunming Zhou <david1.zhou@amd.com> >> --- >> xf86drm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xf86drm.c b/xf86drm.c >> index 8a327170..3881bd9f 100644 >> --- a/xf86drm.c >> +++ b/xf86drm.c >> @@ -4241,7 +4241,7 @@ int drmSyncobjWait(int fd, uint32_t *handles, unsigned num_handles, >> >> ret = drmIoctl(fd, DRM_IOCTL_SYNCOBJ_WAIT, &args); >> if (ret < 0) >> - return ret; >> + return -errno; >> >> if (first_signaled) >> *first_signaled = args.first_signaled; >> > [-- Attachment #1.2: Type: text/html, Size: 3241 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH libdrm] drm: fix return value 2018-01-16 14:01 ` Zhou, David(ChunMing) @ 2018-01-17 8:21 ` Daniel Vetter 2018-01-17 8:53 ` Chunming Zhou 0 siblings, 1 reply; 11+ messages in thread From: Daniel Vetter @ 2018-01-17 8:21 UTC (permalink / raw) To: Zhou, David(ChunMing) Cc: Michel D鋘zer, Koenig, Christian, dri-devel@lists.freedesktop.org, Zhu, Seth On Tue, Jan 16, 2018 at 02:01:40PM +0000, Zhou, David(ChunMing) wrote: > Can your guys help me push it and last vamgr patches to upstream? > My new count request for libdrm still is under pending. Or hand out commmit rights? That's easier long-term imo ... -Daniel > > Thanks, > David Zhou > > > 发自坚果 Pro > > Christian K鰊ig <ckoenig.leichtzumerken@gmail.com> 于 2018年1月16日 下午4:56写道： > > Apart from that a good catch and Reviewed-by: Christian König > <christian.koenig@amd.com>. > > Regards, > Christian. > > Am 16.01.2018 um 09:49 schrieb Michel Dänzer: > > Moving from the amd-gfx list to dri-devel, since this isn't amdgpu specific. > > > > > > On 2018-01-16 03:54 AM, Chunming Zhou wrote: > >> otherwise -ETIME is missed. > >> > >> Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423 > >> Signed-off-by: Chunming Zhou <david1.zhou@amd.com> > >> --- > >> xf86drm.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/xf86drm.c b/xf86drm.c > >> index 8a327170..3881bd9f 100644 > >> --- a/xf86drm.c > >> +++ b/xf86drm.c > >> @@ -4241,7 +4241,7 @@ int drmSyncobjWait(int fd, uint32_t *handles, unsigned num_handles, > >> > >> ret = drmIoctl(fd, DRM_IOCTL_SYNCOBJ_WAIT, &args); > >> if (ret < 0) > >> - return ret; > >> + return -errno; > >> > >> if (first_signaled) > >> *first_signaled = args.first_signaled; > >> > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH libdrm] drm: fix return value 2018-01-17 8:21 ` Daniel Vetter @ 2018-01-17 8:53 ` Chunming Zhou 2018-01-17 9:24 ` Christian König 0 siblings, 1 reply; 11+ messages in thread From: Chunming Zhou @ 2018-01-17 8:53 UTC (permalink / raw) To: Daniel Vetter, Zhou, David(ChunMing) Cc: Michel D鋘zer, Koenig, Christian, dri-devel@lists.freedesktop.org, Zhu, Seth On 2018年01月17日 16:21, Daniel Vetter wrote: > On Tue, Jan 16, 2018 at 02:01:40PM +0000, Zhou, David(ChunMing) wrote: >> Can your guys help me push it and last vamgr patches to upstream? >> My new count request for libdrm still is under pending. > Or hand out commmit rights? That's easier long-term imo ... That's not true, we need to track the commit for driver release, if we have no permission to push it, we often need to check the patch status to see if it's already in there. Are you admin for count request? if you are, and approve my count request, I greatly appreciate your approval. Regards, David Zhou > -Daniel > >> Thanks, >> David Zhou >> >> >> 发自坚果 Pro >> >> Christian K鰊ig <ckoenig.leichtzumerken@gmail.com> 于 2018年1月16日 下午4:56写道： >> >> Apart from that a good catch and Reviewed-by: Christian König >> <christian.koenig@amd.com>. >> >> Regards, >> Christian. >> >> Am 16.01.2018 um 09:49 schrieb Michel Dänzer: >>> Moving from the amd-gfx list to dri-devel, since this isn't amdgpu specific. >>> >>> >>> On 2018-01-16 03:54 AM, Chunming Zhou wrote: >>>> otherwise -ETIME is missed. >>>> >>>> Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423 >>>> Signed-off-by: Chunming Zhou <david1.zhou@amd.com> >>>> --- >>>> xf86drm.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/xf86drm.c b/xf86drm.c >>>> index 8a327170..3881bd9f 100644 >>>> --- a/xf86drm.c >>>> +++ b/xf86drm.c >>>> @@ -4241,7 +4241,7 @@ int drmSyncobjWait(int fd, uint32_t *handles, unsigned num_handles, >>>> >>>> ret = drmIoctl(fd, DRM_IOCTL_SYNCOBJ_WAIT, &args); >>>> if (ret < 0) >>>> - return ret; >>>> + return -errno; >>>> >>>> if (first_signaled) >>>> *first_signaled = args.first_signaled; >>>> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH libdrm] drm: fix return value 2018-01-17 8:53 ` Chunming Zhou @ 2018-01-17 9:24 ` Christian König 2018-01-17 9:26 ` Chunming Zhou 0 siblings, 1 reply; 11+ messages in thread From: Christian König @ 2018-01-17 9:24 UTC (permalink / raw) To: Chunming Zhou, Daniel Vetter, Zhou, David(ChunMing) Cc: Michel D鋘zer, Koenig, Christian, dri-devel@lists.freedesktop.org, Zhu, Seth Am 17.01.2018 um 09:53 schrieb Chunming Zhou: > > > On 2018年01月17日 16:21, Daniel Vetter wrote: >> On Tue, Jan 16, 2018 at 02:01:40PM +0000, Zhou, David(ChunMing) wrote: >>> Can your guys help me push it and last vamgr patches to upstream? >>> My new count request for libdrm still is under pending. >> Or hand out commmit rights? That's easier long-term imo ... > That's not true, we need to track the commit for driver release, if we > have no permission to push it, we often need to check the patch status > to see if it's already in there. > Are you admin for count request? if you are, and approve my count > request, I greatly appreciate your approval. David, sounds like a misunderstanding. What Daniel suggested was that you should get commit rights, so that you can commit it yourself :) But that's actually what we are already trying to do. It's just that the account request seems to take a while. If Alex hasn't already forwarded the request to the Admins please post the link once more and I or Daniel can take care of it. Regards, Christian. > > Regards, > David Zhou >> -Daniel >> >>> Thanks, >>> David Zhou >>> >>> >>> 发自坚果 Pro >>> >>> Christian K鰊ig <ckoenig.leichtzumerken@gmail.com> 于 2018年1月16日 >>> 下午4:56写道： >>> >>> Apart from that a good catch and Reviewed-by: Christian König >>> <christian.koenig@amd.com>. >>> >>> Regards, >>> Christian. >>> >>> Am 16.01.2018 um 09:49 schrieb Michel Dänzer: >>>> Moving from the amd-gfx list to dri-devel, since this isn't amdgpu >>>> specific. >>>> >>>> >>>> On 2018-01-16 03:54 AM, Chunming Zhou wrote: >>>>> otherwise -ETIME is missed. >>>>> >>>>> Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423 >>>>> Signed-off-by: Chunming Zhou <david1.zhou@amd.com> >>>>> --- >>>>> xf86drm.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/xf86drm.c b/xf86drm.c >>>>> index 8a327170..3881bd9f 100644 >>>>> --- a/xf86drm.c >>>>> +++ b/xf86drm.c >>>>> @@ -4241,7 +4241,7 @@ int drmSyncobjWait(int fd, uint32_t >>>>> *handles, unsigned num_handles, >>>>> >>>>> ret = drmIoctl(fd, DRM_IOCTL_SYNCOBJ_WAIT, &args); >>>>> if (ret < 0) >>>>> - return ret; >>>>> + return -errno; >>>>> >>>>> if (first_signaled) >>>>> *first_signaled = args.first_signaled; >>>>> >>> _______________________________________________ >>> dri-devel mailing list >>> dri-devel@lists.freedesktop.org >>> https://lists.freedesktop.org/mailman/listinfo/dri-devel >> > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH libdrm] drm: fix return value 2018-01-17 9:24 ` Christian König @ 2018-01-17 9:26 ` Chunming Zhou 2018-01-17 9:31 ` Daniel Vetter 0 siblings, 1 reply; 11+ messages in thread From: Chunming Zhou @ 2018-01-17 9:26 UTC (permalink / raw) To: christian.koenig, Daniel Vetter, Zhou, David(ChunMing) Cc: Michel D鋘zer, Zhu, Seth, dri-devel@lists.freedesktop.org On 2018年01月17日 17:24, Christian König wrote: > Am 17.01.2018 um 09:53 schrieb Chunming Zhou: >> >> >> On 2018年01月17日 16:21, Daniel Vetter wrote: >>> On Tue, Jan 16, 2018 at 02:01:40PM +0000, Zhou, David(ChunMing) wrote: >>>> Can your guys help me push it and last vamgr patches to upstream? >>>> My new count request for libdrm still is under pending. >>> Or hand out commmit rights? That's easier long-term imo ... >> That's not true, we need to track the commit for driver release, if >> we have no permission to push it, we often need to check the patch >> status to see if it's already in there. >> Are you admin for count request? if you are, and approve my count >> request, I greatly appreciate your approval. > > David, sounds like a misunderstanding. What Daniel suggested was that > you should get commit rights, so that you can commit it yourself :) > > But that's actually what we are already trying to do. It's just that > the account request seems to take a while. > > If Alex hasn't already forwarded the request to the Admins please post > the link once more and I or Daniel can take care of it. https://bugs.freedesktop.org/show_bug.cgi?id=104631 Michel and Alex have committed. Thanks, David Zhou > > Regards, > Christian. > >> >> Regards, >> David Zhou >>> -Daniel >>> >>>> Thanks, >>>> David Zhou >>>> >>>> >>>> 发自坚果 Pro >>>> >>>> Christian K鰊ig <ckoenig.leichtzumerken@gmail.com> 于 2018年1月16日 >>>> 下午4:56写道： >>>> >>>> Apart from that a good catch and Reviewed-by: Christian König >>>> <christian.koenig@amd.com>. >>>> >>>> Regards, >>>> Christian. >>>> >>>> Am 16.01.2018 um 09:49 schrieb Michel Dänzer: >>>>> Moving from the amd-gfx list to dri-devel, since this isn't amdgpu >>>>> specific. >>>>> >>>>> >>>>> On 2018-01-16 03:54 AM, Chunming Zhou wrote: >>>>>> otherwise -ETIME is missed. >>>>>> >>>>>> Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423 >>>>>> Signed-off-by: Chunming Zhou <david1.zhou@amd.com> >>>>>> --- >>>>>> xf86drm.c | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/xf86drm.c b/xf86drm.c >>>>>> index 8a327170..3881bd9f 100644 >>>>>> --- a/xf86drm.c >>>>>> +++ b/xf86drm.c >>>>>> @@ -4241,7 +4241,7 @@ int drmSyncobjWait(int fd, uint32_t >>>>>> *handles, unsigned num_handles, >>>>>> >>>>>> ret = drmIoctl(fd, DRM_IOCTL_SYNCOBJ_WAIT, &args); >>>>>> if (ret < 0) >>>>>> - return ret; >>>>>> + return -errno; >>>>>> >>>>>> if (first_signaled) >>>>>> *first_signaled = args.first_signaled; >>>>>> >>>> _______________________________________________ >>>> dri-devel mailing list >>>> dri-devel@lists.freedesktop.org >>>> https://lists.freedesktop.org/mailman/listinfo/dri-devel >>> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH libdrm] drm: fix return value 2018-01-17 9:26 ` Chunming Zhou @ 2018-01-17 9:31 ` Daniel Vetter 2018-01-31 2:49 ` Chunming Zhou 0 siblings, 1 reply; 11+ messages in thread From: Daniel Vetter @ 2018-01-17 9:31 UTC (permalink / raw) To: Chunming Zhou Cc: Michel D鋘zer, dri-devel@lists.freedesktop.org, Zhu, Seth, christian.koenig On Wed, Jan 17, 2018 at 05:26:41PM +0800, Chunming Zhou wrote: > > > On 2018年01月17日 17:24, Christian König wrote: > > Am 17.01.2018 um 09:53 schrieb Chunming Zhou: > > > > > > > > > On 2018年01月17日 16:21, Daniel Vetter wrote: > > > > On Tue, Jan 16, 2018 at 02:01:40PM +0000, Zhou, David(ChunMing) wrote: > > > > > Can your guys help me push it and last vamgr patches to upstream? > > > > > My new count request for libdrm still is under pending. > > > > Or hand out commmit rights? That's easier long-term imo ... > > > That's not true, we need to track the commit for driver release, if > > > we have no permission to push it, we often need to check the patch > > > status to see if it's already in there. > > > Are you admin for count request? if you are, and approve my count > > > request, I greatly appreciate your approval. > > > > David, sounds like a misunderstanding. What Daniel suggested was that > > you should get commit rights, so that you can commit it yourself :) > > > > But that's actually what we are already trying to do. It's just that the > > account request seems to take a while. > > > > If Alex hasn't already forwarded the request to the Admins please post > > the link once more and I or Daniel can take care of it. > https://bugs.freedesktop.org/show_bug.cgi?id=104631 > Michel and Alex have committed. fd.o admins are drowning a bit under meltdown/spectre (and there's apparently a pile more serious exploits that need to be patched asap). I'd ping them next week on #freedesktop if it hasn't happened by then. -Daniel > > Thanks, > David Zhou > > > > Regards, > > Christian. > > > > > > > > Regards, > > > David Zhou > > > > -Daniel > > > > > > > > > Thanks, > > > > > David Zhou > > > > > > > > > > > > > > > 发自坚果 Pro > > > > > > > > > > Christian K鰊ig <ckoenig.leichtzumerken@gmail.com> 于 > > > > > 2018年1月16日 下午4:56写道： > > > > > > > > > > Apart from that a good catch and Reviewed-by: Christian König > > > > > <christian.koenig@amd.com>. > > > > > > > > > > Regards, > > > > > Christian. > > > > > > > > > > Am 16.01.2018 um 09:49 schrieb Michel Dänzer: > > > > > > Moving from the amd-gfx list to dri-devel, since this > > > > > > isn't amdgpu specific. > > > > > > > > > > > > > > > > > > On 2018-01-16 03:54 AM, Chunming Zhou wrote: > > > > > > > otherwise -ETIME is missed. > > > > > > > > > > > > > > Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423 > > > > > > > Signed-off-by: Chunming Zhou <david1.zhou@amd.com> > > > > > > > --- > > > > > > > xf86drm.c | 2 +- > > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git a/xf86drm.c b/xf86drm.c > > > > > > > index 8a327170..3881bd9f 100644 > > > > > > > --- a/xf86drm.c > > > > > > > +++ b/xf86drm.c > > > > > > > @@ -4241,7 +4241,7 @@ int drmSyncobjWait(int fd, > > > > > > > uint32_t *handles, unsigned num_handles, > > > > > > > > > > > > > > ret = drmIoctl(fd, DRM_IOCTL_SYNCOBJ_WAIT, &args); > > > > > > > if (ret < 0) > > > > > > > - return ret; > > > > > > > + return -errno; > > > > > > > > > > > > > > if (first_signaled) > > > > > > > *first_signaled = args.first_signaled; > > > > > > > > > > > > _______________________________________________ > > > > > dri-devel mailing list > > > > > dri-devel@lists.freedesktop.org > > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH libdrm] drm: fix return value 2018-01-17 9:31 ` Daniel Vetter @ 2018-01-31 2:49 ` Chunming Zhou 2018-01-31 8:09 ` Daniel Vetter 0 siblings, 1 reply; 11+ messages in thread From: Chunming Zhou @ 2018-01-31 2:49 UTC (permalink / raw) To: Daniel Vetter Cc: Michel D鋘zer, christian.koenig, dri-devel@lists.freedesktop.org, Zhu, Seth On 2018年01月17日 17:31, Daniel Vetter wrote: > On Wed, Jan 17, 2018 at 05:26:41PM +0800, Chunming Zhou wrote: >> >> On 2018年01月17日 17:24, Christian König wrote: >>> Am 17.01.2018 um 09:53 schrieb Chunming Zhou: >>>> >>>> On 2018年01月17日 16:21, Daniel Vetter wrote: >>>>> On Tue, Jan 16, 2018 at 02:01:40PM +0000, Zhou, David(ChunMing) wrote: >>>>>> Can your guys help me push it and last vamgr patches to upstream? >>>>>> My new count request for libdrm still is under pending. >>>>> Or hand out commmit rights? That's easier long-term imo ... >>>> That's not true, we need to track the commit for driver release, if >>>> we have no permission to push it, we often need to check the patch >>>> status to see if it's already in there. >>>> Are you admin for count request? if you are, and approve my count >>>> request, I greatly appreciate your approval. >>> David, sounds like a misunderstanding. What Daniel suggested was that >>> you should get commit rights, so that you can commit it yourself :) >>> >>> But that's actually what we are already trying to do. It's just that the >>> account request seems to take a while. >>> >>> If Alex hasn't already forwarded the request to the Admins please post >>> the link once more and I or Daniel can take care of it. >> https://bugs.freedesktop.org/show_bug.cgi?id=104631 >> Michel and Alex have committed. > fd.o admins are drowning a bit under meltdown/spectre (and there's > apparently a pile more serious exploits that need to be patched asap). > > I'd ping them next week on #freedesktop if it hasn't happened by then. Hi Daniel, My account requesting still is under pending, Could you help it? https://bugs.freedesktop.org/show_bug.cgi?id=104631 Thanks in advance, David Zhou > -Daniel > >> Thanks, >> David Zhou >>> Regards, >>> Christian. >>> >>>> Regards, >>>> David Zhou >>>>> -Daniel >>>>> >>>>>> Thanks, >>>>>> David Zhou >>>>>> >>>>>> >>>>>> 发自坚果 Pro >>>>>> >>>>>> Christian K鰊ig <ckoenig.leichtzumerken@gmail.com> 于 >>>>>> 2018年1月16日 下午4:56写道： >>>>>> >>>>>> Apart from that a good catch and Reviewed-by: Christian König >>>>>> <christian.koenig@amd.com>. >>>>>> >>>>>> Regards, >>>>>> Christian. >>>>>> >>>>>> Am 16.01.2018 um 09:49 schrieb Michel Dänzer: >>>>>>> Moving from the amd-gfx list to dri-devel, since this >>>>>>> isn't amdgpu specific. >>>>>>> >>>>>>> >>>>>>> On 2018-01-16 03:54 AM, Chunming Zhou wrote: >>>>>>>> otherwise -ETIME is missed. >>>>>>>> >>>>>>>> Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423 >>>>>>>> Signed-off-by: Chunming Zhou <david1.zhou@amd.com> >>>>>>>> --- >>>>>>>> xf86drm.c | 2 +- >>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>>> >>>>>>>> diff --git a/xf86drm.c b/xf86drm.c >>>>>>>> index 8a327170..3881bd9f 100644 >>>>>>>> --- a/xf86drm.c >>>>>>>> +++ b/xf86drm.c >>>>>>>> @@ -4241,7 +4241,7 @@ int drmSyncobjWait(int fd, >>>>>>>> uint32_t *handles, unsigned num_handles, >>>>>>>> >>>>>>>> ret = drmIoctl(fd, DRM_IOCTL_SYNCOBJ_WAIT, &args); >>>>>>>> if (ret < 0) >>>>>>>> - return ret; >>>>>>>> + return -errno; >>>>>>>> >>>>>>>> if (first_signaled) >>>>>>>> *first_signaled = args.first_signaled; >>>>>>>> >>>>>> _______________________________________________ >>>>>> dri-devel mailing list >>>>>> dri-devel@lists.freedesktop.org >>>>>> https://lists.freedesktop.org/mailman/listinfo/dri-devel >>>> _______________________________________________ >>>> dri-devel mailing list >>>> dri-devel@lists.freedesktop.org >>>> https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH libdrm] drm: fix return value 2018-01-31 2:49 ` Chunming Zhou @ 2018-01-31 8:09 ` Daniel Vetter 0 siblings, 0 replies; 11+ messages in thread From: Daniel Vetter @ 2018-01-31 8:09 UTC (permalink / raw) To: Chunming Zhou Cc: Michel D鋘zer, dri-devel@lists.freedesktop.org, Zhu, Seth, christian.koenig On Wed, Jan 31, 2018 at 10:49:47AM +0800, Chunming Zhou wrote: > > > On 2018年01月17日 17:31, Daniel Vetter wrote: > > On Wed, Jan 17, 2018 at 05:26:41PM +0800, Chunming Zhou wrote: > > > > > > On 2018年01月17日 17:24, Christian König wrote: > > > > Am 17.01.2018 um 09:53 schrieb Chunming Zhou: > > > > > > > > > > On 2018年01月17日 16:21, Daniel Vetter wrote: > > > > > > On Tue, Jan 16, 2018 at 02:01:40PM +0000, Zhou, David(ChunMing) wrote: > > > > > > > Can your guys help me push it and last vamgr patches to upstream? > > > > > > > My new count request for libdrm still is under pending. > > > > > > Or hand out commmit rights? That's easier long-term imo ... > > > > > That's not true, we need to track the commit for driver release, if > > > > > we have no permission to push it, we often need to check the patch > > > > > status to see if it's already in there. > > > > > Are you admin for count request? if you are, and approve my count > > > > > request, I greatly appreciate your approval. > > > > David, sounds like a misunderstanding. What Daniel suggested was that > > > > you should get commit rights, so that you can commit it yourself :) > > > > > > > > But that's actually what we are already trying to do. It's just that the > > > > account request seems to take a while. > > > > > > > > If Alex hasn't already forwarded the request to the Admins please post > > > > the link once more and I or Daniel can take care of it. > > > https://bugs.freedesktop.org/show_bug.cgi?id=104631 > > > Michel and Alex have committed. > > fd.o admins are drowning a bit under meltdown/spectre (and there's > > apparently a pile more serious exploits that need to be patched asap). > > > > I'd ping them next week on #freedesktop if it hasn't happened by then. > Hi Daniel, > > My account requesting still is under pending, Could you help it? > https://bugs.freedesktop.org/show_bug.cgi?id=104631 Looks all ready for fd.o admins to take action. Perhaps ping them on #freedesktop irc channel? I'm not an admin myself. -Daniel > > > Thanks in advance, > David Zhou > > -Daniel > > > > > Thanks, > > > David Zhou > > > > Regards, > > > > Christian. > > > > > > > > > Regards, > > > > > David Zhou > > > > > > -Daniel > > > > > > > > > > > > > Thanks, > > > > > > > David Zhou > > > > > > > > > > > > > > > > > > > > > 发自坚果 Pro > > > > > > > > > > > > > > Christian K鰊ig <ckoenig.leichtzumerken@gmail.com> 于 > > > > > > > 2018年1月16日 下午4:56写道： > > > > > > > > > > > > > > Apart from that a good catch and Reviewed-by: Christian König > > > > > > > <christian.koenig@amd.com>. > > > > > > > > > > > > > > Regards, > > > > > > > Christian. > > > > > > > > > > > > > > Am 16.01.2018 um 09:49 schrieb Michel Dänzer: > > > > > > > > Moving from the amd-gfx list to dri-devel, since this > > > > > > > > isn't amdgpu specific. > > > > > > > > > > > > > > > > > > > > > > > > On 2018-01-16 03:54 AM, Chunming Zhou wrote: > > > > > > > > > otherwise -ETIME is missed. > > > > > > > > > > > > > > > > > > Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423 > > > > > > > > > Signed-off-by: Chunming Zhou <david1.zhou@amd.com> > > > > > > > > > --- > > > > > > > > > xf86drm.c | 2 +- > > > > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > > > > > > > diff --git a/xf86drm.c b/xf86drm.c > > > > > > > > > index 8a327170..3881bd9f 100644 > > > > > > > > > --- a/xf86drm.c > > > > > > > > > +++ b/xf86drm.c > > > > > > > > > @@ -4241,7 +4241,7 @@ int drmSyncobjWait(int fd, > > > > > > > > > uint32_t *handles, unsigned num_handles, > > > > > > > > > > > > > > > > > > ret = drmIoctl(fd, DRM_IOCTL_SYNCOBJ_WAIT, &args); > > > > > > > > > if (ret < 0) > > > > > > > > > - return ret; > > > > > > > > > + return -errno; > > > > > > > > > > > > > > > > > > if (first_signaled) > > > > > > > > > *first_signaled = args.first_signaled; > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > dri-devel mailing list > > > > > > > dri-devel@lists.freedesktop.org > > > > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > > _______________________________________________ > > > > > dri-devel mailing list > > > > > dri-devel@lists.freedesktop.org > > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH libdrm] drm: fix return value @ 2018-01-16 2:54 Chunming Zhou 0 siblings, 0 replies; 11+ messages in thread From: Chunming Zhou @ 2018-01-16 2:54 UTC (permalink / raw) To: dri-devel; +Cc: Seth.Zhu otherwise -ETIME is missed. Change-Id: Ic5580a74d8027cc468c6135f8cf2f81817993423 Signed-off-by: Chunming Zhou <david1.zhou@amd.com> --- xf86drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xf86drm.c b/xf86drm.c index 8a327170..3881bd9f 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -4241,7 +4241,7 @@ int drmSyncobjWait(int fd, uint32_t *handles, unsigned num_handles, ret = drmIoctl(fd, DRM_IOCTL_SYNCOBJ_WAIT, &args); if (ret < 0) - return ret; + return -errno; if (first_signaled) *first_signaled = args.first_signaled; -- 2.14.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-01-31 8:09 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180116025401.18906-1-david1.zhou@amd.com>
2018-01-16 8:49 ` [PATCH libdrm] drm: fix return value Michel Dänzer
2018-01-16 8:56 ` Christian König
2018-01-16 14:01 ` Zhou, David(ChunMing)
2018-01-17 8:21 ` Daniel Vetter
2018-01-17 8:53 ` Chunming Zhou
2018-01-17 9:24 ` Christian König
2018-01-17 9:26 ` Chunming Zhou
2018-01-17 9:31 ` Daniel Vetter
2018-01-31 2:49 ` Chunming Zhou
2018-01-31 8:09 ` Daniel Vetter
2018-01-16 2:54 Chunming Zhou
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox