[PATCH] drm/ttm: remove ttm_bo_unmap_virtual_locked declaration

[PATCH] drm/ttm: remove ttm_bo_unmap_virtual_locked declaration

[Christian König]

That was missed during the cleanup.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 include/drm/ttm/ttm_bo_driver.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
index 9897a16c0a9d..b58dedce7079 100644
--- a/include/drm/ttm/ttm_bo_driver.h
+++ b/include/drm/ttm/ttm_bo_driver.h
@@ -449,15 +449,6 @@ int ttm_bo_device_init(struct ttm_bo_device *bdev,
  */
 void ttm_bo_unmap_virtual(struct ttm_buffer_object *bo);
 
-/**
- * ttm_bo_unmap_virtual
- *
- * @bo: tear down the virtual mappings for this BO
- *
- * The caller must take ttm_mem_io_lock before calling this function.
- */
-void ttm_bo_unmap_virtual_locked(struct ttm_buffer_object *bo);
-
 /**
  * ttm_bo_reserve:
  *
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [PATCH] drm/ttm: remove ttm_bo_unmap_virtual_locked declaration

[Ruhl, Michael J]

>-----Original Message-----
>From: Christian König <ckoenig.leichtzumerken@gmail.com>
>Sent: Wednesday, October 7, 2020 4:52 AM
>To: dri-devel@lists.freedesktop.org; airlied@gmail.com;
>ray.huang@amd.com; Ruhl, Michael J <michael.j.ruhl@intel.com>
>Subject: [PATCH] drm/ttm: remove ttm_bo_unmap_virtual_locked
>declaration
>
>That was missed during the cleanup.
>
>Signed-off-by: Christian König <christian.koenig@amd.com>
>---
> include/drm/ttm/ttm_bo_driver.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
>diff --git a/include/drm/ttm/ttm_bo_driver.h
>b/include/drm/ttm/ttm_bo_driver.h
>index 9897a16c0a9d..b58dedce7079 100644
>--- a/include/drm/ttm/ttm_bo_driver.h
>+++ b/include/drm/ttm/ttm_bo_driver.h
>@@ -449,15 +449,6 @@ int ttm_bo_device_init(struct ttm_bo_device *bdev,
>  */
> void ttm_bo_unmap_virtual(struct ttm_buffer_object *bo);
>
>-/**
>- * ttm_bo_unmap_virtual
>- *
>- * @bo: tear down the virtual mappings for this BO
>- *
>- * The caller must take ttm_mem_io_lock before calling this function.
>- */
>-void ttm_bo_unmap_virtual_locked(struct ttm_buffer_object *bo);

greping for ttm_bo_unmap_virtual_locked revealed this:

drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c: * This is similar to ttm_bo_unmap_virtual_locked() except it takes a subrange.
include/drm/ttm/ttm_bo_driver.h:void ttm_bo_unmap_virtual_locked(struct ttm_buffer_object *bo);

Should you clean up the vmwgvx comment to avoid confusion? 😊

Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>

m

>-
> /**
>  * ttm_bo_reserve:
>  *
>--
>2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/ttm: remove ttm_bo_unmap_virtual_locked declaration

[Christian König]

Am 07.10.20 um 13:43 schrieb Ruhl, Michael J:
>> -----Original Message-----
>> From: Christian König <ckoenig.leichtzumerken@gmail.com>
>> Sent: Wednesday, October 7, 2020 4:52 AM
>> To: dri-devel@lists.freedesktop.org; airlied@gmail.com;
>> ray.huang@amd.com; Ruhl, Michael J <michael.j.ruhl@intel.com>
>> Subject: [PATCH] drm/ttm: remove ttm_bo_unmap_virtual_locked
>> declaration
>>
>> That was missed during the cleanup.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
>> ---
>> include/drm/ttm/ttm_bo_driver.h | 9 ---------
>> 1 file changed, 9 deletions(-)
>>
>> diff --git a/include/drm/ttm/ttm_bo_driver.h
>> b/include/drm/ttm/ttm_bo_driver.h
>> index 9897a16c0a9d..b58dedce7079 100644
>> --- a/include/drm/ttm/ttm_bo_driver.h
>> +++ b/include/drm/ttm/ttm_bo_driver.h
>> @@ -449,15 +449,6 @@ int ttm_bo_device_init(struct ttm_bo_device *bdev,
>>   */
>> void ttm_bo_unmap_virtual(struct ttm_buffer_object *bo);
>>
>> -/**
>> - * ttm_bo_unmap_virtual
>> - *
>> - * @bo: tear down the virtual mappings for this BO
>> - *
>> - * The caller must take ttm_mem_io_lock before calling this function.
>> - */
>> -void ttm_bo_unmap_virtual_locked(struct ttm_buffer_object *bo);
> greping for ttm_bo_unmap_virtual_locked revealed this:
>
> drivers/gpu/drm/vmwgfx/vmwgfx_page_dirty.c: * This is similar to ttm_bo_unmap_virtual_locked() except it takes a subrange.
> include/drm/ttm/ttm_bo_driver.h:void ttm_bo_unmap_virtual_locked(struct ttm_buffer_object *bo);
>
> Should you clean up the vmwgvx comment to avoid confusion? 😊

Oh good point, thanks. Didn't know that the function was referenced 
outside of TTM anywhere anymore.

Christian.

>
> Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
>
> m
>
>> -
>> /**
>>   * ttm_bo_reserve:
>>   *
>> --
>> 2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel