From: sashiko-bot@kernel.org
To: "Yongxing Mou" <yongxing.mou@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v9 11/29] drm/msm/dp: add msm_dp_display_get_panel() to initialize DP panel
Date: Thu, 19 Nov 2026 08:36:41 +0000 [thread overview]
Message-ID: <sashiko-outbox-222684@kernel.org> (raw)
In-Reply-To: <20261119-msm-dp-mst-v9-11-ca61be4edfc3@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] drm/msm/dp: uninitialized hw_revision in
msm_dp_display_get_panel()
- [Medium] drm/msm/dp: devm_kzalloc leak and panel desync in
msm_dp_display_get_panel()
--
commit 81d0774848cd7711009ffa760c18571f4cc9c705
Author: Abhinav Kumar <quic_abhinavk@quicinc.com>
drm/msm/dp: add msm_dp_display_get_panel() to initialize DP panel
This commit adds msm_dp_ctrl_get_stream_cnt() and msm_dp_display_get_panel()
to allocate and initialize per-stream struct msm_dp_panel instances for DP
MST.
> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
> index 544b76e2c6f6e..d3d798a1da1a9 100644
> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> @@ -536,6 +536,33 @@ static int msm_dp_irq_hpd_handle(struct msm_dp_display_private *dp)
> return rc;
> }
>
> +struct msm_dp_panel *msm_dp_display_get_panel(struct msm_dp *msm_dp_display,
> + enum msm_dp_stream_id stream_id)
> +{
> + struct msm_dp_display_private *dp;
> + struct msm_dp_panel *dp_panel;
> +
> + dp = container_of(msm_dp_display, struct msm_dp_display_private, msm_dp_display);
> +
> + if (stream_id >= msm_dp_ctrl_get_stream_cnt(dp->ctrl)) {
> + DRM_ERROR("invalid stream_id %d\n", stream_id);
> + return NULL;
> + }
> +
> + dp_panel = msm_dp_panel_get(&dp->msm_dp_display.pdev->dev, dp->aux, dp->link,
> + dp->link_base, dp->mst2link_base, dp->mst3link_base,
> + dp->pixel_base[stream_id]);
[Severity: Medium]
Does calling msm_dp_panel_get() here leak the devm_kzalloc() allocation on
&dp->msm_dp_display.pdev->dev across KMS component unbind/rebind or bind
failure?
msm_dp_panel_get() ties the allocation lifetime to the DP platform device,
whereas msm_dp_display_get_panel() is called during KMS component bind
(_dpu_kms_initialize_displayport() -> msm_dp_mst_attach_encoder()) with no
matching release when KMS unbinds. Allocating separate panel instances
(including a second DP_STREAM_0 panel alongside dp->panel) also leaves
dp->panel->msm_dp_mode.out_fmt_is_yuv_420 out of sync with active MST stream
panels when checked by msm_dp_wide_bus_available().
> +
> + if (IS_ERR(dp_panel)) {
> + DRM_ERROR("failed to initialize panel\n");
> + return NULL;
> + }
> +
> + dp_panel->stream_id = stream_id;
> +
> + return dp_panel;
> +}
[Severity: Medium]
Does this leave dp_panel->hw_revision set to 0 on panels returned for MST
streams?
msm_dp_ctrl_reset() only populates panel->hw_revision on the SST dp->panel
instance, and msm_dp_display_get_panel() runs during KMS bind before
msm_dp_display_host_init() reads REG_DP_HW_VERSION. When VSC SDP is enabled
or disabled on an MST stream (for example, YUV420 modes via
msm_dp_panel_timing_cfg() -> msm_dp_panel_setup_vsc_sdp_yuv_420()),
msm_dp_panel_update_sdp() checks:
drivers/gpu/drm/msm/dp/dp_panel.c:msm_dp_panel_update_sdp() {
u32 hw_revision = panel->msm_dp_panel.hw_revision;
if (hw_revision >= DP_HW_VERSION_1_0 &&
hw_revision < DP_HW_VERSION_1_2) {
msm_dp_write_link(panel, MMSS_DP_SDP_CFG3, UPDATE_SDP);
msm_dp_write_link(panel, MMSS_DP_SDP_CFG3, 0x0);
}
}
With hw_revision left at 0, the MMSS_DP_SDP_CFG3 update pulse is skipped on
DP 1.0 and 1.1 controllers.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-msm-dp-mst-v9-0-ca61be4edfc3@oss.qualcomm.com?part=11
next prev parent reply other threads:[~2026-11-19 8:36 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 8:24 [PATCH v9 00/29] drm/msm/dp: Add MST support for MSM chipsets Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 01/29] drm/msm/dp: skip sink requests while the mainlink clocks are off Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 02/29] drm/msm/dp: add support to send ACT packets for MST Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 03/29] drm/msm/dp: add support to enable MST in mainlink control Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 04/29] drm/msm/dp: no need to update tu calculation for mst Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 05/29] drm/msm/dp: always program MST_FIFO_CONSTANT_FILL for MST use cases Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 06/29] drm/msm/dp: add support for sending VCPF packets in DP controller Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 07/29] drm/msm/dp: add support for MST channel slot allocation Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 08/29] drm/msm/dp: replace power_on with active_stream_mask Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 09/29] drm/msm/dp: factor out _helper variants of bridge ops accepting a panel Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 10/29] drm/msm/dp: add link_ready to manage link-level operations Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 11/29] drm/msm/dp: add msm_dp_display_get_panel() to initialize DP panel Yongxing Mou
2026-11-19 8:36 ` sashiko-bot [this message]
2026-11-19 8:24 ` [PATCH v9 12/29] drm/msm/dp: introduce dp_mst_drm module Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 13/29] drm/msm/dp: add MST connector creation and topology callbacks Yongxing Mou
2026-11-19 8:49 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 14/29] drm/msm/dpu: pass msm_display_info to dpu_encoder_get_intf() Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 15/29] drm/msm/dpu: use stream_id to select MST interfaces Yongxing Mou
2026-11-19 8:35 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 16/29] drm/msm/dpu: add per-stream MST encoders Yongxing Mou
2026-11-19 8:51 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 17/29] drm/msm/dp: move link capabilities to dp_link Yongxing Mou
2026-11-19 8:41 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 18/29] drm/msm/dp: add atomic stream handling for MST Yongxing Mou
2026-11-19 9:01 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 19/29] drm/bridge_connector: suppress hotplug for IRQ_HPD without status changes Yongxing Mou
2026-11-19 9:01 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 20/29] drm/bridge_connector: avoid detect-based HPD notifications for DisplayPort Yongxing Mou
2026-11-19 8:45 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 21/29] drm/msm/dp: add HPD callback for dp MST Yongxing Mou
2026-11-19 8:50 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 22/29] drm/msm/dp: wire MST helpers into atomic check and commit paths Yongxing Mou
2026-11-19 8:46 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 23/29] drm/msm/dp: mark the SST bridge disconnected when mst is active Yongxing Mou
2026-11-19 8:46 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 24/29] drm/msm/dp: enable MST on capable sinks Yongxing Mou
2026-11-19 9:05 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 25/29] drm/msm/dp: mark the SST bridge disconnected when an MST-capable sink is present Yongxing Mou
2026-11-19 8:51 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 26/29] drm/msm/dp: wake threaded handler for HPD IRQs Yongxing Mou
2026-11-19 8:49 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 27/29] drm/msm/dp: ignore IRQ HPD latched together with an unplug Yongxing Mou
2026-11-19 8:24 ` [PATCH v9 28/29] drm/msm/dp: select MST stream bpp during atomic check Yongxing Mou
2026-11-19 8:50 ` sashiko-bot
2026-11-19 8:24 ` [PATCH v9 29/29] soc: qcom: pmic-glink-altmode: skip retimer reset on DP IRQ Yongxing Mou
2026-11-19 11:54 ` [PATCH v9 00/29] drm/msm/dp: Add MST support for MSM chipsets Joonhoe Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222684@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yongxing.mou@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox