dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yongxing Mou" <yongxing.mou@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v9 28/29] drm/msm/dp: select MST stream bpp during atomic check
Date: Thu, 19 Nov 2026 08:50:24 +0000	[thread overview]
Message-ID: <sashiko-outbox-222724@kernel.org> (raw)
In-Reply-To: <20261119-msm-dp-mst-v9-28-ca61be4edfc3@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/msm/dp: msm_dp_mst_select_bpp() ignores active link
  payloads
--

commit 3977050b668a1f08d8d9b23f6fc76eaf2a03455a
Author: Yongxing Mou <yongxing.mou@oss.qualcomm.com>

drm/msm/dp: select MST stream bpp during atomic check

This commit selects the MST stream bpp during atomic check by trying 30,
24, and 18 bpp against the port PBN and link time slots, storing the
result in a connector state subclass for commit.

> diff --git a/drivers/gpu/drm/msm/dp/dp_mst_drm.c b/drivers/gpu/drm/msm/dp/dp_mst_drm.c
> index 2b96e003225d5..a452b3d2ba228 100644
> --- a/drivers/gpu/drm/msm/dp/dp_mst_drm.c
> +++ b/drivers/gpu/drm/msm/dp/dp_mst_drm.c
[ ... ]
> @@ -142,6 +189,42 @@ static int msm_dp_mst_connector_atomic_check(struct drm_connector *connector,
>  	return drm_dp_atomic_release_time_slots(state, &mst->mst_mgr, mst_conn->mst_port);
>  }
>  
> +static int msm_dp_mst_select_bpp(struct drm_atomic_commit *state,
> +				 struct msm_dp_mst *mst,
> +				 const struct drm_dp_mst_topology_state *mst_state,
> +				 struct drm_dp_mst_port *port,
> +				 const struct drm_display_mode *mode,
> +				 u32 max_bpp, u32 *bpp)
> +{
> +	static const u32 bpps[] = { 30, 24, 18 };
> +	unsigned int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(bpps); i++) {
> +		int pbn, slots;
> +
> +		if (bpps[i] > max_bpp)
> +			continue;
> +
> +		pbn = drm_dp_calc_pbn_mode(mode->clock, bpps[i] << 4);
> +		if (pbn > port->full_pbn)
> +			continue;
> +
> +		slots = drm_dp_atomic_find_time_slots(state, &mst->mst_mgr, port, pbn);
> +		if (slots < 0)
> +			return slots;
> +
> +		if (slots <= mst_state->total_avail_slots) {
> +			drm_dbg_kms(mst->msm_dp->drm_dev,
> +				    "[MST] bpp=%u pbn=%d slots=%d\n",
> +				    bpps[i], pbn, slots);
> +			*bpp = bpps[i];
> +			return 0;
> +		}
> +	}
> +
> +	return -ENOSPC;
> +}

[Severity: Medium]
Does comparing slots against mst_state->total_avail_slots account for time
slots already used by other active streams on the link?

drm_dp_atomic_find_time_slots() returns only the slots required for this
port, while mst_state->total_avail_slots is the fixed 63-slot capacity of
the entire link and is not decremented as payloads are added to
mst_state->payloads.  When another stream is already active on the link,
msm_dp_mst_select_bpp() will pick 30 or 24 bpp as long as this stream
alone fits in 63 slots, even if the remaining unallocated slots only have
room for 24 or 18 bpp, causing drm_dp_mst_atomic_check() to fail the
modeset with -ENOSPC instead of stepping down to a lower bpp.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-msm-dp-mst-v9-0-ca61be4edfc3@oss.qualcomm.com?part=28

  reply	other threads:[~2026-11-19  8:50 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:24 [PATCH v9 00/29] drm/msm/dp: Add MST support for MSM chipsets Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 01/29] drm/msm/dp: skip sink requests while the mainlink clocks are off Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 02/29] drm/msm/dp: add support to send ACT packets for MST Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 03/29] drm/msm/dp: add support to enable MST in mainlink control Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 04/29] drm/msm/dp: no need to update tu calculation for mst Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 05/29] drm/msm/dp: always program MST_FIFO_CONSTANT_FILL for MST use cases Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 06/29] drm/msm/dp: add support for sending VCPF packets in DP controller Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 07/29] drm/msm/dp: add support for MST channel slot allocation Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 08/29] drm/msm/dp: replace power_on with active_stream_mask Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 09/29] drm/msm/dp: factor out _helper variants of bridge ops accepting a panel Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 10/29] drm/msm/dp: add link_ready to manage link-level operations Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 11/29] drm/msm/dp: add msm_dp_display_get_panel() to initialize DP panel Yongxing Mou
2026-11-19  8:36   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 12/29] drm/msm/dp: introduce dp_mst_drm module Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 13/29] drm/msm/dp: add MST connector creation and topology callbacks Yongxing Mou
2026-11-19  8:49   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 14/29] drm/msm/dpu: pass msm_display_info to dpu_encoder_get_intf() Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 15/29] drm/msm/dpu: use stream_id to select MST interfaces Yongxing Mou
2026-11-19  8:35   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 16/29] drm/msm/dpu: add per-stream MST encoders Yongxing Mou
2026-11-19  8:51   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 17/29] drm/msm/dp: move link capabilities to dp_link Yongxing Mou
2026-11-19  8:41   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 18/29] drm/msm/dp: add atomic stream handling for MST Yongxing Mou
2026-11-19  9:01   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 19/29] drm/bridge_connector: suppress hotplug for IRQ_HPD without status changes Yongxing Mou
2026-11-19  9:01   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 20/29] drm/bridge_connector: avoid detect-based HPD notifications for DisplayPort Yongxing Mou
2026-11-19  8:45   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 21/29] drm/msm/dp: add HPD callback for dp MST Yongxing Mou
2026-11-19  8:50   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 22/29] drm/msm/dp: wire MST helpers into atomic check and commit paths Yongxing Mou
2026-11-19  8:46   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 23/29] drm/msm/dp: mark the SST bridge disconnected when mst is active Yongxing Mou
2026-11-19  8:46   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 24/29] drm/msm/dp: enable MST on capable sinks Yongxing Mou
2026-11-19  9:05   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 25/29] drm/msm/dp: mark the SST bridge disconnected when an MST-capable sink is present Yongxing Mou
2026-11-19  8:51   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 26/29] drm/msm/dp: wake threaded handler for HPD IRQs Yongxing Mou
2026-11-19  8:49   ` sashiko-bot
2026-11-19  8:24 ` [PATCH v9 27/29] drm/msm/dp: ignore IRQ HPD latched together with an unplug Yongxing Mou
2026-11-19  8:24 ` [PATCH v9 28/29] drm/msm/dp: select MST stream bpp during atomic check Yongxing Mou
2026-11-19  8:50   ` sashiko-bot [this message]
2026-11-19  8:24 ` [PATCH v9 29/29] soc: qcom: pmic-glink-altmode: skip retimer reset on DP IRQ Yongxing Mou
2026-11-19 11:54 ` [PATCH v9 00/29] drm/msm/dp: Add MST support for MSM chipsets Joonhoe Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222724@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=yongxing.mou@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox