* [PATCH] ecryptfs: Drop cast
@ 2014-06-26 18:42 Himangi Saraogi
2014-06-26 18:58 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Himangi Saraogi @ 2014-06-26 18:42 UTC (permalink / raw)
To: Tyler Hicks, ecryptfs, linux-kernel; +Cc: julia.lawall
This patch does away with casts on void * as they are unnecessary.
The following Coccinelle semantic patch was used for making the change:
@r@
expression x;
void* e;
type T;
identifier f;
@@
(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
fs/ecryptfs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
index 4d6c7e4..5459792 100644
--- a/fs/ecryptfs/inode.c
+++ b/fs/ecryptfs/inode.c
@@ -53,7 +53,7 @@ static void unlock_dir(struct dentry *dir)
static int ecryptfs_inode_test(struct inode *inode, void *lower_inode)
{
- if (ecryptfs_inode_to_lower(inode) == (struct inode *)lower_inode)
+ if (ecryptfs_inode_to_lower(inode) == lower_inode)
return 1;
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ecryptfs: Drop cast
2014-06-26 18:42 [PATCH] ecryptfs: Drop cast Himangi Saraogi
@ 2014-06-26 18:58 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2014-06-26 18:58 UTC (permalink / raw)
To: Himangi Saraogi; +Cc: Tyler Hicks, ecryptfs, linux-kernel, julia.lawall
On Fri, 2014-06-27 at 00:12 +0530, Himangi Saraogi wrote:
> This patch does away with casts on void * as they are unnecessary.
[]
> diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
[]
> @@ -53,7 +53,7 @@ static void unlock_dir(struct dentry *dir)
>
> static int ecryptfs_inode_test(struct inode *inode, void *lower_inode)
> {
> - if (ecryptfs_inode_to_lower(inode) == (struct inode *)lower_inode)
> + if (ecryptfs_inode_to_lower(inode) == lower_inode)
> return 1;
> return 0;
> }
True, but perhaps this should be
{
return ecryptfs_inode_to_lower(inode) == lower_inode;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-26 18:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-26 18:42 [PATCH] ecryptfs: Drop cast Himangi Saraogi
2014-06-26 18:58 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox