From: Jens Axboe <axboe@kernel.dk>
To: Erwan Velu <erwan@enovance.com>
Cc: Grant Grundler <grundler@chromium.org>,
Juan Casse <jcasse@chromium.org>, FIO_list <fio@vger.kernel.org>
Subject: Re: [PATCH 2/2] Adds check for rand_seed during verify phase.
Date: Tue, 3 Sep 2013 16:38:52 -0600 [thread overview]
Message-ID: <20130903223852.GD31170@kernel.dk> (raw)
In-Reply-To: <52244E75.5070405@enovance.com>
On Mon, Sep 02 2013, Erwan Velu wrote:
> On 31/08/2013 06:31, Jens Axboe wrote:
> >[...]
> >Agree. A good commit message describes the need for the change. It needs
> >to justify its own inclusion, so to speak. Basically it answers the key
> >question of why this change is needed.
> >
>
> I don't know how you play with fio, but on my project I'm working on, that's
> a good reason to refuse a patch even if the code is correct :o)
I tend to be (too) nice and provide the missing commit log, especially
if it's for a feature and needs a description. But I have been known to
push back as well and just ask for a description. Usually has not been a
problem.
--
Jens Axboe
next prev parent reply other threads:[~2013-09-03 22:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 21:22 [PATCH 1/2] Adds check for numberio during verify phase Juan Casse
2013-08-26 21:22 ` [PATCH 2/2] Adds check for rand_seed " Juan Casse
2013-08-26 22:11 ` Grant Grundler
2013-08-27 17:02 ` Jens Axboe
2013-08-27 17:25 ` Grant Grundler
2013-08-28 7:14 ` Erwan Velu
2013-08-31 4:31 ` Jens Axboe
2013-09-02 8:38 ` Erwan Velu
2013-09-03 22:38 ` Jens Axboe [this message]
2013-08-27 17:02 ` [PATCH 1/2] Adds check for numberio " Jens Axboe
2013-08-27 17:22 ` Grant Grundler
2013-08-27 17:50 ` Juan Casse
2013-08-27 18:44 ` Juan Casse
2013-08-27 20:48 ` Juan Casse
[not found] <1377797598-9855-1-git-send-email-jcasse@chromium.org>
2013-08-29 17:33 ` [PATCH 2/2] Adds check for rand_seed " Juan Casse
-- strict thread matches above, loose matches on Subject: below --
2013-09-04 1:15 [PATCH 1/2] Adds check for numberio " Juan Casse
2013-09-04 1:15 ` [PATCH 2/2] Adds check for rand_seed " Juan Casse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903223852.GD31170@kernel.dk \
--to=axboe@kernel.dk \
--cc=erwan@enovance.com \
--cc=fio@vger.kernel.org \
--cc=grundler@chromium.org \
--cc=jcasse@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox