From: Erwan Velu <erwan@enovance.com>
To: Grant Grundler <grundler@chromium.org>
Cc: Juan Casse <jcasse@chromium.org>, Jens Axboe <axboe@kernel.dk>,
FIO_list <fio@vger.kernel.org>
Subject: Re: [PATCH 2/2] Adds check for rand_seed during verify phase.
Date: Wed, 28 Aug 2013 09:14:09 +0200 [thread overview]
Message-ID: <521DA341.3050707@enovance.com> (raw)
In-Reply-To: <CANEJEGuKzZeLfCoNX12Pp_4_Uj8iHjLX221c+qpYzgpWYgA-Pg@mail.gmail.com>
On 27/08/2013 00:11, Grant Grundler wrote:
> Jens, et al,
>
> In general I'm ok with this patch...just one issue I'd like to get an
> opinion on...
>
I don't have the skill to make a technical review of it.
At least, I'm a great fan of well detailed commits.
At my taste, I do like when a commit does explain what was the problem
and what is the solution.
A single line for such commit seems a little bit light for me.
Cheers,
next prev parent reply other threads:[~2013-08-28 7:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 21:22 [PATCH 1/2] Adds check for numberio during verify phase Juan Casse
2013-08-26 21:22 ` [PATCH 2/2] Adds check for rand_seed " Juan Casse
2013-08-26 22:11 ` Grant Grundler
2013-08-27 17:02 ` Jens Axboe
2013-08-27 17:25 ` Grant Grundler
2013-08-28 7:14 ` Erwan Velu [this message]
2013-08-31 4:31 ` Jens Axboe
2013-09-02 8:38 ` Erwan Velu
2013-09-03 22:38 ` Jens Axboe
2013-08-27 17:02 ` [PATCH 1/2] Adds check for numberio " Jens Axboe
2013-08-27 17:22 ` Grant Grundler
2013-08-27 17:50 ` Juan Casse
2013-08-27 18:44 ` Juan Casse
2013-08-27 20:48 ` Juan Casse
[not found] <1377797598-9855-1-git-send-email-jcasse@chromium.org>
2013-08-29 17:33 ` [PATCH 2/2] Adds check for rand_seed " Juan Casse
-- strict thread matches above, loose matches on Subject: below --
2013-09-04 1:15 [PATCH 1/2] Adds check for numberio " Juan Casse
2013-09-04 1:15 ` [PATCH 2/2] Adds check for rand_seed " Juan Casse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521DA341.3050707@enovance.com \
--to=erwan@enovance.com \
--cc=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=grundler@chromium.org \
--cc=jcasse@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox