FS/XFS testing framework
 help / color / mirror / Atom feed
From: Pavel Shilovsky <pshilovsky@samba.org>
To: fstests@vger.kernel.org
Cc: linux-cifs@vger.kernel.org, samba-technical@samba.org,
	David Disseldorp <ddiss@suse.de>,
	Steve French <smfrench@gmail.com>
Subject: [PATCH v2 1/3] generic/013: encapsulate remount during cleanup
Date: Wed, 27 Aug 2014 00:28:36 +0400	[thread overview]
Message-ID: <1409084918-17764-2-git-send-email-pshilovsky@samba.org> (raw)
In-Reply-To: <1409084918-17764-1-git-send-email-pshilovsky@samba.org>

The existing code calls remount for $TEST_DEV with constantly defined
mount options. This can fail if a user specifies different mount options.
Fix this by using new _test_remount() call that remounts $TEST_DEV.

Reviewed-by: Steve French <smfrench@gmail.com>
Signed-off-by: Pavel Shilovsky <pshilovsky@samba.org>
---
 common/rc         | 6 ++++++
 tests/generic/013 | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/common/rc b/common/rc
index 16da898..d9c9995 100644
--- a/common/rc
+++ b/common/rc
@@ -218,6 +218,12 @@ _test_mount()
     _mount -t $FSTYP $TEST_OPTIONS $TEST_FS_MOUNT_OPTS $SELINUX_MOUNT_OPTIONS $* $TEST_DEV $TEST_DIR
 }
 
+_test_remount()
+{
+    $UMOUNT_PROG $TEST_DEV
+    _test_mount
+}
+
 _scratch_mkfs_options()
 {
     _scratch_options mkfs
diff --git a/tests/generic/013 b/tests/generic/013
index 93d9904..534c9f0 100755
--- a/tests/generic/013
+++ b/tests/generic/013
@@ -35,7 +35,7 @@ _cleanup()
 {
     cd /
     # we might get here with a RO FS
-    mount -o remount,rw $TEST_DEV >/dev/null 2>&1
+    _test_remount
     # now remove fsstress directory.
     # N.B. rm(1) on IRIX can find problems when building up a long pathname
     # such that what it has is greater the 1024 chars and will
-- 
1.9.1


  reply	other threads:[~2014-08-26 20:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-26 20:28 [PATCH v2 0/3] CIFS support for XFS test suite Pavel Shilovsky
2014-08-26 20:28 ` Pavel Shilovsky [this message]
2014-08-28 17:08   ` [PATCH v2 1/3] generic/013: encapsulate remount during cleanup Christoph Hellwig
2014-08-28 18:50     ` Pavel Shilovsky
2014-08-26 20:28 ` [PATCH v2 2/3] common: add cifs support Pavel Shilovsky
2014-08-28 17:18   ` Christoph Hellwig
2014-08-28 19:08     ` Pavel Shilovsky
2014-08-26 20:28 ` [PATCH v2 3/3] cifs: skip tests that need POSIX support for nounix mounts Pavel Shilovsky
2014-08-27 15:58   ` Christoph Hellwig
2014-08-27 16:17     ` Steve French
2014-08-27 19:49     ` Pavel Shilovsky
2014-08-27 22:50       ` Christoph Hellwig
2014-08-28  7:25         ` Pavel Shilovsky
2014-08-27  6:59 ` [PATCH v2 0/3] CIFS support for XFS test suite Pavel Shilovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1409084918-17764-2-git-send-email-pshilovsky@samba.org \
    --to=pshilovsky@samba.org \
    --cc=ddiss@suse.de \
    --cc=fstests@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=samba-technical@samba.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox