From: Pavel Shilovsky <piastryyy@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Pavel Shilovsky <pshilovsky@samba.org>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
"samba-technical@samba.org" <samba-technical@samba.org>,
David Disseldorp <ddiss@suse.de>,
Steve French <smfrench@gmail.com>
Subject: Re: [PATCH v2 2/3] common: add cifs support
Date: Thu, 28 Aug 2014 23:08:39 +0400 [thread overview]
Message-ID: <7D0F9460-0B84-4D36-B499-83DA9C334198@gmail.com> (raw)
In-Reply-To: <20140828171802.GB20891@infradead.org>
>> 28 авг. 2014 г., в 21:18, Christoph Hellwig <hch@infradead.org> написал(а):
>>
>> On Wed, Aug 27, 2014 at 12:28:37AM +0400, Pavel Shilovsky wrote:
>> + - You can explicitly specify NFS or CIFS, otherwise the filesystem type will
>> + be autodetected from $TEST_DEV:
>> ./check -nfs [test(s)]
>
> Can you take care of mentioning tmpfs as well, looks like it didn't get
> added here when support was added.
Ok, will add it.
>
>> ;;
>> + cifs)
>> + # Don't know how to check a CIFS filesystem, yet.
>> + ;;
>
> Will we ever find a way to sanity check a cifs fs? :)
>
> Otherwise looks fine to me.
Probably some day we will be able to run fsck checks on the remote server through a specific rpc.
Thank you for the review - will repost the series.
--
Best regards,
Pavel Shilovsky.
next prev parent reply other threads:[~2014-08-28 19:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 20:28 [PATCH v2 0/3] CIFS support for XFS test suite Pavel Shilovsky
2014-08-26 20:28 ` [PATCH v2 1/3] generic/013: encapsulate remount during cleanup Pavel Shilovsky
2014-08-28 17:08 ` Christoph Hellwig
2014-08-28 18:50 ` Pavel Shilovsky
2014-08-26 20:28 ` [PATCH v2 2/3] common: add cifs support Pavel Shilovsky
2014-08-28 17:18 ` Christoph Hellwig
2014-08-28 19:08 ` Pavel Shilovsky [this message]
2014-08-26 20:28 ` [PATCH v2 3/3] cifs: skip tests that need POSIX support for nounix mounts Pavel Shilovsky
2014-08-27 15:58 ` Christoph Hellwig
2014-08-27 16:17 ` Steve French
2014-08-27 19:49 ` Pavel Shilovsky
2014-08-27 22:50 ` Christoph Hellwig
2014-08-28 7:25 ` Pavel Shilovsky
2014-08-27 6:59 ` [PATCH v2 0/3] CIFS support for XFS test suite Pavel Shilovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7D0F9460-0B84-4D36-B499-83DA9C334198@gmail.com \
--to=piastryyy@gmail.com \
--cc=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-cifs@vger.kernel.org \
--cc=pshilovsky@samba.org \
--cc=samba-technical@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox