From: Christoph Hellwig <hch@infradead.org>
To: Pavel Shilovsky <pshilovsky@samba.org>
Cc: fstests@vger.kernel.org, linux-cifs@vger.kernel.org,
samba-technical@samba.org, David Disseldorp <ddiss@suse.de>,
Steve French <smfrench@gmail.com>
Subject: Re: [PATCH v2 1/3] generic/013: encapsulate remount during cleanup
Date: Thu, 28 Aug 2014 10:08:49 -0700 [thread overview]
Message-ID: <20140828170849.GA20891@infradead.org> (raw)
In-Reply-To: <1409084918-17764-2-git-send-email-pshilovsky@samba.org>
On Wed, Aug 27, 2014 at 12:28:36AM +0400, Pavel Shilovsky wrote:
> The existing code calls remount for $TEST_DEV with constantly defined
> mount options. This can fail if a user specifies different mount options.
> Fix this by using new _test_remount() call that remounts $TEST_DEV.
Looks technically correct, but I still wonder why it's needed at all,
I can't see anything in the test that would remount the filesystem
read-only. git history isn't a help here as the remount goes back to
the first public revision.
next prev parent reply other threads:[~2014-08-28 17:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 20:28 [PATCH v2 0/3] CIFS support for XFS test suite Pavel Shilovsky
2014-08-26 20:28 ` [PATCH v2 1/3] generic/013: encapsulate remount during cleanup Pavel Shilovsky
2014-08-28 17:08 ` Christoph Hellwig [this message]
2014-08-28 18:50 ` Pavel Shilovsky
2014-08-26 20:28 ` [PATCH v2 2/3] common: add cifs support Pavel Shilovsky
2014-08-28 17:18 ` Christoph Hellwig
2014-08-28 19:08 ` Pavel Shilovsky
2014-08-26 20:28 ` [PATCH v2 3/3] cifs: skip tests that need POSIX support for nounix mounts Pavel Shilovsky
2014-08-27 15:58 ` Christoph Hellwig
2014-08-27 16:17 ` Steve French
2014-08-27 19:49 ` Pavel Shilovsky
2014-08-27 22:50 ` Christoph Hellwig
2014-08-28 7:25 ` Pavel Shilovsky
2014-08-27 6:59 ` [PATCH v2 0/3] CIFS support for XFS test suite Pavel Shilovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828170849.GA20891@infradead.org \
--to=hch@infradead.org \
--cc=ddiss@suse.de \
--cc=fstests@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=pshilovsky@samba.org \
--cc=samba-technical@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox