public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: darrick.wong@oracle.com
Cc: fstests@vger.kernel.org
Subject: [PATCH 2/4] xfstests: make _scratch_mkfs_blocksized usable
Date: Wed,  3 Feb 2016 17:02:06 +0100	[thread overview]
Message-ID: <1454515328-1586-3-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1454515328-1586-1-git-send-email-hch@lst.de>

See http://www.infradead.org/rpr.html

The default mkfs.xfs options contain -b size=4096, so all tests
using _scratch_mkfs_blocksized won't actually run unless those
options are changed.  As we're trying to specificly test 1k
blocks we should always override the default option.

BTW, why is _scratch_mkfs_blocksized in the reflink file and not
with more generic helpers?

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 common/reflink | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/common/reflink b/common/reflink
index 398e505..bb1068a 100644
--- a/common/reflink
+++ b/common/reflink
@@ -201,13 +201,7 @@ _scratch_mkfs_blocksized()
 
     case $FSTYP in
     xfs)
-	# don't override MKFS_OPTIONS that set a block size.
-	echo $MKFS_OPTIONS |egrep -q "b?size="
-	if [ $? -eq 0 ]; then
-		_scratch_mkfs_xfs
-	else
-		_scratch_mkfs_xfs -b size=$blocksize
-	fi
+	_scratch_mkfs_xfs -b size=$blocksize
 	;;
     ext2|ext3|ext4|ocfs2)
 	${MKFS_PROG}.$FSTYP -F $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV
-- 
2.1.4

  parent reply	other threads:[~2016-02-03 16:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 16:02 more reflink fixes Christoph Hellwig
2016-02-03 16:02 ` [PATCH 1/4] xfstests: filter whitespaces in 128 and 132 Christoph Hellwig
2016-02-03 21:10   ` Darrick J. Wong
2016-02-03 16:02 ` Christoph Hellwig [this message]
2016-02-03 21:13   ` [PATCH 2/4] xfstests: make _scratch_mkfs_blocksized usable Darrick J. Wong
2016-02-03 16:02 ` [PATCH 3/4] xfstests: 912 requires dedup support Christoph Hellwig
2016-02-03 20:56   ` Darrick J. Wong
2016-02-03 16:02 ` [PATCH 4/4] xfstests: 899 requires a working filefrag Christoph Hellwig
2016-02-03 20:58   ` Darrick J. Wong
2016-02-04 15:45 ` more reflink fixes Christoph Hellwig
2016-02-04 17:27   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454515328-1586-3-git-send-email-hch@lst.de \
    --to=hch@lst.de \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox