public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 4/4] xfstests: 899 requires a working filefrag
Date: Wed, 3 Feb 2016 12:58:11 -0800	[thread overview]
Message-ID: <20160203205811.GI22352@birch.djwong.org> (raw)
In-Reply-To: <1454515328-1586-5-git-send-email-hch@lst.de>

On Wed, Feb 03, 2016 at 05:02:08PM +0100, Christoph Hellwig wrote:
> See http://www.infradead.org/rpr.html
> 
> NFS has neither FIBMAP nor FIEMAP so filefrag will fail.  Handle this
> case gracefully.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/generic/899 | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/generic/899 b/tests/generic/899
> index 9b3f973..ce3db38 100755
> --- a/tests/generic/899
> +++ b/tests/generic/899
> @@ -67,6 +67,10 @@ nr=64
>  _pwrite_byte 0x61 0 $((blksz * nr)) "$testdir/file1" >> "$seqres.full"
>  _pwrite_byte 0x62 0 $((blksz * nr)) "$testdir/file3" >> "$seqres.full"
>  _pwrite_byte 0x61 0 $((blksz * nr)) "$testdir/file1.chk" >> "$seqres.full"
> +
> +filefrag -v "$testdir/file1" 2>&1 | grep -q "FIBMAP: Invalid argument" && \
> +	_notrun "filefrag not support on file system type \"$FSTYP\""

I rewrote the test to avoid filefrag.

--D

> +
>  seq 1 2 $((nr-1)) | while read f; do
>  	_reflink_range "$testdir/file1" $((blksz * f)) "$testdir/file3" $((blksz * f)) $blksz >> "$seqres.full"
>  done
> -- 
> 2.1.4
> 

  reply	other threads:[~2016-02-03 20:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 16:02 more reflink fixes Christoph Hellwig
2016-02-03 16:02 ` [PATCH 1/4] xfstests: filter whitespaces in 128 and 132 Christoph Hellwig
2016-02-03 21:10   ` Darrick J. Wong
2016-02-03 16:02 ` [PATCH 2/4] xfstests: make _scratch_mkfs_blocksized usable Christoph Hellwig
2016-02-03 21:13   ` Darrick J. Wong
2016-02-03 16:02 ` [PATCH 3/4] xfstests: 912 requires dedup support Christoph Hellwig
2016-02-03 20:56   ` Darrick J. Wong
2016-02-03 16:02 ` [PATCH 4/4] xfstests: 899 requires a working filefrag Christoph Hellwig
2016-02-03 20:58   ` Darrick J. Wong [this message]
2016-02-04 15:45 ` more reflink fixes Christoph Hellwig
2016-02-04 17:27   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160203205811.GI22352@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox