public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: fstests@vger.kernel.org
Subject: Re: more reflink fixes
Date: Thu, 4 Feb 2016 09:27:18 -0800	[thread overview]
Message-ID: <20160204172718.GA27899@birch.djwong.org> (raw)
In-Reply-To: <20160204154552.GA31510@lst.de>

On Thu, Feb 04, 2016 at 04:45:52PM +0100, Christoph Hellwig wrote:
> And another one:
> 
> ---
> From 36919b5d1c84b0ceb8b9fc5c33ec1730d10e5d1c Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch@lst.de>
> Date: Thu, 4 Feb 2016 16:42:12 +0100
> Subject: xfstests: don't run 907 and 908 on NFS
> 
> NFS can't interrupt pending clone operations as they are a remote
> operation.  Skip the two tests that rely on this as they'll mess up
> all following tests otherwise.

Applied, thanks.

--D

> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/generic/907 | 2 ++
>  tests/generic/908 | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/tests/generic/907 b/tests/generic/907
> index fec22c8..e35e067 100755
> --- a/tests/generic/907
> +++ b/tests/generic/907
> @@ -47,6 +47,8 @@ _require_scratch_reflink
>  _require_cp_reflink
>  _require_command "$(which timeout)" "timeout"
>  
> +test "$FSTYP" == "nfs"  && _notrun "NFS can't interrupt clone operations"
> +
>  rm -f "$seqres.full"
>  
>  echo "Format and mount"
> diff --git a/tests/generic/908 b/tests/generic/908
> index 09a3101..c977ed6 100755
> --- a/tests/generic/908
> +++ b/tests/generic/908
> @@ -47,6 +47,8 @@ _require_scratch_reflink
>  _require_cp_reflink
>  _require_command "$(which timeout)" "timeout"
>  
> +test "$FSTYP" == "nfs"  && _notrun "NFS can't interrupt clone operations"
> +
>  rm -f "$seqres.full"
>  
>  echo "Format and mount"
> -- 
> 2.1.4
> 

      reply	other threads:[~2016-02-04 17:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-03 16:02 more reflink fixes Christoph Hellwig
2016-02-03 16:02 ` [PATCH 1/4] xfstests: filter whitespaces in 128 and 132 Christoph Hellwig
2016-02-03 21:10   ` Darrick J. Wong
2016-02-03 16:02 ` [PATCH 2/4] xfstests: make _scratch_mkfs_blocksized usable Christoph Hellwig
2016-02-03 21:13   ` Darrick J. Wong
2016-02-03 16:02 ` [PATCH 3/4] xfstests: 912 requires dedup support Christoph Hellwig
2016-02-03 20:56   ` Darrick J. Wong
2016-02-03 16:02 ` [PATCH 4/4] xfstests: 899 requires a working filefrag Christoph Hellwig
2016-02-03 20:58   ` Darrick J. Wong
2016-02-04 15:45 ` more reflink fixes Christoph Hellwig
2016-02-04 17:27   ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160204172718.GA27899@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox