* [PATCH] xfstests-bld: format filesystem with '-O encrypt' in encrypt config
@ 2016-12-13 6:59 Eric Biggers
0 siblings, 0 replies; 3+ messages in thread
From: Eric Biggers @ 2016-12-13 6:59 UTC (permalink / raw)
To: Theodore Y . Ts'o; +Cc: fstests, Eric Biggers
From: Eric Biggers <ebiggers@google.com>
We were relying on the kernel setting the 'encrypt' feature flag for us.
We should just do it in userspace when formatting the filesystem.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt
index 390e205..320eff0 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt
@@ -1,5 +1,5 @@
SIZE=small
-export MKFS_OPTIONS=""
+export MKFS_OPTIONS="-O encrypt"
export EXT_MOUNT_OPTIONS="test_dummy_encryption"
REQUIRE_FEATURE=encryption
TESTNAME="Ext4 encryption"
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] xfstests-bld: format filesystem with '-O encrypt' in encrypt config
@ 2017-02-06 21:42 Eric Biggers
2017-02-07 17:40 ` Theodore Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Eric Biggers @ 2017-02-06 21:42 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: fstests, Eric Biggers
From: Eric Biggers <ebiggers@google.com>
We were relying on the kernel setting the 'encrypt' feature flag for us.
We should just do it in userspace when formatting the filesystem. This
will allow us to eventually remove the kernel-side hack to force-set the
'encrypt' flag in the superblock.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt
index 390e205..320eff0 100644
--- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt
+++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/encrypt
@@ -1,5 +1,5 @@
SIZE=small
-export MKFS_OPTIONS=""
+export MKFS_OPTIONS="-O encrypt"
export EXT_MOUNT_OPTIONS="test_dummy_encryption"
REQUIRE_FEATURE=encryption
TESTNAME="Ext4 encryption"
--
2.11.0.483.g087da7b7c-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfstests-bld: format filesystem with '-O encrypt' in encrypt config
2017-02-06 21:42 Eric Biggers
@ 2017-02-07 17:40 ` Theodore Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2017-02-07 17:40 UTC (permalink / raw)
To: Eric Biggers; +Cc: fstests, Eric Biggers
On Mon, Feb 06, 2017 at 01:42:34PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> We were relying on the kernel setting the 'encrypt' feature flag for us.
> We should just do it in userspace when formatting the filesystem. This
> will allow us to eventually remove the kernel-side hack to force-set the
> 'encrypt' flag in the superblock.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-07 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-13 6:59 [PATCH] xfstests-bld: format filesystem with '-O encrypt' in encrypt config Eric Biggers
-- strict thread matches above, loose matches on Subject: below --
2017-02-06 21:42 Eric Biggers
2017-02-07 17:40 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox