From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, Xiong Zhou <xzhou@redhat.com>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH v2 0/6] fstests: more tests for overlay constant inode numbers
Date: Fri, 28 Apr 2017 11:24:42 +0300 [thread overview]
Message-ID: <1493367888-26550-1-git-send-email-amir73il@gmail.com> (raw)
Hi Eryu,
This series contains enhancements to overlay/017, which I used to test
my work on overlayfs constant inode numbers. [1]
The original test was a bit naiive, not taking into account renames,
drop caches and mount cycle. All those are added by this series.
Since the original test does not pass on stable kernel nor will
it pass with the changes by this series, these changes should cause
no regressions to testers.
My work covers only the inode numbers returned from stat(2) and not
the inode numbers returned in d_ino from readdir(3), so the 'find -inum'
part of this test could still fail with my overlayfs patches.
However, I ran my tests in kvm-xfstests VM, where 'find -inum' called
stat(2) for each entry, so the test did pass.
I will dig deeper into this behavior when I work on fixing d_ino
values in the next part of my work.
Changes since v1:
- Re-factor check_inode_numbers
- Move -maxdepth option position
- Fix somme comments
- Blurb more in commit messages
Amir.
[1] https://marc.info/?l=linux-unionfs&m=149324252301397&w=2
Amir Goldstein (6):
overlay/017: silence test output
overlay/017: fix some comments
overlay/017: use af_unix to create socket test file
overlay/017: create helpers to record and check inode numbers
overlay/017: verify constant inode number after rename
overlay/017: test persistent inode numbers after mount cycle
tests/overlay/017 | 86 +++++++++++++++++++++++++++++++++++++++++----------
tests/overlay/017.out | 7 +----
2 files changed, 70 insertions(+), 23 deletions(-)
--
2.7.4
next reply other threads:[~2017-04-28 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 8:24 Amir Goldstein [this message]
2017-04-28 8:24 ` [PATCH v2 1/6] overlay/017: silence test output Amir Goldstein
2017-04-28 8:24 ` [PATCH v2 2/6] overlay/017: fix some comments Amir Goldstein
2017-04-28 8:24 ` [PATCH v2 3/6] overlay/017: use af_unix to create socket test file Amir Goldstein
2017-04-28 8:24 ` [PATCH v2 4/6] overlay/017: create helpers to record and check inode numbers Amir Goldstein
2017-04-28 9:24 ` Eryu Guan
2017-04-28 10:04 ` Amir Goldstein
2017-04-28 10:53 ` Amir Goldstein
2017-04-28 8:24 ` [PATCH v2 5/6] overlay/017: verify constant inode number after rename Amir Goldstein
2017-04-28 8:24 ` [PATCH v2 6/6] overlay/017: test persistent inode numbers after mount cycle Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493367888-26550-1-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox