From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, Xiong Zhou <xzhou@redhat.com>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH v2 2/6] overlay/017: fix some comments
Date: Fri, 28 Apr 2017 11:24:44 +0300 [thread overview]
Message-ID: <1493367888-26550-3-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1493367888-26550-1-git-send-email-amir73il@gmail.com>
Align all comments to the term 'constant inode numbers' and
explain why hardlinks are excluded from this test.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
tests/overlay/017 | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/overlay/017 b/tests/overlay/017
index 7c1430d..e04690c 100755
--- a/tests/overlay/017
+++ b/tests/overlay/017
@@ -1,7 +1,7 @@
#! /bin/bash
# FSQA Test No. 017
#
-# Test unstable inode number
+# Test constant inode numbers
#
# This simple test demonstrates a known issue with overlayfs:
# - stat file A shows inode number X
@@ -58,9 +58,8 @@ rm -f $seqres.full
_scratch_mkfs >>$seqres.full 2>&1
# Create our test files.
-# Not dealing with hardlinks here, because there is more to test
-# then stable inode number.
-# Hardlinks will get a test of their own.
+# Not dealing with hardlinks here, when hardlinks are broken they
+# should not preserve the inode number.
lowerdir=$OVL_BASE_SCRATCH_MNT/$OVL_LOWER
mkdir -p $lowerdir
mkdir $lowerdir/dir
--
2.7.4
next prev parent reply other threads:[~2017-04-28 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 8:24 [PATCH v2 0/6] fstests: more tests for overlay constant inode numbers Amir Goldstein
2017-04-28 8:24 ` [PATCH v2 1/6] overlay/017: silence test output Amir Goldstein
2017-04-28 8:24 ` Amir Goldstein [this message]
2017-04-28 8:24 ` [PATCH v2 3/6] overlay/017: use af_unix to create socket test file Amir Goldstein
2017-04-28 8:24 ` [PATCH v2 4/6] overlay/017: create helpers to record and check inode numbers Amir Goldstein
2017-04-28 9:24 ` Eryu Guan
2017-04-28 10:04 ` Amir Goldstein
2017-04-28 10:53 ` Amir Goldstein
2017-04-28 8:24 ` [PATCH v2 5/6] overlay/017: verify constant inode number after rename Amir Goldstein
2017-04-28 8:24 ` [PATCH v2 6/6] overlay/017: test persistent inode numbers after mount cycle Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493367888-26550-3-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox