From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, Xiong Zhou <xzhou@redhat.com>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH v2 1/6] overlay/017: silence test output
Date: Fri, 28 Apr 2017 11:24:43 +0300 [thread overview]
Message-ID: <1493367888-26550-2-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1493367888-26550-1-git-send-email-amir73il@gmail.com>
Change test to output golden silence on success.
We are going to run the same check several times,
so instead of cloning the test output, cloning the
silence will be more conveniet.
Generalize cleanup of temp files for the same reason.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
tests/overlay/017 | 7 +++++--
tests/overlay/017.out | 7 +------
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/tests/overlay/017 b/tests/overlay/017
index 5ca3040..7c1430d 100755
--- a/tests/overlay/017
+++ b/tests/overlay/017
@@ -40,6 +40,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
_cleanup()
{
+ cd /
rm -f $tmp.*
}
@@ -73,7 +74,7 @@ mknod $lowerdir/fifo p
_scratch_mount
-rm -f $tmp.before $tmp.after
+rm -f $tmp.*
# Test stable stat(2) st_ino
@@ -89,11 +90,13 @@ done
# find by inode number - expect to find file by inode number
cat $tmp.before | while read ino f; do
- find $f -inum $ino -maxdepth 0 | _filter_scratch
+ find $SCRATCH_MNT/ -maxdepth 1 -inum $ino | grep -q $f || \
+ echo "$f not found by ino $ino"
done
# Compare before..after - expect silence
diff $tmp.before $tmp.after
+echo "Silence is golden"
status=0
exit
diff --git a/tests/overlay/017.out b/tests/overlay/017.out
index 1f277c5..8222844 100644
--- a/tests/overlay/017.out
+++ b/tests/overlay/017.out
@@ -1,7 +1,2 @@
QA output created by 017
-SCRATCH_MNT/dir
-SCRATCH_MNT/file
-SCRATCH_MNT/symlink
-SCRATCH_MNT/chrdev
-SCRATCH_MNT/blkdev
-SCRATCH_MNT/fifo
+Silence is golden
--
2.7.4
next prev parent reply other threads:[~2017-04-28 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 8:24 [PATCH v2 0/6] fstests: more tests for overlay constant inode numbers Amir Goldstein
2017-04-28 8:24 ` Amir Goldstein [this message]
2017-04-28 8:24 ` [PATCH v2 2/6] overlay/017: fix some comments Amir Goldstein
2017-04-28 8:24 ` [PATCH v2 3/6] overlay/017: use af_unix to create socket test file Amir Goldstein
2017-04-28 8:24 ` [PATCH v2 4/6] overlay/017: create helpers to record and check inode numbers Amir Goldstein
2017-04-28 9:24 ` Eryu Guan
2017-04-28 10:04 ` Amir Goldstein
2017-04-28 10:53 ` Amir Goldstein
2017-04-28 8:24 ` [PATCH v2 5/6] overlay/017: verify constant inode number after rename Amir Goldstein
2017-04-28 8:24 ` [PATCH v2 6/6] overlay/017: test persistent inode numbers after mount cycle Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493367888-26550-2-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox