public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, Xiong Zhou <xzhou@redhat.com>,
	linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 3/4] overlay/017: test consistent st_ino/d_ino for hardlinks
Date: Thu, 11 May 2017 09:55:09 +0300	[thread overview]
Message-ID: <1494485710-2400-4-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1494485710-2400-1-git-send-email-amir73il@gmail.com>

Currently hardlinks do not preserve the inode number across copy up,
so hardlinks did not participate in this test so far.

Stay honest and let the test verify what is was meant to verify and
let it fail because of the fact that hardlinks inode numbers are not
constant across copy up.

Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
 tests/overlay/017 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/overlay/017 b/tests/overlay/017
index bb467f7..e9c8525 100755
--- a/tests/overlay/017
+++ b/tests/overlay/017
@@ -63,8 +63,6 @@ rm -f $seqres.full
 _scratch_mkfs >>$seqres.full 2>&1
 
 # Create our test files.
-# Not dealing with hardlinks here, when hardlinks are broken they
-# should not preserve the inode number.
 lowerdir=$OVL_BASE_SCRATCH_MNT/$OVL_LOWER
 mkdir -p $lowerdir
 mkdir $lowerdir/dir
@@ -74,8 +72,10 @@ mknod $lowerdir/chrdev c 1 1
 mknod $lowerdir/blkdev b 1 1
 mknod $lowerdir/fifo p
 $here/src/af_unix $lowerdir/socket
+touch $lowerdir/hardlink1
+ln $lowerdir/hardlink1 $lowerdir/hardlink2
 
-FILES="dir file symlink chrdev blkdev fifo socket"
+FILES="dir file symlink chrdev blkdev fifo socket hardlink1 hardlink2"
 
 # Record inode numbers in format <ino> <basename>
 function record_inode_numbers()
-- 
2.7.4


  parent reply	other threads:[~2017-05-11  6:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11  6:55 [PATCH 0/4] overlay/017: fix false negatives Amir Goldstein
2017-05-11  6:55 ` [PATCH 1/4] src/t_dir_type: support filtering by inode number Amir Goldstein
2017-05-11  6:55 ` [PATCH 2/4] overlay/017: use t_dir_type to find file by d_ino Amir Goldstein
2017-05-11  6:55 ` Amir Goldstein [this message]
2017-05-11  6:55 ` [PATCH 4/4] overlay: tag tests 016-018 as experimental Amir Goldstein
2017-05-12  4:01   ` Eryu Guan
2017-05-12  6:16     ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494485710-2400-4-git-send-email-amir73il@gmail.com \
    --to=amir73il@gmail.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=xzhou@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox