From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, Xiong Zhou <xzhou@redhat.com>,
linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 0/4] overlay/017: fix false negatives
Date: Thu, 11 May 2017 09:55:06 +0300 [thread overview]
Message-ID: <1494485710-2400-1-git-send-email-amir73il@gmail.com> (raw)
Eryu,
With current mainline master branch, overlay/017 may pass on some systems
(e.g. kvm-xfstests) due to a bug in the test, which I already reported.
This series fixes the test back to failing by using the auxiliary program
t_dir_type instead of 'find' whose behavior is system dependent.
I also removed the exception of testing hardlinks, so now the test really
tests what it was meant to test (constant inode number across copy up)
without any discounts for special cases.
Amir.
Amir Goldstein (4):
src/t_dir_type: support filtering by inode number
overlay/017: use t_dir_type to find file by d_ino
overlay/017: test consistent st_ino/d_ino for hardlinks
overlay: tag tests 016-018 as experimental
doc/auxiliary-programs.txt | 7 +++++++
src/t_dir_type.c | 11 ++++++++---
tests/overlay/017 | 9 +++++----
tests/overlay/group | 6 +++---
4 files changed, 23 insertions(+), 10 deletions(-)
--
2.7.4
next reply other threads:[~2017-05-11 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 6:55 Amir Goldstein [this message]
2017-05-11 6:55 ` [PATCH 1/4] src/t_dir_type: support filtering by inode number Amir Goldstein
2017-05-11 6:55 ` [PATCH 2/4] overlay/017: use t_dir_type to find file by d_ino Amir Goldstein
2017-05-11 6:55 ` [PATCH 3/4] overlay/017: test consistent st_ino/d_ino for hardlinks Amir Goldstein
2017-05-11 6:55 ` [PATCH 4/4] overlay: tag tests 016-018 as experimental Amir Goldstein
2017-05-12 4:01 ` Eryu Guan
2017-05-12 6:16 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494485710-2400-1-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox