public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, Xiong Zhou <xzhou@redhat.com>,
	linux-unionfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH 4/4] overlay: tag tests 016-018 as experimental
Date: Fri, 12 May 2017 12:01:45 +0800	[thread overview]
Message-ID: <20170512040145.GJ7250@eguan.usersys.redhat.com> (raw)
In-Reply-To: <1494485710-2400-5-git-send-email-amir73il@gmail.com>

On Thu, May 11, 2017 at 09:55:10AM +0300, Amir Goldstein wrote:
> The tests 016-018 were added to track overlayfs 'Non-standard behavior'
> as are documented in Documentation/filesystems/overlayfs.txt, with the
> intention of fixing those behaviors 'some day'.
> 
> While that day seems to be seen in the horizon, at least for test 017,
> it may take a while longer for all those tests to pass.
> Add those tests to group 'experimental' so at least this special status
> is published somehow.
> 
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>

The first three patches look good to me, but I'm a bit reluctant on
merging this one.

To me, this new 'experimental' group serves as an indication of "this
test is known to fail". But this info already can be found in commit
logs and comments of these tests. Also fstests had been pushing back
attempts to add "known issue" support in the past. So I'd rather drop
this patch.

Thanks,
Eryu

> ---
>  tests/overlay/group | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/overlay/group b/tests/overlay/group
> index c5048c4..39169d3 100644
> --- a/tests/overlay/group
> +++ b/tests/overlay/group
> @@ -18,9 +18,9 @@
>  013 auto quick copyup
>  014 auto quick copyup
>  015 auto quick whiteout
> -016 auto quick copyup
> -017 auto quick copyup
> -018 auto quick copyup
> +016 auto quick copyup experimental
> +017 auto quick copyup experimental
> +018 auto quick copyup experimental
>  019 auto stress
>  020 auto quick copyup perms
>  021 auto quick copyup
> -- 
> 2.7.4
> 

  reply	other threads:[~2017-05-12  4:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11  6:55 [PATCH 0/4] overlay/017: fix false negatives Amir Goldstein
2017-05-11  6:55 ` [PATCH 1/4] src/t_dir_type: support filtering by inode number Amir Goldstein
2017-05-11  6:55 ` [PATCH 2/4] overlay/017: use t_dir_type to find file by d_ino Amir Goldstein
2017-05-11  6:55 ` [PATCH 3/4] overlay/017: test consistent st_ino/d_ino for hardlinks Amir Goldstein
2017-05-11  6:55 ` [PATCH 4/4] overlay: tag tests 016-018 as experimental Amir Goldstein
2017-05-12  4:01   ` Eryu Guan [this message]
2017-05-12  6:16     ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170512040145.GJ7250@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=amir73il@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=xzhou@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox