From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, zlang@redhat.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me,
leah.rumancik@gmail.com, quwenruo.btrfs@gmx.com, tytso@mit.edu
Subject: [PATCH 09/14] report: pass property value to _xunit_add_property
Date: Tue, 14 Feb 2023 17:46:29 -0800 [thread overview]
Message-ID: <167642558963.2118945.5072238407025556768.stgit@magnolia> (raw)
In-Reply-To: <167642553879.2118945.15448815976865210889.stgit@magnolia>
From: Darrick J. Wong <djwong@kernel.org>
Change this helper to require the caller to pass the value as the second
parameter. This prepares us to start reporting a lot more information
about a test run, not all of which are encoded as bash variables.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
common/report | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/common/report b/common/report
index 3ec2d88178..2ab83928db 100644
--- a/common/report
+++ b/common/report
@@ -29,12 +29,13 @@ encode_cdata()
_xunit_add_property()
{
local name="$1"
- local value="${!name}"
+ local value="$2"
- if [ ! -z "$value" ]; then
- echo -e "\t\t<property name=\"$name\" value=\"$value\"/>"
- fi
+ test -z "$value" && return
+
+ echo -e "\t\t<property name=\"$name\" value=\"$value\"/>"
}
+
_xunit_make_section_report()
{
# xfstest:section ==> xunit:testsuite
@@ -76,7 +77,7 @@ ENDL
# Properties
echo -e "\t<properties>" >> $REPORT_DIR/result.xml
for p in "${REPORT_ENV_LIST[@]}"; do
- _xunit_add_property "$p"
+ _xunit_add_property "$p" "${!p}"
done | sort >> $REPORT_DIR/result.xml
echo -e "\t</properties>" >> $REPORT_DIR/result.xml
if [ -f $report ]; then
next prev parent reply other threads:[~2023-02-15 1:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 1:45 [PATCHSET v2 00/14] fstests: improve junit xml reporting Darrick J. Wong
2023-02-15 1:45 ` [PATCH 01/14] check: generate section reports between tests Darrick J. Wong
2023-02-15 18:53 ` Leah Rumancik
2023-02-15 1:45 ` [PATCH 02/14] report: derive an xml schema for the xunit report Darrick J. Wong
2023-02-15 1:45 ` [PATCH 03/14] report: capture the time zone in the test report timestamp Darrick J. Wong
2023-02-15 1:46 ` [PATCH 04/14] report: clarify the meaning of the timestamp attribute Darrick J. Wong
2023-02-15 1:46 ` [PATCH 05/14] report: record fstests start and report generation timestamps Darrick J. Wong
2023-02-15 1:46 ` [PATCH 06/14] report: encode cdata sections correctly Darrick J. Wong
2023-02-15 1:46 ` [PATCH 07/14] report: encode the kernel log as a separate xml element Darrick J. Wong
2023-02-15 1:46 ` [PATCH 08/14] report: sort properties by name Darrick J. Wong
2023-02-15 1:46 ` Darrick J. Wong [this message]
2023-02-15 1:46 ` [PATCH 10/14] report: encode xml entities in property values Darrick J. Wong
2023-02-15 1:46 ` [PATCH 11/14] report: collect basic information about a test run Darrick J. Wong
2023-02-15 1:46 ` [PATCH 12/14] report: record xfs-specific " Darrick J. Wong
2023-02-15 1:46 ` [PATCH 13/14] report: record ext*-specific " Darrick J. Wong
2023-02-15 1:46 ` [PATCH 14/14] report: allow test runners to inject arbitrary values Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167642558963.2118945.5072238407025556768.stgit@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=leah.rumancik@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=tytso@mit.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox