FS/XFS testing framework
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, zlang@redhat.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me,
	leah.rumancik@gmail.com, quwenruo.btrfs@gmx.com, tytso@mit.edu
Subject: [PATCH 10/14] report: encode xml entities in property values
Date: Tue, 14 Feb 2023 17:46:35 -0800	[thread overview]
Message-ID: <167642559529.2118945.3777372837490960741.stgit@magnolia> (raw)
In-Reply-To: <167642553879.2118945.15448815976865210889.stgit@magnolia>

From: Darrick J. Wong <djwong@kernel.org>

Avoid trouble with the properties reported in the xml reports by
translating xml-tricky characters in the property values into their xml
entity equivalents.

IOWs, if someone sets a property "NAME" to the value 'BOBBY"; DROP TABLES;',
the xml will be formatted:

	<property name="NAME" value="BOBBY&quot;; DROP TABLES;"/>

Thus avoiding XML problems.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 common/report |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)


diff --git a/common/report b/common/report
index 2ab83928db..946ee4887c 100644
--- a/common/report
+++ b/common/report
@@ -33,7 +33,10 @@ _xunit_add_property()
 
 	test -z "$value" && return
 
-	echo -e "\t\t<property name=\"$name\" value=\"$value\"/>"
+	local xname="$(echo "$name" | encode_xml)"
+	local xvalue="$(echo "$value" | encode_xml)"
+
+	echo -e "\t\t<property name=\"$xname\" value=\"$xvalue\"/>"
 }
 
 _xunit_make_section_report()


  parent reply	other threads:[~2023-02-15  1:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-15  1:45 [PATCHSET v2 00/14] fstests: improve junit xml reporting Darrick J. Wong
2023-02-15  1:45 ` [PATCH 01/14] check: generate section reports between tests Darrick J. Wong
2023-02-15 18:53   ` Leah Rumancik
2023-02-15  1:45 ` [PATCH 02/14] report: derive an xml schema for the xunit report Darrick J. Wong
2023-02-15  1:45 ` [PATCH 03/14] report: capture the time zone in the test report timestamp Darrick J. Wong
2023-02-15  1:46 ` [PATCH 04/14] report: clarify the meaning of the timestamp attribute Darrick J. Wong
2023-02-15  1:46 ` [PATCH 05/14] report: record fstests start and report generation timestamps Darrick J. Wong
2023-02-15  1:46 ` [PATCH 06/14] report: encode cdata sections correctly Darrick J. Wong
2023-02-15  1:46 ` [PATCH 07/14] report: encode the kernel log as a separate xml element Darrick J. Wong
2023-02-15  1:46 ` [PATCH 08/14] report: sort properties by name Darrick J. Wong
2023-02-15  1:46 ` [PATCH 09/14] report: pass property value to _xunit_add_property Darrick J. Wong
2023-02-15  1:46 ` Darrick J. Wong [this message]
2023-02-15  1:46 ` [PATCH 11/14] report: collect basic information about a test run Darrick J. Wong
2023-02-15  1:46 ` [PATCH 12/14] report: record xfs-specific " Darrick J. Wong
2023-02-15  1:46 ` [PATCH 13/14] report: record ext*-specific " Darrick J. Wong
2023-02-15  1:46 ` [PATCH 14/14] report: allow test runners to inject arbitrary values Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167642559529.2118945.3777372837490960741.stgit@magnolia \
    --to=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=leah.rumancik@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=tytso@mit.edu \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox