From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, zlang@redhat.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me,
leah.rumancik@gmail.com, quwenruo.btrfs@gmx.com, tytso@mit.edu
Subject: [PATCH 14/14] report: allow test runners to inject arbitrary values
Date: Tue, 14 Feb 2023 17:46:57 -0800 [thread overview]
Message-ID: <167642561790.2118945.13068111127264406746.stgit@magnolia> (raw)
In-Reply-To: <167642553879.2118945.15448815976865210889.stgit@magnolia>
From: Darrick J. Wong <djwong@kernel.org>
Per Ted's request, add to the test section reporting code the ability
for test runners to point to a file containing colon-separated key value
pairs. These key value pairs will be recorded in the report file as
extra properties.
Requested-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
README | 3 +++
common/report | 10 ++++++++++
2 files changed, 13 insertions(+)
diff --git a/README b/README
index 4c4f22f853..a8c67cea4d 100644
--- a/README
+++ b/README
@@ -245,6 +245,9 @@ Misc:
this option is supported for all filesystems currently only -overlay is
expected to run without issues. For other filesystems additional patches
and fixes to the test suite might be needed.
+ - Set REPORT_VARS_FILE to a file containing colon-separated name-value pairs
+ that will be recorded in the test section report. Names must be unique.
+ Whitespace surrounding the colon will be removed.
______________________
USING THE FSQA SUITE
diff --git a/common/report b/common/report
index e22e2f8558..4b45f7c803 100644
--- a/common/report
+++ b/common/report
@@ -44,9 +44,19 @@ __generate_blockdev_report_vars() {
REPORT_VARS["${bdev_var}_ZONES"]="$(cat "$sysfs_bdev/queue/nr_zones" 2>/dev/null)"
}
+__import_report_vars() {
+ local fname="$1"
+
+ while IFS=':' read key value; do
+ REPORT_VARS["${key%% }"]="${value## }"
+ done < "$1"
+}
+
# Fill out REPORT_VARS with tidbits about our test runner configuration.
# Caller is required to declare REPORT_VARS to be an associative array.
__generate_report_vars() {
+ test "$REPORT_VARS_FILE" && __import_report_vars "$REPORT_VARS_FILE"
+
REPORT_VARS["ARCH"]="$(uname -m)"
REPORT_VARS["KERNEL"]="$(uname -r)"
REPORT_VARS["CPUS"]="$(getconf _NPROCESSORS_ONLN 2>/dev/null)"
prev parent reply other threads:[~2023-02-15 1:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 1:45 [PATCHSET v2 00/14] fstests: improve junit xml reporting Darrick J. Wong
2023-02-15 1:45 ` [PATCH 01/14] check: generate section reports between tests Darrick J. Wong
2023-02-15 18:53 ` Leah Rumancik
2023-02-15 1:45 ` [PATCH 02/14] report: derive an xml schema for the xunit report Darrick J. Wong
2023-02-15 1:45 ` [PATCH 03/14] report: capture the time zone in the test report timestamp Darrick J. Wong
2023-02-15 1:46 ` [PATCH 04/14] report: clarify the meaning of the timestamp attribute Darrick J. Wong
2023-02-15 1:46 ` [PATCH 05/14] report: record fstests start and report generation timestamps Darrick J. Wong
2023-02-15 1:46 ` [PATCH 06/14] report: encode cdata sections correctly Darrick J. Wong
2023-02-15 1:46 ` [PATCH 07/14] report: encode the kernel log as a separate xml element Darrick J. Wong
2023-02-15 1:46 ` [PATCH 08/14] report: sort properties by name Darrick J. Wong
2023-02-15 1:46 ` [PATCH 09/14] report: pass property value to _xunit_add_property Darrick J. Wong
2023-02-15 1:46 ` [PATCH 10/14] report: encode xml entities in property values Darrick J. Wong
2023-02-15 1:46 ` [PATCH 11/14] report: collect basic information about a test run Darrick J. Wong
2023-02-15 1:46 ` [PATCH 12/14] report: record xfs-specific " Darrick J. Wong
2023-02-15 1:46 ` [PATCH 13/14] report: record ext*-specific " Darrick J. Wong
2023-02-15 1:46 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167642561790.2118945.13068111127264406746.stgit@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=leah.rumancik@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=tytso@mit.edu \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox