* [PATCH v2] common/rc: add filter in _test_inode_flag
@ 2021-02-10 8:34 XiaoLi Feng
2021-02-18 6:30 ` Xiao Yang
0 siblings, 1 reply; 3+ messages in thread
From: XiaoLi Feng @ 2021-02-10 8:34 UTC (permalink / raw)
To: fstests; +Cc: Xiaoli Feng
From: Xiaoli Feng <xifeng@redhat.com>
Add _filter_scratch and _filter_test_dir to avoid _test_inode_flag failed when
mount point contains flag string.
---
common/rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/rc b/common/rc
index 649b1cfd..f3bb665e 100644
--- a/common/rc
+++ b/common/rc
@@ -3112,7 +3112,7 @@ _test_inode_flag()
local flag=$1
local file=$2
- if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | grep -q "$flag" ; then
+ if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | _filter_scratch | _filter_test_dir | grep -q "$flag" ; then
return 0
fi
return 1
--
2.18.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] common/rc: add filter in _test_inode_flag
2021-02-10 8:34 [PATCH v2] common/rc: add filter in _test_inode_flag XiaoLi Feng
@ 2021-02-18 6:30 ` Xiao Yang
2021-02-18 8:49 ` Xiaoli Feng
0 siblings, 1 reply; 3+ messages in thread
From: Xiao Yang @ 2021-02-18 6:30 UTC (permalink / raw)
To: XiaoLi Feng; +Cc: fstests
On 2021/2/10 16:34, XiaoLi Feng wrote:
> From: Xiaoli Feng <xifeng@redhat.com>
>
> Add _filter_scratch and _filter_test_dir to avoid _test_inode_flag failed when
> mount point contains flag string.
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 649b1cfd..f3bb665e 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -3112,7 +3112,7 @@ _test_inode_flag()
> local flag=$1
> local file=$2
>
> - if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | grep -q "$flag" ; then
> + if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | _filter_scratch | _filter_test_dir | grep -q "$flag" ; then
Hi XiaoLi,
Is it ok to use _filter_testdir_and_scratch directly?
Best Regards,
Xiao Yang
> return 0
> fi
> return 1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] common/rc: add filter in _test_inode_flag
2021-02-18 6:30 ` Xiao Yang
@ 2021-02-18 8:49 ` Xiaoli Feng
0 siblings, 0 replies; 3+ messages in thread
From: Xiaoli Feng @ 2021-02-18 8:49 UTC (permalink / raw)
To: Xiao Yang; +Cc: fstests
Hi,
----- Original Message -----
> From: "Xiao Yang" <yangx.jy@cn.fujitsu.com>
> To: "XiaoLi Feng" <xifeng@redhat.com>
> Cc: fstests@vger.kernel.org
> Sent: Thursday, February 18, 2021 2:30:38 PM
> Subject: Re: [PATCH v2] common/rc: add filter in _test_inode_flag
>
> On 2021/2/10 16:34, XiaoLi Feng wrote:
> > From: Xiaoli Feng <xifeng@redhat.com>
> >
> > Add _filter_scratch and _filter_test_dir to avoid _test_inode_flag failed
> > when
> > mount point contains flag string.
> > ---
> > common/rc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/common/rc b/common/rc
> > index 649b1cfd..f3bb665e 100644
> > --- a/common/rc
> > +++ b/common/rc
> > @@ -3112,7 +3112,7 @@ _test_inode_flag()
> > local flag=$1
> > local file=$2
> >
> > - if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | grep -q "$flag" ; then
> > + if $XFS_IO_PROG -r -c 'lsattr -v' "$file" | _filter_scratch |
> > _filter_test_dir | grep -q "$flag" ; then
> Hi XiaoLi,
>
> Is it ok to use _filter_testdir_and_scratch directly?
Yes, it's. _filter_testdir_and_scratch is better. Thanks for your reviewing.
>
> Best Regards,
> Xiao Yang
> > return 0
> > fi
> > return 1
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-18 8:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-10 8:34 [PATCH v2] common/rc: add filter in _test_inode_flag XiaoLi Feng
2021-02-18 6:30 ` Xiao Yang
2021-02-18 8:49 ` Xiaoli Feng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox