From: David Sterba <dsterba@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Brian Foster <bfoster@redhat.com>,
Qu Wenruo <quwenruo@cn.fujitsu.com>,
fstests@vger.kernel.org, btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: Is is possible to submit binary image as fstest test case?
Date: Fri, 7 Oct 2016 17:51:55 +0200 [thread overview]
Message-ID: <20161007155155.GC11398@twin.jikos.cz> (raw)
In-Reply-To: <20161006192452.qj3stqmhhz5cq3wj@thunk.org>
On Thu, Oct 06, 2016 at 03:24:52PM -0400, Theodore Ts'o wrote:
> On Thu, Oct 06, 2016 at 08:29:28AM -0400, Brian Foster wrote:
> > Doesn't necessarily bother me one way or the other, but something we've
> > done with XFS in such situations is introduce a DEBUG mode only sysfs
> > tunable that delays certain infrastructure (log recovery in our case) to
> > coordinate with test cases that try to reproduce such timing/racing
> > problems.
>
> The other approach the btrfs folks might consider is to have a
> sufficiently powerful "debugfs" or "xfs_db" program that can generate
> test images with the desired property.
We can generate certain classes of testing images, eg. by mkfs, adding
files and then corrupting specific keys after unmount. This could be
unreliable for timing-dependent bugs, or catching some intermediate
filesystem state that is created by kernel for free but would be tedious
to recreate manually from scratch in userspace.
> I've found that the time I've invested in creating debugfs has repaid
> itself a hundred times over, especially when maintaining a regression
> test suite for e2fsck.
I agree that's a good thing.
next prev parent reply other threads:[~2016-10-07 15:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 8:12 Is is possible to submit binary image as fstest test case? Qu Wenruo
2016-10-06 12:29 ` Brian Foster
2016-10-06 19:24 ` Theodore Ts'o
2016-10-07 15:51 ` David Sterba [this message]
2016-10-07 9:18 ` Dave Chinner
2016-10-07 9:26 ` Qu Wenruo
2016-10-07 10:19 ` Dave Chinner
2016-10-07 16:16 ` David Sterba
2016-10-08 3:28 ` Qu Wenruo
2016-10-07 16:05 ` David Sterba
2016-10-09 23:56 ` Dave Chinner
2016-10-14 18:11 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007155155.GC11398@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=bfoster@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox