From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: Dave Chinner <david@fromorbit.com>,
fstests@vger.kernel.org, btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: Is is possible to submit binary image as fstest test case?
Date: Fri, 7 Oct 2016 18:16:45 +0200 [thread overview]
Message-ID: <20161007161645.GE11398@twin.jikos.cz> (raw)
In-Reply-To: <f5f273e4-6d78-9ccd-64bf-480be7f05fbc@cn.fujitsu.com>
On Fri, Oct 07, 2016 at 05:26:27PM +0800, Qu Wenruo wrote:
> > Preferably not. We've managed to avoid pre-built images in xfstests
> > for 15 years, so there'd have to be a really good reason to start
> > doing this, especially as once we open that floodgate we'll end up
> > with everyone wanting to do this and it will blow out the size of
> > the repository in now time.
>
> Makes sense.
> For btrfs-progs, which includes test images, it already takes about 77M,
> even we have tried our best to reduce image size.
The number 77M is bogus. Clean checkout of the kernel.org repository is
15M in total, the .git directory is 5M and all the images are 7.3MB in
total. We're not close to any scary numbers yet. Should we need large
images, I'll create a separate repository for that.
> > If the issue is just timing or being unable to trigger an error
> > at the right time, this is what error injection frameworks or
> > debug-only sysfs hooks are for. The XFS kernel code has both,
> > xfstests use both, and they pretty much do away with the need for
> > custom binary filesystem images for such testing...
>
> So again, btrfs is lacking infrastructure for debug.
Depends what exactly you need. IIRC Filipe once submitted a patch for
transaction failure injection but then realzied that he could achieve
the same using the flaky device. You can try to take a snapshot of the
block device after using the freeze syscall. More specific tasks would
need code support. You definetelly know about the btrfs-corrupt-block
utility so you can use it to creatively damage the filesystem structures.
next prev parent reply other threads:[~2016-10-07 16:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 8:12 Is is possible to submit binary image as fstest test case? Qu Wenruo
2016-10-06 12:29 ` Brian Foster
2016-10-06 19:24 ` Theodore Ts'o
2016-10-07 15:51 ` David Sterba
2016-10-07 9:18 ` Dave Chinner
2016-10-07 9:26 ` Qu Wenruo
2016-10-07 10:19 ` Dave Chinner
2016-10-07 16:16 ` David Sterba [this message]
2016-10-08 3:28 ` Qu Wenruo
2016-10-07 16:05 ` David Sterba
2016-10-09 23:56 ` Dave Chinner
2016-10-14 18:11 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007161645.GE11398@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox