public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v2] Code to allow cros-compilation on chromeOS
Date: Mon, 27 Mar 2017 19:35:37 +0800	[thread overview]
Message-ID: <20170327113537.GR14226@eguan.usersys.redhat.com> (raw)
In-Reply-To: <20170324234800.23674-1-gwendal@chromium.org>

On Fri, Mar 24, 2017 at 04:48:00PM -0700, Gwendal Grignou wrote:
> - Request LIBTOOL to be used
> - Set topbuildir based on a Makefile variable to call libtool
> - Use /usr/local instead of /var for xfstest final location
> - Move macros from aclocal.m4 to acinclude.m4, aclocal.m4 is autogenerated.
> 
> The regular way of compiling xfstests - make - remains.
> But it now runs autoreconf and libtoolize -i to produce a valid
> configure.
> Verified compiling in chromeOS chroot works as well.

This works for me now, thanks!

But I noticed that the "/usr/local" location is only used if DESTDIR is
defined, otherwise it defaults to /var/lib, this seems inconsistent. Is
it possible, e.g. to define another var, to control the location and
make "/var/lib" as the default?

And again, I really appreciate if someone else with more packaging
experience could help review this patch!

Thanks,
Eryu
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  https://urldefense.proofpoint.com/v2/url?u=http-3A__vger.kernel.org_majordomo-2Dinfo.html&d=DwIBAg&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=-yMrTV4jriXR7ieyzzjV-QgHBD0UDw8ixoR77aMeAHE&m=ukLPNj4j4uFJyDwWW7Eu3T83sCjYPH-2y0Pk7dzkaBc&s=YFXsKIOjJ40JxbMAtZHJFLRCc_nS_pISTYYzZBM5lRw&e= 

  reply	other threads:[~2017-03-27 11:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAMHSBOXjP4QOGmM2HxygY0r+ML93XyEmLEfwGz6KvS0S0sjuCA@mail.gmail.com>
2017-03-24 23:48 ` [PATCH v2] Code to allow cros-compilation on chromeOS Gwendal Grignou
2017-03-27 11:35   ` Eryu Guan [this message]
2017-04-04 17:37     ` [PATCH v3] " Gwendal Grignou
2017-04-06 11:18       ` Eryu Guan
2017-04-06 23:26         ` Gwendal Grignou
2017-04-07  4:12           ` Eryu Guan
2017-04-07 21:41             ` Gwendal Grignou
2017-04-10  9:25               ` Eryu Guan
2017-04-19 21:59                 ` Gwendal Grignou
2017-04-19 23:33                   ` [PATCH v4] " Gwendal Grignou
2017-04-25 13:09                     ` Eryu Guan
2017-05-08 10:19                       ` Xiao Yang
2017-05-08 10:50                         ` Eryu Guan
2017-05-08 11:19                           ` Xiao Yang
2017-05-08 21:22                             ` Gwendal Grignou
2017-05-09  1:37                               ` Xiao Yang
2017-05-09  7:12                           ` Xiao Yang
2017-05-12  6:04                             ` Xiao Yang
2017-05-12  8:12                               ` Eryu Guan
2017-04-28 16:27                     ` [PATCH v5] " Gwendal Grignou
2017-04-28 16:58                       ` Gwendal Grignou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170327113537.GR14226@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=gwendal@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox