public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Xiao Yang <yangx.jy@cn.fujitsu.com>
Cc: Gwendal Grignou <gwendal@chromium.org>, fstests@vger.kernel.org
Subject: Re: [PATCH v4] Code to allow cros-compilation on chromeOS
Date: Fri, 12 May 2017 16:12:28 +0800	[thread overview]
Message-ID: <20170512081228.GO7250@eguan.usersys.redhat.com> (raw)
In-Reply-To: <59155058.4070200@cn.fujitsu.com>

On Fri, May 12, 2017 at 02:04:08PM +0800, Xiao Yang wrote:
> Hi Eryu
> 
> I tried to use higher version autoconf (e.g,
> autoconf-2.65-1.fc13.noarch.rpm) to compile the lastest xfstests on
> RHEL6.9GA, and
> it worked fine.   Shoud we update  autoconf-2.63-5.1.el6.noarch on RHEL6.9GA
> or fix xfstests to adapt to older version autoconf? :-)

Sorry for the late response, because I'm still wondering why it worked
fine on my RHEL6.9 test host, it has the same version of autoconf,
automake, libtool etc. as you installed.

But this is an relatively low priority task for me, because RHEL6 is in
its late stage, no new features will be added, and non-critical bugs are
unlikely to get fixed, so testing on RHEL6 is relatively low priority
too.

Thanks for all the effort you made so far on this issue!

Eryu

> 
> Thanks,
> Xiao Yang.
> On 2017/05/09 15:12, Xiao Yang wrote:
> > On 2017/05/08 18:50, Eryu Guan wrote:
> > > On Mon, May 08, 2017 at 06:19:27PM +0800, Xiao Yang wrote:
> > > > On 2017/04/25 21:09, Eryu Guan wrote:
> > > > > On Wed, Apr 19, 2017 at 04:33:48PM -0700, Gwendal Grignou wrote:
> > > > > > - Request LIBTOOL to be used
> > > > > > - Set topbuildir based on a Makefile variable to call libtool
> > > > > > - Use /usr/local instead of /var for xfstest final location
> > > > > > - Move macros from aclocal.m4 to acinclude.m4,
> > > > > > aclocal.m4 is autogenerated.
> > > > > > - Use autoconf variables @prefix@, @exec_prefix@.
> > > > > > 
> > > > > > The regular way of compiling xfstests - make - remains.
> > > > > > But it now runs autoreconf and libtoolize -i to produce a valid
> > > > > > configure.
> > > > > > Verified with 'make install --dry-run' that files are
> > > > > > installed at the
> > > > > > same place.
> > > > > > Verified compiling in chromeOS chroot works as well.
> > > > > > 
> > > > > > Signed-off-by: Gwendal Grignou<gwendal@chromium.org>
> > > > > > ---
> > > > > > 
> > > > > > Changes in v2:
> > > > > > Removal of instal-sh, use of autoreconf
> > > > > > 
> > > > > > Changes in v3:
> > > > > > Use of @exec_prefix@ variable, unify installation location.
> > > > > > 
> > > > > > Changes in v4:
> > > > > > Add --install option to autoreconf so that aclocal is
> > > > > > called with -I m4.
> > > > > > Keep using AC_CONFIG_MACRO_DIR when autoconf is called directly.
> > > > > > With --install option and AC_CONFIG_MACRO_DIR undefined
> > > > > > verify that configure
> > > > > > still works.
> > > > > Thanks a lot for the update! v4 works for me too with RHEL6, RHEL7 and
> > > > > Fedora 25 hosts.
> > > > > 
> > > > Hi Eryu
> > > > 
> > > > When appling v4 patch, i still got the following error messgae
> > > > on RHEL6.9GA:
> > > > ============================================================================
> > > > 
> > > > [root@RHEL6U9GA_Intel64 xfstests]# make
> > > > autoreconf --include=m4
> > > > configure.ac:5: error: possibly undefined macro: AC_PACKAGE_GLOBALS
> > > > If this token and others are legitimate, please use m4_pattern_allow.
> > > > See the Autoconf documentation.
> > > > configure.ac:6: error: possibly undefined macro: AC_PACKAGE_UTILITIES
> > > > configure.ac:43: error: possibly undefined macro:
> > > > AC_PACKAGE_NEED_UUIDCOMPARE
> > > > configure.ac:48: error: possibly undefined macro:
> > > > AC_PACKAGE_NEED_SYS_ACL_H
> > > > configure.ac:49: error: possibly undefined macro:
> > > > AC_PACKAGE_NEED_ATTRIBUTES_H
> > > > configure.ac:50: error: possibly undefined macro: AC_PACKAGE_WANT_NDBM
> > > > configure.ac:51: error: possibly undefined macro:
> > > > AC_PACKAGE_NEED_IRIX_LIBHANDLE
> > > > configure.ac:56: error: possibly undefined macro: AC_MULTILIB
> > > > configure.ac:57: error: possibly undefined macro:
> > > > AC_PACKAGE_NEED_XFS_XFS_H
> > > > configure.ac:58: error: possibly undefined macro:
> > > > AC_PACKAGE_WANT_LIBXFS_H
> > > > configure.ac:59: error: possibly undefined macro:
> > > > AC_PACKAGE_WANT_XLOG_ASSIGN_LSN
> > > > configure.ac:60: error: possibly undefined macro:
> > > > AC_PACKAGE_NEED_XFS_XQM_H
> > > > configure.ac:61: error: possibly undefined macro:
> > > > AC_PACKAGE_NEED_XFSCTL_MACRO
> > > > configure.ac:62: error: possibly undefined macro:
> > > > AC_PACKAGE_NEED_XFS_HANDLE_H
> > > > configure.ac:64: error: possibly undefined macro:
> > > > AC_PACKAGE_NEED_ATTRLIST_LIBHANDLE
> > > > configure.ac:65: error: possibly undefined macro:
> > > > AC_PACKAGE_NEED_ATTR_XATTR_H
> > > > configure.ac:67: error: possibly undefined macro:
> > > > AC_PACKAGE_WANT_ATTRLIST_LIBATTR
> > > > configure.ac:68: error: possibly undefined macro:
> > > > AC_PACKAGE_NEED_GETXATTR_LIBATTR
> > > > configure.ac:71: error: possibly undefined macro:
> > > > AC_PACKAGE_NEED_ACL_LIBACL_H
> > > > configure.ac:72: error: possibly undefined macro:
> > > > AC_PACKAGE_NEED_ACLINIT_LIBACL
> > > > configure.ac:74: error: possibly undefined macro: AC_PACKAGE_WANT_GDBM
> > > > configure.ac:75: error: possibly undefined macro: AC_PACKAGE_WANT_AIO
> > > > configure.ac:76: error: possibly undefined macro: AC_PACKAGE_WANT_DMAPI
> > > > configure.ac:82: error: possibly undefined macro: AC_PACKAGE_WANT_SSL
> > > > autoreconf: /usr/bin/autoconf failed with exit status: 1
> > > > make: *** [configure] Error 1
> > > > [root@RHEL6U9GA_Intel64 xfstests]# uname -r
> > > > 2.6.32-696.el6.x86_64
> > > > [root@RHEL6U9GA_Intel64 ~]# rpm -q automake autoconf m4 libtool
> > > > automake-1.11.1-4.el6.noarch
> > > > autoconf-2.63-5.1.el6.noarch
> > > > m4-1.4.13-5.el6.x86_64
> > > > libtool-2.2.6-15.5.el6.x86_64
> > > > ============================================================================
> > > > 
> > > > 
> > > > autoreconf with --include m4 may not fix undefined macro on RHEL6.9GA,
> > > > do you have the same issue?
> > > No, make works fine on my RHEL6.9 host. And this patch should be pushed
> > > to upstream already. Does 'make realclean' make any difference? Does a
> > > clean 'git clone' work for you?
> > > 
> > > Thanks,
> > > Eryu
> > > 
> > > 
> > Hi Eryu and Gwendal,
> > 
> > I found that autoreconf could not pass -I/--include option to aclocal in
> > autoconf-2.63-5.1.el6.noarch on RHEL6.9GA.
> > This bug has been fixed by the following patch:
> > http://git.savannah.gnu.org/gitweb/?p=autoconf.git;a=commit;h=44fbeef86d03f2b754a4444e38f38631ad318946
> > 
> > 
> > This fixed patch was not merged into autoconf-2.63-5.1.el6.noarch.  I
> > tried to apply this patch into autoconf-2.63-5.1.el6.noarch,
> > so make worked fine in xfstests on RHEL6.9GA.  How can we workaroud this
> > issue?
> > 
> > Thanks,
> > Xiao Yang
> > > .
> > > 
> > 
> > 
> > 
> > -- 
> > To unsubscribe from this list: send the line "unsubscribe fstests" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > .
> > 
> 
> 
> 

  reply	other threads:[~2017-05-12  8:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAMHSBOXjP4QOGmM2HxygY0r+ML93XyEmLEfwGz6KvS0S0sjuCA@mail.gmail.com>
2017-03-24 23:48 ` [PATCH v2] Code to allow cros-compilation on chromeOS Gwendal Grignou
2017-03-27 11:35   ` Eryu Guan
2017-04-04 17:37     ` [PATCH v3] " Gwendal Grignou
2017-04-06 11:18       ` Eryu Guan
2017-04-06 23:26         ` Gwendal Grignou
2017-04-07  4:12           ` Eryu Guan
2017-04-07 21:41             ` Gwendal Grignou
2017-04-10  9:25               ` Eryu Guan
2017-04-19 21:59                 ` Gwendal Grignou
2017-04-19 23:33                   ` [PATCH v4] " Gwendal Grignou
2017-04-25 13:09                     ` Eryu Guan
2017-05-08 10:19                       ` Xiao Yang
2017-05-08 10:50                         ` Eryu Guan
2017-05-08 11:19                           ` Xiao Yang
2017-05-08 21:22                             ` Gwendal Grignou
2017-05-09  1:37                               ` Xiao Yang
2017-05-09  7:12                           ` Xiao Yang
2017-05-12  6:04                             ` Xiao Yang
2017-05-12  8:12                               ` Eryu Guan [this message]
2017-04-28 16:27                     ` [PATCH v5] " Gwendal Grignou
2017-04-28 16:58                       ` Gwendal Grignou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170512081228.GO7250@eguan.usersys.redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=gwendal@chromium.org \
    --cc=yangx.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox