[PATCH] generic/449: remove unused _require_test

[PATCH] generic/449: remove unused _require_test

[Xiao Yang]

Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
 tests/generic/449 | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/generic/449 b/tests/generic/449
index fb776b3..755a84a 100755
--- a/tests/generic/449
+++ b/tests/generic/449
@@ -52,7 +52,6 @@ rm -f $seqres.full
 _supported_fs generic
 _supported_os Linux
 _require_scratch
-_require_test
 _require_acls
 _require_attrs
 
-- 
1.8.3.1

Re: [PATCH] generic/449: remove unused _require_test

[Ernesto A. Fernández]

On Mon, Jul 24, 2017 at 02:57:38PM +0800, Xiao Yang wrote:
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
>  _supported_fs generic
>  _supported_os Linux
>  _require_scratch
> -_require_test
>  _require_acls
>  _require_attrs

Hi, I wrote that test, thank you for taking the time to review it.

It would seem that _require_acls uses the test device, things could get
weird if it's not there.

Re: [PATCH] generic/449: remove unused _require_test

[Xiao Yang]

On 2017/07/30 11:27, Ernesto A. Fernández wrote:
> On Mon, Jul 24, 2017 at 02:57:38PM +0800, Xiao Yang wrote:
>> Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
>>   _supported_fs generic
>>   _supported_os Linux
>>   _require_scratch
>> -_require_test
>>   _require_acls
>>   _require_attrs
> Hi, I wrote that test, thank you for taking the time to review it.
>
> It would seem that _require_acls uses the test device, things could get
> weird if it's not there.
>
>
Hi Ernesto A and Eryu,

init_rc() have checked if TEST_DEV existed and was mounted, and we 
introduced _require_test to check
file system consistency on TEST_DEV after running tests.   I think it's 
not necessary to add _require_test.

I'm not sure about it, so cc Eryu to confirm it.

Thanks,
Xiao Yang.

Re: [PATCH] generic/449: remove unused _require_test

[Ernesto A. Fernández]

On Mon, Jul 31, 2017 at 11:38:43AM +0800, Xiao Yang wrote:
> On 2017/07/30 11:27, Ernesto A. Fernández wrote:
> >On Mon, Jul 24, 2017 at 02:57:38PM +0800, Xiao Yang wrote:
> >>Signed-off-by: Xiao Yang<yangx.jy@cn.fujitsu.com>
> >>  _supported_fs generic
> >>  _supported_os Linux
> >>  _require_scratch
> >>-_require_test
> >>  _require_acls
> >>  _require_attrs
> >Hi, I wrote that test, thank you for taking the time to review it.
> >
> >It would seem that _require_acls uses the test device, things could get
> >weird if it's not there.
> >
> >
> Hi Ernesto A and Eryu,
> 
> init_rc() have checked if TEST_DEV existed and was mounted, and we
> introduced _require_test to check
> file system consistency on TEST_DEV after running tests.   I think it's not
> necessary to add _require_test.

Ah, I understand now, you are right. My confusion was because _require_test
makes the whole check for TEST_DEV again, and even tries to mount it. I
don't know why that is. Also the header comment of _require_test doesn't
mention the consistency check, perhaps it should.

> I'm not sure about it, so cc Eryu to confirm it.
> 
> Thanks,
> Xiao Yang.