* [PATCH 0/2] Fix some _require_* checks for filesystem features
@ 2018-01-30 13:54 Rostislav Skudnov
2018-01-30 13:54 ` [PATCH 1/2] generic/307: Require ACL support Rostislav Skudnov
2018-01-30 13:54 ` [PATCH 2/2] generic/{274,315}: Require falloc -k support Rostislav Skudnov
0 siblings, 2 replies; 6+ messages in thread
From: Rostislav Skudnov @ 2018-01-30 13:54 UTC (permalink / raw)
To: fstests
In a few generic tests some filesystem features are not checked (ACLs in
generic/307) or are checked incorrectly (test for fallocate() with
FALLOC_FL_KEEP_SIZE is missing in generic/{274,315}). Fix these problems by
adding appropriate _require_* checks.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] generic/307: Require ACL support
2018-01-30 13:54 [PATCH 0/2] Fix some _require_* checks for filesystem features Rostislav Skudnov
@ 2018-01-30 13:54 ` Rostislav Skudnov
2018-01-30 16:16 ` Darrick J. Wong
2018-02-03 5:06 ` Eryu Guan
2018-01-30 13:54 ` [PATCH 2/2] generic/{274,315}: Require falloc -k support Rostislav Skudnov
1 sibling, 2 replies; 6+ messages in thread
From: Rostislav Skudnov @ 2018-01-30 13:54 UTC (permalink / raw)
To: fstests
Signed-off-by: Rostislav Skudnov <rostislav@tuxera.com>
---
tests/generic/307 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/generic/307 b/tests/generic/307
index f5d0680..bbdc70f 100755
--- a/tests/generic/307
+++ b/tests/generic/307
@@ -51,6 +51,7 @@ testfile=$SCRATCH_MNT/testfile.$seq
_supported_fs generic
_supported_os Linux
_require_scratch
+_require_acls
echo "Silence is golden"
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] generic/307: Require ACL support
2018-01-30 13:54 ` [PATCH 1/2] generic/307: Require ACL support Rostislav Skudnov
@ 2018-01-30 16:16 ` Darrick J. Wong
2018-02-03 5:06 ` Eryu Guan
1 sibling, 0 replies; 6+ messages in thread
From: Darrick J. Wong @ 2018-01-30 16:16 UTC (permalink / raw)
To: Rostislav Skudnov; +Cc: fstests
On Tue, Jan 30, 2018 at 01:54:58PM +0000, Rostislav Skudnov wrote:
> Signed-off-by: Rostislav Skudnov <rostislav@tuxera.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/generic/307 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/307 b/tests/generic/307
> index f5d0680..bbdc70f 100755
> --- a/tests/generic/307
> +++ b/tests/generic/307
> @@ -51,6 +51,7 @@ testfile=$SCRATCH_MNT/testfile.$seq
> _supported_fs generic
> _supported_os Linux
> _require_scratch
> +_require_acls
>
> echo "Silence is golden"
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] generic/307: Require ACL support
2018-01-30 13:54 ` [PATCH 1/2] generic/307: Require ACL support Rostislav Skudnov
2018-01-30 16:16 ` Darrick J. Wong
@ 2018-02-03 5:06 ` Eryu Guan
1 sibling, 0 replies; 6+ messages in thread
From: Eryu Guan @ 2018-02-03 5:06 UTC (permalink / raw)
To: Rostislav Skudnov; +Cc: fstests
On Tue, Jan 30, 2018 at 01:54:58PM +0000, Rostislav Skudnov wrote:
> Signed-off-by: Rostislav Skudnov <rostislav@tuxera.com>
> ---
> tests/generic/307 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/generic/307 b/tests/generic/307
> index f5d0680..bbdc70f 100755
> --- a/tests/generic/307
> +++ b/tests/generic/307
> @@ -51,6 +51,7 @@ testfile=$SCRATCH_MNT/testfile.$seq
> _supported_fs generic
> _supported_os Linux
> _require_scratch
> +_require_acls
I added ". common/attr" to use _require_acls, as I saw failure in my
release testing:
+./tests/generic/307: line 54: _require_acls: command not found
Thanks,
Eryu
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] generic/{274,315}: Require falloc -k support
2018-01-30 13:54 [PATCH 0/2] Fix some _require_* checks for filesystem features Rostislav Skudnov
2018-01-30 13:54 ` [PATCH 1/2] generic/307: Require ACL support Rostislav Skudnov
@ 2018-01-30 13:54 ` Rostislav Skudnov
2018-01-30 16:14 ` Darrick J. Wong
1 sibling, 1 reply; 6+ messages in thread
From: Rostislav Skudnov @ 2018-01-30 13:54 UTC (permalink / raw)
To: fstests
These test cases require filesystem support for FALLOC_FL_KEEP_SIZE
flag in fallocate().
Signed-off-by: Rostislav Skudnov <rostislav@tuxera.com>
---
tests/generic/274 | 2 +-
tests/generic/315 | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/generic/274 b/tests/generic/274
index 7d09386..a3f8c75 100755
--- a/tests/generic/274
+++ b/tests/generic/274
@@ -48,7 +48,7 @@ _cleanup()
_supported_fs generic
_supported_os Linux
_require_scratch
-_require_xfs_io_command "falloc"
+_require_xfs_io_command "falloc" "-k"
echo "------------------------------"
echo "preallocation test"
diff --git a/tests/generic/315 b/tests/generic/315
index 4433b6c..954f8a9 100755
--- a/tests/generic/315
+++ b/tests/generic/315
@@ -49,7 +49,7 @@ _cleanup()
_supported_fs generic
_supported_os Linux
_require_test
-_require_xfs_io_command "falloc"
+_require_xfs_io_command "falloc" "-k"
rm -f $seqres.full
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] generic/{274,315}: Require falloc -k support
2018-01-30 13:54 ` [PATCH 2/2] generic/{274,315}: Require falloc -k support Rostislav Skudnov
@ 2018-01-30 16:14 ` Darrick J. Wong
0 siblings, 0 replies; 6+ messages in thread
From: Darrick J. Wong @ 2018-01-30 16:14 UTC (permalink / raw)
To: Rostislav Skudnov; +Cc: fstests
On Tue, Jan 30, 2018 at 01:54:59PM +0000, Rostislav Skudnov wrote:
> These test cases require filesystem support for FALLOC_FL_KEEP_SIZE
> flag in fallocate().
>
> Signed-off-by: Rostislav Skudnov <rostislav@tuxera.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/generic/274 | 2 +-
> tests/generic/315 | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/generic/274 b/tests/generic/274
> index 7d09386..a3f8c75 100755
> --- a/tests/generic/274
> +++ b/tests/generic/274
> @@ -48,7 +48,7 @@ _cleanup()
> _supported_fs generic
> _supported_os Linux
> _require_scratch
> -_require_xfs_io_command "falloc"
> +_require_xfs_io_command "falloc" "-k"
>
> echo "------------------------------"
> echo "preallocation test"
> diff --git a/tests/generic/315 b/tests/generic/315
> index 4433b6c..954f8a9 100755
> --- a/tests/generic/315
> +++ b/tests/generic/315
> @@ -49,7 +49,7 @@ _cleanup()
> _supported_fs generic
> _supported_os Linux
> _require_test
> -_require_xfs_io_command "falloc"
> +_require_xfs_io_command "falloc" "-k"
>
> rm -f $seqres.full
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-03 5:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-30 13:54 [PATCH 0/2] Fix some _require_* checks for filesystem features Rostislav Skudnov
2018-01-30 13:54 ` [PATCH 1/2] generic/307: Require ACL support Rostislav Skudnov
2018-01-30 16:16 ` Darrick J. Wong
2018-02-03 5:06 ` Eryu Guan
2018-01-30 13:54 ` [PATCH 2/2] generic/{274,315}: Require falloc -k support Rostislav Skudnov
2018-01-30 16:14 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox