public inbox for fstests@vger.kernel.org
 help / color / mirror / Atom feed
From: jeffm@suse.com
To: xfstests list <fstests@vger.kernel.org>
Cc: Luis Rodriguez <mcgrof@suse.com>, Eryu Guan <eguan@redhat.com>,
	Jeff Mahoney <jeffm@suse.com>
Subject: [PATCH 0/4] fstests: GDBM detection cleanup
Date: Thu, 15 Mar 2018 17:54:51 -0400	[thread overview]
Message-ID: <20180315215455.8245-1-jeffm@suse.com> (raw)

From: Jeff Mahoney <jeffm@suse.com>

Commit 2353022 (build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c
to build) fixed building on newer SUSE systems but broke older ones.  Where
we used to skip building src/dbtest on SLES systems, now we'd fail
to build on SLES11.  The reason was that we were now detecting
ndbm.h but also including gdbm.h, which doesn't work on older systems due
to both defining the datum type.  It turns out that no system needs
gdbm.h at all.

This series cleans up the macros and fixes detection for all systems that
only have /usr/include/ndbm.h.

-Jeff

---

Jeff Mahoney (4):
  build: remove dead AC_PACKAGE_WANT_NDBM macro
  build: AC_PACKAGE_WANT_GDBM, fall back to compat if libgdbm detection
    fails
  build: clean up AC_PACKAGE_WANT_GDBM
  build: fix <ndbm.h> detection in AC_PACKAGE_WANT_GDBM

 m4/package_gdbmdev.m4 | 104 ++++++++++++++++++++++----------------------------
 src/dbtest.c          |   3 --
 2 files changed, 46 insertions(+), 61 deletions(-)

-- 
2.15.1


             reply	other threads:[~2018-03-15 21:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 21:54 jeffm [this message]
2018-03-15 21:54 ` [PATCH 1/4] build: remove dead AC_PACKAGE_WANT_NDBM macro jeffm
2018-03-15 21:54 ` [PATCH 2/4] build: AC_PACKAGE_WANT_GDBM, fall back to compat if libgdbm detection fails jeffm
2018-03-15 21:54 ` [PATCH 3/4] build: clean up AC_PACKAGE_WANT_GDBM jeffm
2018-03-15 21:54 ` [PATCH 4/4] build: fix <ndbm.h> detection in AC_PACKAGE_WANT_GDBM jeffm
2018-03-23  3:30 ` [PATCH 0/4] fstests: GDBM detection cleanup Eryu Guan
  -- strict thread matches above, loose matches on Subject: below --
2018-03-15 21:53 jeffm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180315215455.8245-1-jeffm@suse.com \
    --to=jeffm@suse.com \
    --cc=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=mcgrof@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox