Re: [PATCH 0/4] fstests: GDBM detection cleanup

[Eryu Guan <guaneryu@gmail.com>]

On Thu, Mar 15, 2018 at 05:54:51PM -0400, jeffm@suse.com wrote:
> From: Jeff Mahoney <jeffm@suse.com>
> 
> Commit 2353022 (build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c
> to build) fixed building on newer SUSE systems but broke older ones.  Where
> we used to skip building src/dbtest on SLES systems, now we'd fail
> to build on SLES11.  The reason was that we were now detecting
> ndbm.h but also including gdbm.h, which doesn't work on older systems due
> to both defining the datum type.  It turns out that no system needs
> gdbm.h at all.
> 
> This series cleans up the macros and fixes detection for all systems that
> only have /usr/include/ndbm.h.

Thanks for the fixes and cleanups! I tested them on Fedora 27, RHEL7 and
Debian stretch, with/without gdbm devel package installed, all worked
fine. But I don't have SUSE systems by hand, I assume you've tested them
successfully.

Thanks,
Eryu