From: jeffm@suse.com
To: xfstests list <fstests@vger.kernel.org>
Cc: Luis Rodriguez <mcgrof@suse.com>, Eryu Guan <eguan@redhat.com>,
Jeff Mahoney <jeffm@suse.com>
Subject: [PATCH 4/4] build: fix <ndbm.h> detection in AC_PACKAGE_WANT_GDBM
Date: Thu, 15 Mar 2018 17:54:55 -0400 [thread overview]
Message-ID: <20180315215455.8245-5-jeffm@suse.com> (raw)
In-Reply-To: <20180315215455.8245-1-jeffm@suse.com>
From: Jeff Mahoney <jeffm@suse.com>
SUSE systems export the NDBM interface via /usr/include/ndbm.h
This means that dbtest wasn't built on SUSE systems until
commit 2353022 (build: update AC_PACKAGE_WANT_GDBM() and src/dbtest.c
to build). That change was incompatible with older
SLES releases due to <ndbm.h> and <gdbm.h> both defining the datum
type, resulting in build failures.
Nothing has ever set HAVE_GDBM_H or checked for the <gdbm.h> header
prior to the above commit, and it's not required on SUSE systems
either, so just remove that entirely.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
m4/package_gdbmdev.m4 | 20 +++-----------------
src/dbtest.c | 3 ---
2 files changed, 3 insertions(+), 20 deletions(-)
diff --git a/m4/package_gdbmdev.m4 b/m4/package_gdbmdev.m4
index 922cbcbc..723900fc 100644
--- a/m4/package_gdbmdev.m4
+++ b/m4/package_gdbmdev.m4
@@ -22,26 +22,12 @@ AC_DEFUN([AC_PACKAGE_WANT_GDBM],
fi
if test -z "$have_db"; then
- AC_CHECK_HEADER(gdbm.h,
- [
- have_db=true
- gdbm_ndbm_=true
- ], [
- have_db=false
- gdbm_ndbm_=false
- ])
AC_CHECK_HEADER(ndbm.h,
[
- ndbm_=true
- ], [
- ndbm_=false
+ have_db=true
+ AC_DEFINE(HAVE_NDBM_H, [1],
+ [Define to 1 if you have the <ndbm.h> header file.])
])
- if test $gdbm_ndbm_ = true; then
- if test $ndbm_ = true; then
- AC_DEFINE(HAVE_GDBM_H, [1],
- [Define to 1 if you have both <gdbm.h> and <ndbm.h> header files.])
- fi
- fi
fi
if test "$have_db" = true; then
diff --git a/src/dbtest.c b/src/dbtest.c
index f45db4ac..4366dcdf 100644
--- a/src/dbtest.c
+++ b/src/dbtest.c
@@ -22,9 +22,6 @@
#include <gdbm/ndbm.h>
#elif HAVE_GDBM_NDBM_H
#include <gdbm-ndbm.h>
-#elif HAVE_GDBM_H
-#include <gdbm.h>
-#include <ndbm.h>
#elif HAVE_NDBM_H
#include <ndbm.h>
#else
--
2.15.1
next prev parent reply other threads:[~2018-03-15 21:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 21:54 [PATCH 0/4] fstests: GDBM detection cleanup jeffm
2018-03-15 21:54 ` [PATCH 1/4] build: remove dead AC_PACKAGE_WANT_NDBM macro jeffm
2018-03-15 21:54 ` [PATCH 2/4] build: AC_PACKAGE_WANT_GDBM, fall back to compat if libgdbm detection fails jeffm
2018-03-15 21:54 ` [PATCH 3/4] build: clean up AC_PACKAGE_WANT_GDBM jeffm
2018-03-15 21:54 ` jeffm [this message]
2018-03-23 3:30 ` [PATCH 0/4] fstests: GDBM detection cleanup Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315215455.8245-5-jeffm@suse.com \
--to=jeffm@suse.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=mcgrof@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox