* [PATCH] shared/010: avoid dedupe testing blocked on large fs
@ 2018-09-12 10:15 Zorro Lang
2018-09-13 16:28 ` Eric Sandeen
2018-09-13 23:01 ` Dave Chinner
0 siblings, 2 replies; 6+ messages in thread
From: Zorro Lang @ 2018-09-12 10:15 UTC (permalink / raw)
To: fstests
When test on large fs (--large-fs), xfstests preallocates a large
file in SCRATCH_MNT/ at first. Duperemove will take too long time
to deal with that large file (many days on 500T XFS). So move
working directory to a sub-dir underlying $SCRATCH_MNT/.
Signed-off-by: Zorro Lang <zlang@redhat.com>
---
Hi,
Besides fix this issue, this patch fix another issue passingly. I left
a bad variable named "testdir" in this case. This patch can fix it.
If maintainer feels I should fix it in another patch, please tell me:-P
Thanks,
Zorro
tests/shared/010 | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/shared/010 b/tests/shared/010
index 1817081b..04f55890 100755
--- a/tests/shared/010
+++ b/tests/shared/010
@@ -65,15 +65,17 @@ function end_test()
sleep_time=$((50 * TIME_FACTOR))
# Start fsstress
+testdir="$SCRATCH_MNT/dir"
+mkdir $testdir
fsstress_opts="-r -n 1000 -p $((5 * LOAD_FACTOR))"
-$FSSTRESS_PROG $fsstress_opts -d $SCRATCH_MNT -l 0 >> $seqres.full 2>&1 &
+$FSSTRESS_PROG $fsstress_opts -d $testdir -l 0 >> $seqres.full 2>&1 &
dedup_pids=""
dupe_run=$TEST_DIR/${seq}-running
# Start several dedupe processes on same directory
touch $dupe_run
for ((i = 0; i < $((2 * LOAD_FACTOR)); i++)); do
while [ -e $dupe_run ]; do
- $DUPEREMOVE_PROG -dr --dedupe-options=same $SCRATCH_MNT/ \
+ $DUPEREMOVE_PROG -dr --dedupe-options=same $testdir \
>>$seqres.full 2>&1
done &
dedup_pids="$! $dedup_pids"
--
2.14.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] shared/010: avoid dedupe testing blocked on large fs
2018-09-12 10:15 [PATCH] shared/010: avoid dedupe testing blocked on large fs Zorro Lang
@ 2018-09-13 16:28 ` Eric Sandeen
2018-09-14 1:10 ` Zorro Lang
2018-09-13 23:01 ` Dave Chinner
1 sibling, 1 reply; 6+ messages in thread
From: Eric Sandeen @ 2018-09-13 16:28 UTC (permalink / raw)
To: Zorro Lang, fstests
On 9/12/18 5:15 AM, Zorro Lang wrote:
> When test on large fs (--large-fs), xfstests preallocates a large
> file in SCRATCH_MNT/ at first. Duperemove will take too long time
> to deal with that large file (many days on 500T XFS). So move
> working directory to a sub-dir underlying $SCRATCH_MNT/.
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
Looks fine to me -
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
But - I'm not sure what you mean about "testdir?"
> ---
>
> Hi,
>
> Besides fix this issue, this patch fix another issue passingly. I left
> a bad variable named "testdir" in this case. This patch can fix it.
>
> If maintainer feels I should fix it in another patch, please tell me:-P
>
> Thanks,
> Zorro
>
> tests/shared/010 | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/shared/010 b/tests/shared/010
> index 1817081b..04f55890 100755
> --- a/tests/shared/010
> +++ b/tests/shared/010
> @@ -65,15 +65,17 @@ function end_test()
> sleep_time=$((50 * TIME_FACTOR))
>
> # Start fsstress
> +testdir="$SCRATCH_MNT/dir"
> +mkdir $testdir
> fsstress_opts="-r -n 1000 -p $((5 * LOAD_FACTOR))"
> -$FSSTRESS_PROG $fsstress_opts -d $SCRATCH_MNT -l 0 >> $seqres.full 2>&1 &
> +$FSSTRESS_PROG $fsstress_opts -d $testdir -l 0 >> $seqres.full 2>&1 &
> dedup_pids=""
> dupe_run=$TEST_DIR/${seq}-running
> # Start several dedupe processes on same directory
> touch $dupe_run
> for ((i = 0; i < $((2 * LOAD_FACTOR)); i++)); do
> while [ -e $dupe_run ]; do
> - $DUPEREMOVE_PROG -dr --dedupe-options=same $SCRATCH_MNT/ \
> + $DUPEREMOVE_PROG -dr --dedupe-options=same $testdir \
> >>$seqres.full 2>&1
> done &
> dedup_pids="$! $dedup_pids"
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] shared/010: avoid dedupe testing blocked on large fs
2018-09-13 16:28 ` Eric Sandeen
@ 2018-09-14 1:10 ` Zorro Lang
0 siblings, 0 replies; 6+ messages in thread
From: Zorro Lang @ 2018-09-14 1:10 UTC (permalink / raw)
To: Eric Sandeen; +Cc: fstests
On Thu, Sep 13, 2018 at 11:28:26AM -0500, Eric Sandeen wrote:
> On 9/12/18 5:15 AM, Zorro Lang wrote:
> > When test on large fs (--large-fs), xfstests preallocates a large
> > file in SCRATCH_MNT/ at first. Duperemove will take too long time
> > to deal with that large file (many days on 500T XFS). So move
> > working directory to a sub-dir underlying $SCRATCH_MNT/.
> >
> > Signed-off-by: Zorro Lang <zlang@redhat.com>
>
> Looks fine to me -
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>
> But - I'm not sure what you mean about "testdir?"
Read shared/010 before merge this patch, you'll find a "$testdir" on
this line:
find $testdir -type f -exec md5sum {} \; > ${tmp}.md5sum
But that "$testdir" never be assigned, it's a mistake I left :)
Thanks,
Zorro
>
> > ---
> >
> > Hi,
> >
> > Besides fix this issue, this patch fix another issue passingly. I left
> > a bad variable named "testdir" in this case. This patch can fix it.
> >
> > If maintainer feels I should fix it in another patch, please tell me:-P
> >
> > Thanks,
> > Zorro
> >
> > tests/shared/010 | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/shared/010 b/tests/shared/010
> > index 1817081b..04f55890 100755
> > --- a/tests/shared/010
> > +++ b/tests/shared/010
> > @@ -65,15 +65,17 @@ function end_test()
> > sleep_time=$((50 * TIME_FACTOR))
> >
> > # Start fsstress
> > +testdir="$SCRATCH_MNT/dir"
> > +mkdir $testdir
> > fsstress_opts="-r -n 1000 -p $((5 * LOAD_FACTOR))"
> > -$FSSTRESS_PROG $fsstress_opts -d $SCRATCH_MNT -l 0 >> $seqres.full 2>&1 &
> > +$FSSTRESS_PROG $fsstress_opts -d $testdir -l 0 >> $seqres.full 2>&1 &
> > dedup_pids=""
> > dupe_run=$TEST_DIR/${seq}-running
> > # Start several dedupe processes on same directory
> > touch $dupe_run
> > for ((i = 0; i < $((2 * LOAD_FACTOR)); i++)); do
> > while [ -e $dupe_run ]; do
> > - $DUPEREMOVE_PROG -dr --dedupe-options=same $SCRATCH_MNT/ \
> > + $DUPEREMOVE_PROG -dr --dedupe-options=same $testdir \
> > >>$seqres.full 2>&1
> > done &
> > dedup_pids="$! $dedup_pids"
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] shared/010: avoid dedupe testing blocked on large fs
2018-09-12 10:15 [PATCH] shared/010: avoid dedupe testing blocked on large fs Zorro Lang
2018-09-13 16:28 ` Eric Sandeen
@ 2018-09-13 23:01 ` Dave Chinner
2018-09-14 1:13 ` Zorro Lang
1 sibling, 1 reply; 6+ messages in thread
From: Dave Chinner @ 2018-09-13 23:01 UTC (permalink / raw)
To: Zorro Lang; +Cc: fstests
On Wed, Sep 12, 2018 at 06:15:47PM +0800, Zorro Lang wrote:
> When test on large fs (--large-fs), xfstests preallocates a large
> file in SCRATCH_MNT/ at first. Duperemove will take too long time
> to deal with that large file (many days on 500T XFS). So move
> working directory to a sub-dir underlying $SCRATCH_MNT/.
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---
>
> Hi,
>
> Besides fix this issue, this patch fix another issue passingly. I left
> a bad variable named "testdir" in this case. This patch can fix it.
>
> If maintainer feels I should fix it in another patch, please tell me:-P
>
> Thanks,
> Zorro
>
> tests/shared/010 | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/shared/010 b/tests/shared/010
> index 1817081b..04f55890 100755
> --- a/tests/shared/010
> +++ b/tests/shared/010
> @@ -65,15 +65,17 @@ function end_test()
> sleep_time=$((50 * TIME_FACTOR))
>
> # Start fsstress
> +testdir="$SCRATCH_MNT/dir"
Can we not call a temporary on the scratch device "testdir"?
Because the "test dir" name specifically refers to the test device
mount point, and using it for anything else (even though it's a
different variable) is just confusing.
Call it something like "local_dir" or "work_dir" or "stress_dir".
But not "testdir".
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] shared/010: avoid dedupe testing blocked on large fs
2018-09-13 23:01 ` Dave Chinner
@ 2018-09-14 1:13 ` Zorro Lang
2018-09-14 22:01 ` Dave Chinner
0 siblings, 1 reply; 6+ messages in thread
From: Zorro Lang @ 2018-09-14 1:13 UTC (permalink / raw)
To: Dave Chinner; +Cc: fstests
On Fri, Sep 14, 2018 at 09:01:21AM +1000, Dave Chinner wrote:
> On Wed, Sep 12, 2018 at 06:15:47PM +0800, Zorro Lang wrote:
> > When test on large fs (--large-fs), xfstests preallocates a large
> > file in SCRATCH_MNT/ at first. Duperemove will take too long time
> > to deal with that large file (many days on 500T XFS). So move
> > working directory to a sub-dir underlying $SCRATCH_MNT/.
> >
> > Signed-off-by: Zorro Lang <zlang@redhat.com>
> > ---
> >
> > Hi,
> >
> > Besides fix this issue, this patch fix another issue passingly. I left
> > a bad variable named "testdir" in this case. This patch can fix it.
> >
> > If maintainer feels I should fix it in another patch, please tell me:-P
> >
> > Thanks,
> > Zorro
> >
> > tests/shared/010 | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/shared/010 b/tests/shared/010
> > index 1817081b..04f55890 100755
> > --- a/tests/shared/010
> > +++ b/tests/shared/010
> > @@ -65,15 +65,17 @@ function end_test()
> > sleep_time=$((50 * TIME_FACTOR))
> >
> > # Start fsstress
> > +testdir="$SCRATCH_MNT/dir"
>
> Can we not call a temporary on the scratch device "testdir"?
>
> Because the "test dir" name specifically refers to the test device
> mount point, and using it for anything else (even though it's a
> different variable) is just confusing.
>
> Call it something like "local_dir" or "work_dir" or "stress_dir".
> But not "testdir".
Hmm... by running:
# grep -rsn testdir xfstests/tests
I found there're lots of "testdir"... do you need I change them all, or
just begin to notice this issue from this patch?
Thanks,
Zorro
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] shared/010: avoid dedupe testing blocked on large fs
2018-09-14 1:13 ` Zorro Lang
@ 2018-09-14 22:01 ` Dave Chinner
0 siblings, 0 replies; 6+ messages in thread
From: Dave Chinner @ 2018-09-14 22:01 UTC (permalink / raw)
To: Zorro Lang; +Cc: fstests
On Fri, Sep 14, 2018 at 09:13:45AM +0800, Zorro Lang wrote:
> On Fri, Sep 14, 2018 at 09:01:21AM +1000, Dave Chinner wrote:
> > On Wed, Sep 12, 2018 at 06:15:47PM +0800, Zorro Lang wrote:
> > > When test on large fs (--large-fs), xfstests preallocates a large
> > > file in SCRATCH_MNT/ at first. Duperemove will take too long time
> > > to deal with that large file (many days on 500T XFS). So move
> > > working directory to a sub-dir underlying $SCRATCH_MNT/.
> > >
> > > Signed-off-by: Zorro Lang <zlang@redhat.com>
> > > ---
> > >
> > > Hi,
> > >
> > > Besides fix this issue, this patch fix another issue passingly. I left
> > > a bad variable named "testdir" in this case. This patch can fix it.
> > >
> > > If maintainer feels I should fix it in another patch, please tell me:-P
> > >
> > > Thanks,
> > > Zorro
> > >
> > > tests/shared/010 | 6 ++++--
> > > 1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/tests/shared/010 b/tests/shared/010
> > > index 1817081b..04f55890 100755
> > > --- a/tests/shared/010
> > > +++ b/tests/shared/010
> > > @@ -65,15 +65,17 @@ function end_test()
> > > sleep_time=$((50 * TIME_FACTOR))
> > >
> > > # Start fsstress
> > > +testdir="$SCRATCH_MNT/dir"
> >
> > Can we not call a temporary on the scratch device "testdir"?
> >
> > Because the "test dir" name specifically refers to the test device
> > mount point, and using it for anything else (even though it's a
> > different variable) is just confusing.
> >
> > Call it something like "local_dir" or "work_dir" or "stress_dir".
> > But not "testdir".
>
> Hmm... by running:
> # grep -rsn testdir xfstests/tests
>
> I found there're lots of "testdir"... do you need I change them all, or
> just begin to notice this issue from this patch?
Just this test for now, but it would be good to clean up all the
other tests at some point.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-15 3:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-12 10:15 [PATCH] shared/010: avoid dedupe testing blocked on large fs Zorro Lang
2018-09-13 16:28 ` Eric Sandeen
2018-09-14 1:10 ` Zorro Lang
2018-09-13 23:01 ` Dave Chinner
2018-09-14 1:13 ` Zorro Lang
2018-09-14 22:01 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox