[PATCH] fstests: Don't delete seqres.full file in generic/077

[PATCH] fstests: Don't delete seqres.full file in generic/077

[Nikolay Borisov]

When this test finishes there is no 079.full file with output from commands. 
Sometimes this information is useful for post mortem so stop deleting the 
file upon test completion. 

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 tests/generic/077 | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/generic/077 b/tests/generic/077
index 284e25253c9e..d11b49c6ff15 100755
--- a/tests/generic/077
+++ b/tests/generic/077
@@ -73,6 +73,5 @@ cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
 _check_scratch_fs
 
 echo "*** all done"
-rm -f $seqres.full
 status=0
 exit
-- 
2.7.4

Re: [PATCH] fstests: Don't delete seqres.full file in generic/077

[Darrick J. Wong]

On Tue, Mar 26, 2019 at 05:01:58PM +0200, Nikolay Borisov wrote:
> When this test finishes there is no 079.full file with output from commands. 

"077.full" ?

> Sometimes this information is useful for post mortem so stop deleting the 
> file upon test completion. 
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Looks ok to me otherwise,

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

> ---
>  tests/generic/077 | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tests/generic/077 b/tests/generic/077
> index 284e25253c9e..d11b49c6ff15 100755
> --- a/tests/generic/077
> +++ b/tests/generic/077
> @@ -73,6 +73,5 @@ cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
>  _check_scratch_fs
>  
>  echo "*** all done"
> -rm -f $seqres.full

I had wondered about this myself... :)

--D

>  status=0
>  exit
> -- 
> 2.7.4
> 

Re: [PATCH] fstests: Don't delete seqres.full file in generic/077

[Nikolay Borisov]

On 26.03.19 г. 17:46 ч., Darrick J. Wong wrote:
> On Tue, Mar 26, 2019 at 05:01:58PM +0200, Nikolay Borisov wrote:
>> When this test finishes there is no 079.full file with output from commands. 
> 
> "077.full" ?

Eryu, would you fold this when merging or shall I resend?

> 
>> Sometimes this information is useful for post mortem so stop deleting the 
>> file upon test completion. 
>>
>> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> 
> Looks ok to me otherwise,
> 
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> 
>> ---
>>  tests/generic/077 | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/tests/generic/077 b/tests/generic/077
>> index 284e25253c9e..d11b49c6ff15 100755
>> --- a/tests/generic/077
>> +++ b/tests/generic/077
>> @@ -73,6 +73,5 @@ cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
>>  _check_scratch_fs
>>  
>>  echo "*** all done"
>> -rm -f $seqres.full
> 
> I had wondered about this myself... :)
> 
> --D
> 
>>  status=0
>>  exit
>> -- 
>> 2.7.4
>>
> 

Re: [PATCH] fstests: Don't delete seqres.full file in generic/077

[Eryu Guan]

On Thu, Mar 28, 2019 at 05:40:31PM +0200, Nikolay Borisov wrote:
> 
> 
> On 26.03.19 г. 17:46 ч., Darrick J. Wong wrote:
> > On Tue, Mar 26, 2019 at 05:01:58PM +0200, Nikolay Borisov wrote:
> >> When this test finishes there is no 079.full file with output from commands. 
> > 
> > "077.full" ?
> 
> Eryu, would you fold this when merging or shall I resend?

I'll fix it on merge, thanks!

Eryu
> 
> > 
> >> Sometimes this information is useful for post mortem so stop deleting the 
> >> file upon test completion. 
> >>
> >> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> > 
> > Looks ok to me otherwise,
> > 
> > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> >> ---
> >>  tests/generic/077 | 1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/tests/generic/077 b/tests/generic/077
> >> index 284e25253c9e..d11b49c6ff15 100755
> >> --- a/tests/generic/077
> >> +++ b/tests/generic/077
> >> @@ -73,6 +73,5 @@ cp -rf $filler $SCRATCH_MNT/subdir >$seqres.full 2>&1
> >>  _check_scratch_fs
> >>  
> >>  echo "*** all done"
> >> -rm -f $seqres.full
> > 
> > I had wondered about this myself... :)
> > 
> > --D
> > 
> >>  status=0
> >>  exit
> >> -- 
> >> 2.7.4
> >>
> >