* [PATCH] misc: xfs_fsop_geom_t -> struct xfs_fsop_geom
@ 2019-04-22 15:48 Darrick J. Wong
2019-04-25 7:30 ` Eryu Guan
0 siblings, 1 reply; 4+ messages in thread
From: Darrick J. Wong @ 2019-04-22 15:48 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests
From: Darrick J. Wong <darrick.wong@oracle.com>
Remove the typedef usage for the xfs geometry structure.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
dmapi/src/suite1/cmd/make_rt_sparse.c | 2 +-
ltp/fsstress.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dmapi/src/suite1/cmd/make_rt_sparse.c b/dmapi/src/suite1/cmd/make_rt_sparse.c
index 14ee8a0d..13fd3676 100644
--- a/dmapi/src/suite1/cmd/make_rt_sparse.c
+++ b/dmapi/src/suite1/cmd/make_rt_sparse.c
@@ -36,7 +36,7 @@ main(
int argc,
char **argv)
{
- xfs_fsop_geom_t geom;
+ struct xfs_fsop_geom geom;
struct fsxattr fsx;
struct dioattr dio;
char *pathname;
diff --git a/ltp/fsstress.c b/ltp/fsstress.c
index 450cf4f1..279da9f1 100644
--- a/ltp/fsstress.c
+++ b/ltp/fsstress.c
@@ -294,7 +294,7 @@ int errrange;
int errtag;
opty_t *freq_table;
int freq_table_size;
-xfs_fsop_geom_t geom;
+struct xfs_fsop_geom geom;
char *homedir;
int *ilist;
int ilistlen;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] misc: xfs_fsop_geom_t -> struct xfs_fsop_geom
2019-04-22 15:48 [PATCH] misc: xfs_fsop_geom_t -> struct xfs_fsop_geom Darrick J. Wong
@ 2019-04-25 7:30 ` Eryu Guan
2019-04-25 15:50 ` Darrick J. Wong
0 siblings, 1 reply; 4+ messages in thread
From: Eryu Guan @ 2019-04-25 7:30 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: fstests
On Mon, Apr 22, 2019 at 08:48:20AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Remove the typedef usage for the xfs geometry structure.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
I guess this is due to patch "xfs: bump XFS_IOC_FSGEOMETRY to v5
structures" which removes the xfs_fsop_geom_t typedef? And I'm wondering
if xfs/122 needs update too? as xfs/122.out contains an xfs_fsop_geom_t
entry as well.
Thanks,
Eryu
> ---
> dmapi/src/suite1/cmd/make_rt_sparse.c | 2 +-
> ltp/fsstress.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/dmapi/src/suite1/cmd/make_rt_sparse.c b/dmapi/src/suite1/cmd/make_rt_sparse.c
> index 14ee8a0d..13fd3676 100644
> --- a/dmapi/src/suite1/cmd/make_rt_sparse.c
> +++ b/dmapi/src/suite1/cmd/make_rt_sparse.c
> @@ -36,7 +36,7 @@ main(
> int argc,
> char **argv)
> {
> - xfs_fsop_geom_t geom;
> + struct xfs_fsop_geom geom;
> struct fsxattr fsx;
> struct dioattr dio;
> char *pathname;
> diff --git a/ltp/fsstress.c b/ltp/fsstress.c
> index 450cf4f1..279da9f1 100644
> --- a/ltp/fsstress.c
> +++ b/ltp/fsstress.c
> @@ -294,7 +294,7 @@ int errrange;
> int errtag;
> opty_t *freq_table;
> int freq_table_size;
> -xfs_fsop_geom_t geom;
> +struct xfs_fsop_geom geom;
> char *homedir;
> int *ilist;
> int ilistlen;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] misc: xfs_fsop_geom_t -> struct xfs_fsop_geom
2019-04-25 7:30 ` Eryu Guan
@ 2019-04-25 15:50 ` Darrick J. Wong
2019-04-26 2:30 ` Eryu Guan
0 siblings, 1 reply; 4+ messages in thread
From: Darrick J. Wong @ 2019-04-25 15:50 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests
On Thu, Apr 25, 2019 at 03:30:27PM +0800, Eryu Guan wrote:
> On Mon, Apr 22, 2019 at 08:48:20AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Remove the typedef usage for the xfs geometry structure.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> I guess this is due to patch "xfs: bump XFS_IOC_FSGEOMETRY to v5
> structures" which removes the xfs_fsop_geom_t typedef? And I'm wondering
> if xfs/122 needs update too? as xfs/122.out contains an xfs_fsop_geom_t
> entry as well.
xfs/122 does need an update for the new 5.2 ioctls, so yes, I'll send
that one along once they've landed upstream.
In the meantime, the xfs_fsop_geom_t -> struct xfs_fsop_geom conversion
ought to be applied since the struct FOO approach has always worked.
--D
> Thanks,
> Eryu
>
> > ---
> > dmapi/src/suite1/cmd/make_rt_sparse.c | 2 +-
> > ltp/fsstress.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/dmapi/src/suite1/cmd/make_rt_sparse.c b/dmapi/src/suite1/cmd/make_rt_sparse.c
> > index 14ee8a0d..13fd3676 100644
> > --- a/dmapi/src/suite1/cmd/make_rt_sparse.c
> > +++ b/dmapi/src/suite1/cmd/make_rt_sparse.c
> > @@ -36,7 +36,7 @@ main(
> > int argc,
> > char **argv)
> > {
> > - xfs_fsop_geom_t geom;
> > + struct xfs_fsop_geom geom;
> > struct fsxattr fsx;
> > struct dioattr dio;
> > char *pathname;
> > diff --git a/ltp/fsstress.c b/ltp/fsstress.c
> > index 450cf4f1..279da9f1 100644
> > --- a/ltp/fsstress.c
> > +++ b/ltp/fsstress.c
> > @@ -294,7 +294,7 @@ int errrange;
> > int errtag;
> > opty_t *freq_table;
> > int freq_table_size;
> > -xfs_fsop_geom_t geom;
> > +struct xfs_fsop_geom geom;
> > char *homedir;
> > int *ilist;
> > int ilistlen;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] misc: xfs_fsop_geom_t -> struct xfs_fsop_geom
2019-04-25 15:50 ` Darrick J. Wong
@ 2019-04-26 2:30 ` Eryu Guan
0 siblings, 0 replies; 4+ messages in thread
From: Eryu Guan @ 2019-04-26 2:30 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: fstests
On Thu, Apr 25, 2019 at 08:50:30AM -0700, Darrick J. Wong wrote:
> On Thu, Apr 25, 2019 at 03:30:27PM +0800, Eryu Guan wrote:
> > On Mon, Apr 22, 2019 at 08:48:20AM -0700, Darrick J. Wong wrote:
> > > From: Darrick J. Wong <darrick.wong@oracle.com>
> > >
> > > Remove the typedef usage for the xfs geometry structure.
> > >
> > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > I guess this is due to patch "xfs: bump XFS_IOC_FSGEOMETRY to v5
> > structures" which removes the xfs_fsop_geom_t typedef? And I'm wondering
> > if xfs/122 needs update too? as xfs/122.out contains an xfs_fsop_geom_t
> > entry as well.
>
> xfs/122 does need an update for the new 5.2 ioctls, so yes, I'll send
> that one along once they've landed upstream.
>
> In the meantime, the xfs_fsop_geom_t -> struct xfs_fsop_geom conversion
> ought to be applied since the struct FOO approach has always worked.
Ok, thanks!
Eryu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-26 2:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-22 15:48 [PATCH] misc: xfs_fsop_geom_t -> struct xfs_fsop_geom Darrick J. Wong
2019-04-25 7:30 ` Eryu Guan
2019-04-25 15:50 ` Darrick J. Wong
2019-04-26 2:30 ` Eryu Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox